From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B6B0A00C5; Wed, 2 Feb 2022 16:55:04 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 113D940E03; Wed, 2 Feb 2022 16:55:04 +0100 (CET) Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by mails.dpdk.org (Postfix) with ESMTP id D73C940DF4 for ; Wed, 2 Feb 2022 16:55:02 +0100 (CET) Received: by mail-pf1-f178.google.com with SMTP id a8so19140746pfa.6 for ; Wed, 02 Feb 2022 07:55:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WNvNwDRfBLDskCSpMNwFn+47bICqZPLV43KjH4muEec=; b=6cdjMtZ9BYtqTPgJ3C6N1QqL4sc0wUDtUNDcAb+kwxmIPiNruyl+x92NPM+Q7dWcgm O69NOtUtU8KBD/WHCfsTou6+IwSws1+CTxb6Ng2uVHWfKh2LRrh+PdLHscvOR0nhhg1E Og8aMFy6ovxE7GL8kDQOW6Uej0QQR59AUWftGdsio6U+5/Z33WPZj0jSXd9IFcbFOGui Co9yl2+GcoIXa4oPZtIw8+HIk0zeoEn4I/sCWnVVPGcvSkHI4GYbPu6pMB9S44n+hq82 GeXiAheX7gdght6NSe7NURJQjfAfGWs+ADepOpSQdqtSLHAfXvOd58RG5rWKaIdCpNXo o0EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WNvNwDRfBLDskCSpMNwFn+47bICqZPLV43KjH4muEec=; b=AGM76hbaJUVjkVZa5O/SyyjNglVl9qS9wQiKwpelBI5eLxGq1PtI9HzkXWJei9vkn4 RwZWjnDh9pfg5zesEmV3WHNpQqMuhehSrzly7bFMlqXViGZb+6Fnx630ygL6V0pcHUi4 TCK4f668YGEcjamRMS/5UtNkAQRRidJI2cI0KJyn/hibtNl1lXJRTXw/1Wc028cQ/+wG ECDsJtHRRNZaZ5JxLngBwE8pB6PQVpi5BzyZMlNzfl6Uqj+2YWy3IVa5F93EISFNNaNs 460EZljocdZOZVJ7xV3OZxTBJc/9ovyDZ6AWgvxmyT3LInu735me4rFZIzZop5thUIyG 1vAA== X-Gm-Message-State: AOAM532Zdge8YP9c4TUDgt0vP6rlPGQugZVrwhZHWff67cFFgFdlZ3DJ +6ad8nVq0bZHNU31o1dzMRqihQ== X-Google-Smtp-Source: ABdhPJzQs198tycXlPS5gGpfAKcezH5plVIgKoOIqrjrp3U6zE2n+W5n1oE0aJSRHn5DjuFxovDdwg== X-Received: by 2002:a63:8bc4:: with SMTP id j187mr1788977pge.384.1643817301979; Wed, 02 Feb 2022 07:55:01 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id g17sm7670385pfj.148.2022.02.02.07.55.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Feb 2022 07:55:01 -0800 (PST) Date: Wed, 2 Feb 2022 07:54:58 -0800 From: Stephen Hemminger To: Sean Morrissey Cc: Reshma Pattan , dev@dpdk.org Subject: Re: [PATCH v6 20/50] pdump: remove unneeded header includes Message-ID: <20220202075458.3f8cd2c1@hermes.local> In-Reply-To: <20220202094802.3618978-21-sean.morrissey@intel.com> References: <20220117201943.873922-1-sean.morrissey@intel.com> <20220202094802.3618978-1-sean.morrissey@intel.com> <20220202094802.3618978-21-sean.morrissey@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 2 Feb 2022 09:47:32 +0000 Sean Morrissey wrote: > These header includes have been flagged by the iwyu_tool > and removed. > > Signed-off-by: Sean Morrissey > --- > lib/pdump/rte_pdump.c | 1 - > lib/pdump/rte_pdump.h | 2 -- > 2 files changed, 3 deletions(-) > > diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c > index af450695ec..b3a62df591 100644 > --- a/lib/pdump/rte_pdump.c > +++ b/lib/pdump/rte_pdump.c > @@ -2,7 +2,6 @@ > * Copyright(c) 2016-2018 Intel Corporation > */ > > -#include > #include > #include > #include Yes, this code doesn't use rte_memcpy so yes, remove it. > diff --git a/lib/pdump/rte_pdump.h b/lib/pdump/rte_pdump.h > index 6efa0274f2..41c4b7800b 100644 > --- a/lib/pdump/rte_pdump.h > +++ b/lib/pdump/rte_pdump.h > @@ -13,8 +13,6 @@ > */ > > #include > -#include > -#include > #include > > #ifdef __cplusplus This header does use rte_mempool and rte_ring in rte_pdump_enable(). Not sure why IWYU thinks they should be removed. Since this is an API header, changing it here risks breaking an application.