From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1E238A00C5;
	Wed,  2 Feb 2022 16:56:45 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id EDE2240E28;
	Wed,  2 Feb 2022 16:56:44 +0100 (CET)
Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com
 [209.85.215.169])
 by mails.dpdk.org (Postfix) with ESMTP id A9CA040E03
 for <dev@dpdk.org>; Wed,  2 Feb 2022 16:56:43 +0100 (CET)
Received: by mail-pg1-f169.google.com with SMTP id e16so18656349pgn.4
 for <dev@dpdk.org>; Wed, 02 Feb 2022 07:56:43 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20210112.gappssmtp.com; s=20210112;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=TPitAcfzRORjpRGEpY74Myl7MmSATdyurTSAJreNvTU=;
 b=Sl5YtR93+EgsRBWeTNqvBI7blk/H/Gppv3uGEuQeU15Y+upYUFI3xHsQg/nTTIEOsx
 QVe8rplUMHJ2U07myqeQ+EJ4IMfASNrN+nIqc6c3CEXKQNV2r9lVRPtfxT6WJ8ltW86Z
 jvBRvDiVF/Ji+mDT0VpdtMFpyRq6vqDV4FDzocXFUtrLZxU1tWXN1HvSi4inn0dnGH0+
 SK+mXXb1viDrngIfmHVTVPmJHU2z4IOrkYoSv4YeJfovyX6G7EonAimgylhsznVfwnZp
 hw2ZS4pixPd4Vh7uLniwcfuF92efWMENWQOxvz30wTf0Z96mpOvTcxlidMaNVmVfwsyN
 zE+w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=TPitAcfzRORjpRGEpY74Myl7MmSATdyurTSAJreNvTU=;
 b=R3n8uDwN8N3x4RU427yx2GN9NFX+7RrUEHocdzwMkyenP72/Mfu+2aPu9Lj1Ts1Of7
 SuvjcvOr3j6WawsnONI8NT6yRXnqU4docz5Zlam5enwtJ97ikx9FIETCfOYY5jFk85BD
 CJXuwSv5gJNU6GHBZw2Wbi30PwPbIZboZCfZrmoJ7HS2U0Wkp3kiy9lp4lljn8+dhiDH
 cqbJur5oAwYNeGHpKcgjLxP8efZ/avmQtMAO33SzdIyemkST6S9rhO30K51I97CFVCiQ
 UC/OAXmKwonpzXFgpaP1t90XFS5/4DCIwH87MKXW3CitZr4zESBkPlOknoV5RZfVUvVv
 RCxA==
X-Gm-Message-State: AOAM532GKRgUKeRcwB6wFLW2nsCaoh/qxhBz0p6g/pqn02h1fg7/h1wU
 TiKe4Tbra7TnXkDbiGLchWIuqg==
X-Google-Smtp-Source: ABdhPJxwIVpgKzTOV5dgFv1FtyTwVtG+V8/XDCnyZpY26v6fD6Ss8jzC+0eU+OgaHBWKr66GC3NX5A==
X-Received: by 2002:a05:6a00:c94:: with SMTP id
 a20mr19116339pfv.59.1643817402809; 
 Wed, 02 Feb 2022 07:56:42 -0800 (PST)
Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199])
 by smtp.gmail.com with ESMTPSA id
 w19sm27656534pfu.47.2022.02.02.07.56.42
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 02 Feb 2022 07:56:42 -0800 (PST)
Date: Wed, 2 Feb 2022 07:56:40 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Sean Morrissey <sean.morrissey@intel.com>
Cc: Reshma Pattan <reshma.pattan@intel.com>, dev@dpdk.org
Subject: Re: [PATCH v6 22/50] pcapng: remove unneeded header includes
Message-ID: <20220202075640.014caeaa@hermes.local>
In-Reply-To: <20220202094802.3618978-23-sean.morrissey@intel.com>
References: <20220117201943.873922-1-sean.morrissey@intel.com>
 <20220202094802.3618978-1-sean.morrissey@intel.com>
 <20220202094802.3618978-23-sean.morrissey@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Wed,  2 Feb 2022 09:47:34 +0000
Sean Morrissey <sean.morrissey@intel.com> wrote:

> These header includes have been flagged by the iwyu_tool
> and removed.
> 
> Signed-off-by: Sean Morrissey <sean.morrissey@intel.com>
> ---
>  lib/pcapng/rte_pcapng.c | 1 -
>  lib/pcapng/rte_pcapng.h | 2 --
>  2 files changed, 3 deletions(-)
> 
> diff --git a/lib/pcapng/rte_pcapng.c b/lib/pcapng/rte_pcapng.c
> index 03edabe73e..5ae96a5bc9 100644
> --- a/lib/pcapng/rte_pcapng.c
> +++ b/lib/pcapng/rte_pcapng.c
> @@ -8,7 +8,6 @@
>  #include <stdlib.h>
>  #include <string.h>
>  #include <sys/uio.h>
> -#include <sys/utsname.h>
>  #include <time.h>
>  #include <unistd.h>

yes, remove this. It was leftover from earlier code where
utsname was called here in setup.

> diff --git a/lib/pcapng/rte_pcapng.h b/lib/pcapng/rte_pcapng.h
> index 8d3fbb1941..7d2697c647 100644
> --- a/lib/pcapng/rte_pcapng.h
> +++ b/lib/pcapng/rte_pcapng.h
> @@ -26,9 +26,7 @@
>  #include <stdint.h>
>  #include <sys/types.h>
>  #include <rte_compat.h>
> -#include <rte_common.h>
>  #include <rte_mempool.h>
> -#include <rte_ring.h>
>  
>  #ifdef __cplusplus
>  extern "C" {

Yes, these can go.

Acked-by: Stephen Hemminger <stephen@networkplumber.org>