From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 25D20A04A8; Mon, 7 Feb 2022 19:01:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 16B9B410F6; Mon, 7 Feb 2022 19:01:51 +0100 (CET) Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by mails.dpdk.org (Postfix) with ESMTP id 2627A410F3 for ; Mon, 7 Feb 2022 19:01:50 +0100 (CET) Received: by mail-pj1-f53.google.com with SMTP id r64-20020a17090a43c600b001b8854e682eso6508634pjg.0 for ; Mon, 07 Feb 2022 10:01:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sOVHxgSGyiXX43QR+BKDlxMvI3Zfa54ee5AaV0dAHpY=; b=BtB5as8xMVk3SWAf20fXdmSPVeqh0HwAjnsGuiKV113VlydpODIcGrJ5k2+PZyMCa3 VZiEm2ehWgkZIBUEu/zX4e6zoH6InqvV7FRQDm9Nr+uCm2CFrdo6cfeEI60pstmd9gAU Uje67k1wuuBkauB3pa14iAm6HyMXfQLXu67VaXlRqsW7hEM/o4lccYtTmRlWfaS7fPJ0 ajClt+jgci1fvZa5fIZ4CMs1sd6T3G6R2D0WQZVsGs0yOuGxLgfQTOTAz+K06QcXSTkt OPKE+hKWsp9ysaw6q62HGoPe9ryqaxHSPzJ2R8G5NaZ2lZB/IPzaf7islJtCrFisWV8K A3Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sOVHxgSGyiXX43QR+BKDlxMvI3Zfa54ee5AaV0dAHpY=; b=JqUT5/cvAStZXQLjjfTIAI+9haNOJZrZ1M3PxeDC5vvykGV8ACzsDArnen1x8JHAso bx2aby7omfogwKDh+xa6Wk2yaW62/AUPshxlMNpysXMb8JNcp9mU011npsUHHZnf4LlG EdT07mT+kuvNmxQsmy7xJqGVc1Qvti4LO7Z5f45pfXjvjLS/7lFHETKnc7ABRPZ6bQlL BVnGZdcfiGivUNwB8Ypy5tLEqYxuLI/G8iCwg831UsOnveWG7CKNgzJzadWHajWjfNL5 3CLYoeoLRueFoLMoqYn3fiG2RQ0Jylz6EUxlQF0SEPX70dzm5NNzOboxpz8ytzp6Dv62 xAHQ== X-Gm-Message-State: AOAM5320s6ao+8Qg+JJH2A1+NFmii1OD6Cqk3x9bR8q9vGOlLLRfq6BM 8sb0hnjJ97DQillYa+Gse28ogQ== X-Google-Smtp-Source: ABdhPJwI7pycMTFSbkJMU8sRx9tnNs14cgLweMUvn/itFN3+lVkyHnO8WwzabpsV0vmScivw90FOLw== X-Received: by 2002:a17:90b:3a82:: with SMTP id om2mr131238pjb.58.1644256909311; Mon, 07 Feb 2022 10:01:49 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id z15sm5437031pfh.82.2022.02.07.10.01.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Feb 2022 10:01:48 -0800 (PST) Date: Mon, 7 Feb 2022 10:01:46 -0800 From: Stephen Hemminger To: Ferruh Yigit Cc: Akhil Goyal , , , , , , , , , , , , Subject: Re: [PATCH v4 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly Message-ID: <20220207100146.23cb2e93@hermes.local> In-Reply-To: References: <20220130175935.1947730-1-gakhil@marvell.com> <20220204221334.3551574-1-gakhil@marvell.com> <20220204221334.3551574-3-gakhil@marvell.com> <20220207092330.49a0ba8a@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 7 Feb 2022 17:28:26 +0000 Ferruh Yigit wrote: > On 2/7/2022 5:23 PM, Stephen Hemminger wrote: > > On Sat, 5 Feb 2022 03:43:33 +0530 > > Akhil Goyal wrote: > > > >> +/** > >> + * @internal > >> + * Register mbuf dynamic field and flag for IP reassembly incomplete case. > >> + */ > >> +__rte_internal > >> +int > >> +rte_eth_ip_reass_dynfield_register(int *field_offset, int *flag); > > > > Maybe use RTE_INIT() constructor for this? > > Dynfiled should be registered only when users asks for the feature. right but making the user ask can lead to errors, can it be done implicitly on first use.