From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E17C5A04A8; Mon, 7 Feb 2022 20:08:26 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B5F41410EA; Mon, 7 Feb 2022 20:08:26 +0100 (CET) Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by mails.dpdk.org (Postfix) with ESMTP id DE03740689 for ; Mon, 7 Feb 2022 20:08:25 +0100 (CET) Received: by mail-pf1-f172.google.com with SMTP id u130so14642695pfc.2 for ; Mon, 07 Feb 2022 11:08:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=I5xNBMt81fisYnuXhGusQqur+ztHB1sOWFCT1u9UM7E=; b=HkRZOVSQoU/nuz/jpVQoeP/BlPd4eAaCbolUYhJHSPtUupg0yC2AsGI8Pu6sCVxOVn SF0B9n7LZyF1LnAgCTiZmTku0I0MoLn3C0eZscc5l7LNmph67qg7i7N2m71KxU7jpqDh aijaBwwIXBLvP98iDiiXBPa1aJOIgRH9Dp1q7PfNiiQn2siB90F79Mv+WTR1npI6UQ+D ME6GYKU1cTnU65lWuLvENYAcCSPDxjpvDpuI8LPmoWdbHXtRBIiWdmS1pGSth7b/ZqFG 8XB6hRJBochhvwQ3N/0VK7iIewFyAoEAdT+zcYwoDpnELsEPJMJkmcn+/JS0rz/jkMLF 3Yxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=I5xNBMt81fisYnuXhGusQqur+ztHB1sOWFCT1u9UM7E=; b=Iyh9ckgb8UgslvW0QJ7uKTLsQRrLLDSLC1/DqsVrBKhCOTr+F65Pbf/h8yogQZD4YX Ns56aSi18xz6vz/u3GN5cT70QamGKsal0eff2/TNB9j+Rr33Sa9hDhTGBmRMTZgIYkzM aXAxOtp4p9e69YB1Pa3c1PVNwgaER2mKQopXQ8Pxlv6wBjHX2nv6UQKgxIBQMPXrNtRX 2FfvEgJd3PzrL/BkiFMo+WElhmpD+RAZn2X4b0O1ZXZvznSjZxxMpAAR2+UjHzkR+1hk Pnet4rCqL2fIPrYJafXe3EZn/9D2H2G1jWSpuMvQX1FX8pj19CALosivY4zOM3xnW3Zv eWjQ== X-Gm-Message-State: AOAM533QBCSqrGg5gY3xwtx/0s34cT8eWHuXoyEyeih8p4xgNn1ujbOo 2qUGqxE5i3EpoRiNCrt6dxGFBg== X-Google-Smtp-Source: ABdhPJxTqy2bhGe6y9Ux0tLh0hMG+3vowxF9XpNWZY0dTjjLcOoIjHvTPtODxJQf4IUewtEoMrNudQ== X-Received: by 2002:a05:6a00:2442:: with SMTP id d2mr841518pfj.0.1644260904859; Mon, 07 Feb 2022 11:08:24 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id 142sm4000200pfy.41.2022.02.07.11.08.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Feb 2022 11:08:24 -0800 (PST) Date: Mon, 7 Feb 2022 11:08:21 -0800 From: Stephen Hemminger To: Akhil Goyal Cc: Ferruh Yigit , "dev@dpdk.org" , Anoob Joseph , "matan@nvidia.com" , "konstantin.ananyev@intel.com" , "thomas@monjalon.net" , "andrew.rybchenko@oktetlabs.ru" , "rosen.xu@intel.com" , "olivier.matz@6wind.com" , "david.marchand@redhat.com" , "radu.nicolau@intel.com" , Jerin Jacob Kollanukkaran , "mdr@ashroe.eu" Subject: Re: [EXT] Re: [PATCH v4 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly Message-ID: <20220207110821.21de813d@hermes.local> In-Reply-To: References: <20220130175935.1947730-1-gakhil@marvell.com> <20220204221334.3551574-1-gakhil@marvell.com> <20220204221334.3551574-3-gakhil@marvell.com> <20220207092330.49a0ba8a@hermes.local> <20220207100146.23cb2e93@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 7 Feb 2022 18:28:03 +0000 Akhil Goyal wrote: > > On Mon, 7 Feb 2022 17:28:26 +0000 > > Ferruh Yigit wrote: > > > > > On 2/7/2022 5:23 PM, Stephen Hemminger wrote: > > > > On Sat, 5 Feb 2022 03:43:33 +0530 > > > > Akhil Goyal wrote: > > > > > > > >> +/** > > > >> + * @internal > > > >> + * Register mbuf dynamic field and flag for IP reassembly incomplete > > case. > > > >> + */ > > > >> +__rte_internal > > > >> +int > > > >> +rte_eth_ip_reass_dynfield_register(int *field_offset, int *flag); > > > > > > > > Maybe use RTE_INIT() constructor for this? > > > > > > Dynfiled should be registered only when users asks for the feature. > > > > right but making the user ask can lead to errors, can it be done implicitly > > on first use. > > Registering dynfield is responsibility of PMD when the application asks for the feature. > So how can it lead to errors. Sorry, forgot this is a PMD internal thing.