From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A983EA034E; Wed, 9 Feb 2022 07:29:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9BA50410FD; Wed, 9 Feb 2022 07:29:55 +0100 (CET) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id 8D6EF410F3 for ; Wed, 9 Feb 2022 07:29:54 +0100 (CET) Received: by mail-pj1-f49.google.com with SMTP id a11-20020a17090a740b00b001b8b506c42fso4281162pjg.0 for ; Tue, 08 Feb 2022 22:29:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xKnKVahEsKdycV7nn8DG02+fZhSS2yDvFMkWFL4hpTE=; b=lUrliZx817bzNm3NAi604LlyuKrACD9VJ/KUCo4ZVaNQwVF/x7EngukBnAjCjoc56O ZmFwsvSPjdqNZourNvlRxQae9fADlmb/45zN+rjHOOusabcnpOCjhNP737XAtucQlFLL ZfOZwpdTRD/dRUdMiCpPt0IiEtlS+juZpfNzg6K4TkvhqwKtNHrZB14+Tpi7N0mDGGoh uN3X/+G38tz73Amx6CmAOaNvr1EQ+eN568tnKNCDBEl9mx7qMln+HS6iCk1CAHM9Joip 37dpSNWQELLe3e9uDBWOxLSG+SSc4Yu2H8wMQXw/7w1ktTfpRrh6wyyheEeWjAgmFqtW k6oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xKnKVahEsKdycV7nn8DG02+fZhSS2yDvFMkWFL4hpTE=; b=kB1CQNWKNLpCbjymI7qBbZ63O/crYt9E1BLC0aNM2JEh1LYZuiEPtuQZvIsrVlyulK lU+wpi3uBM1cbdjqC8oOQETEszbWHvl5vlv9UwZMmZRewfZZg6NWEqjQIkQ1vBOFttq/ JL0ZVP/vPln7QNrU7C16kcHJ6mF/jV9eqaFylA2y5rHV1Ocz28fGs8VnQCANZ92mQe75 LSIMZC7r0fOXZXYl1x7ds+4fHEGVX5wHADTFhDT9tSv1+r7vR737ySV+G8aJ0EWR4snP hhE1x5VO2HthrHij/XnsPaQxDpYaQ8tR69+6sy6485WAMLYT3yP+EiiksUXODgkbAkVT gZ+Q== X-Gm-Message-State: AOAM530xSWU5RohZ0DBAhi0+btjYXN/f8BDDxaTVu5ChHHiMQzEkUqt6 eaHnKO3ySvfVwyhtQAuVt/It5A== X-Google-Smtp-Source: ABdhPJyWH5xD4pboTFDCzLs/ds0AzMhzkGk+jzR9Fvn3Kvww/ZvJ3ClIG4Rq1zd4njPErAueq74q4w== X-Received: by 2002:a17:90b:3eca:: with SMTP id rm10mr1760817pjb.211.1644388193725; Tue, 08 Feb 2022 22:29:53 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id j14sm18677759pfj.218.2022.02.08.22.29.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Feb 2022 22:29:53 -0800 (PST) Date: Tue, 8 Feb 2022 22:29:50 -0800 From: Stephen Hemminger To: Weiguo Li Cc: dev@dpdk.org Subject: Re: [PATCH v2 00/16] add define guards to avoid multi-inclusion Message-ID: <20220208222950.5cb35bfb@hermes.local> In-Reply-To: References: <22527224.6Emhk5qWAg@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 9 Feb 2022 11:02:08 +0800 Weiguo Li wrote: > Supplement define guards to prevent multiple inclusion. > > Notice that there are couples of guard styles used in this project, > like "XX_H", "XX_H_" or "XXX_H__". > Adhere to Thomas's advice, this patch set use the first style to > make it simple. > > Weiguo Li (16): > bus/dpaa: add define guards to avoid multi-inclusion > event/octeontx: add define guards to avoid multi-inclusion > net/cxgbe: add define guards to avoid multi-inclusion > net/enetfec: add define guards to avoid multi-inclusion > net/i40e: add define guards to avoid multi-inclusion > net/netvsc: add define guards to avoid multi-inclusion > net/qede: add define guards to avoid multi-inclusion > net/tap: add define guards to avoid multi-inclusion > net/virtio: add define guards to avoid multi-inclusion > raw/ifpga/base: add define guards to avoid multi-inclusion > kni: add define guards to avoid multi-inclusion > acl: add define guards to avoid multi-inclusion > eal: add define guards to avoid multi-inclusion > efd: add define guards to avoid multi-inclusion > hash: add define guards to avoid multi-inclusion > pcapng: add define guards to avoid multi-inclusion > > drivers/bus/dpaa/base/qbman/qman.h | 5 +++++ > drivers/event/octeontx/timvf_worker.h | 5 +++++ > drivers/net/cxgbe/base/t4_regs.h | 5 +++++ > drivers/net/enetfec/enet_uio.h | 5 +++++ > drivers/net/i40e/i40e_regs.h | 5 +++++ > drivers/net/netvsc/hn_nvs.h | 5 +++++ > drivers/net/netvsc/hn_rndis.h | 5 +++++ > drivers/net/netvsc/hn_var.h | 5 +++++ > drivers/net/qede/base/reg_addr.h | 5 +++++ > drivers/net/qede/qede_sriov.h | 5 +++++ > drivers/net/tap/tap_bpf_insns.h | 5 +++++ > drivers/net/tap/tap_log.h | 5 +++++ > drivers/net/virtio/virtio_rxtx_packed_avx.h | 5 +++++ > drivers/net/virtio/virtio_rxtx_packed_neon.h | 5 +++++ > drivers/raw/ifpga/base/opae_at24_eeprom.h | 5 +++++ > kernel/linux/kni/compat.h | 5 +++++ > lib/acl/acl_run_altivec.h | 5 +++++ > lib/acl/acl_run_avx2.h | 5 +++++ > lib/acl/acl_run_avx512x16.h | 5 +++++ > lib/acl/acl_run_avx512x8.h | 5 +++++ > lib/acl/acl_run_neon.h | 5 +++++ > lib/acl/acl_run_sse.h | 5 +++++ > lib/eal/include/rte_eal_paging.h | 5 +++++ > lib/eal/windows/include/rte_virt2phys.h | 5 +++++ > lib/efd/rte_efd_x86.h | 5 +++++ > lib/hash/rte_cmp_arm64.h | 5 +++++ > lib/hash/rte_cmp_x86.h | 5 +++++ > lib/kni/rte_kni_fifo.h | 5 ++++- > lib/pcapng/pcapng_proto.h | 5 +++++ > 29 files changed, 144 insertions(+), 1 deletion(-) > Some are good, but all the drivers and internal headers this change is unnecessary. Please limit changes to where it matters.