From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A074A034E; Wed, 9 Feb 2022 20:29:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4371841143; Wed, 9 Feb 2022 20:29:55 +0100 (CET) Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by mails.dpdk.org (Postfix) with ESMTP id 639A141141 for ; Wed, 9 Feb 2022 20:29:53 +0100 (CET) Received: by mail-pj1-f53.google.com with SMTP id om7so3010522pjb.5 for ; Wed, 09 Feb 2022 11:29:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=e70iUBYB36X/CQECTUTJAGLtATKNGIWjx0JbhP8u8eo=; b=XLv9fnQy+CvTrfH6uOP6wfTHBQsgUM07RYFmSnrXxTJqwvL36Eyk6qs7hJfCtIXBuJ Fh9OgN6UMEUZgVpWwDXcvEuFbCP/5ISYz1srHqSv8z1GXfokfN9a3CbFMGQ2bU0hMD9H Ym66x6TRA1Nhji3gekMZk3Iun7j9ge0Eg33AnTvDNHf+xbug1zA9sdiQG966sFLeAz8s xM6un+QVtP5mnxYSr9UY+xcgIziyy/uqD/IlDUyr+12lmLywo8QFG8zkCEFvU6dKGcWD 3FKi04q/i+iRtgF5BlUR8oI/RBYNOg0RgG7Fx4tF0K1BFJxvaR6c1YC8AKL3qHi8Mfa9 SndA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=e70iUBYB36X/CQECTUTJAGLtATKNGIWjx0JbhP8u8eo=; b=1JjTDFyI1ZzOrj6Hf51sN9+weft9qKwYDtemh9Rdch8VZdCKLjaoaiV7E5pEu/dzH1 1+X2el5GboG1sipuGwdzqiOhwK4gWFMBC3wGT5Q+YNl0lYKexQTSRP49DpqRDno9rox/ KMB2x27rwaxBmXFqj11huiTKWLWLYp/zCC9SSx1gp8WacQt6ovJxkfJVK7M2a1+QHjM5 Q+RfGFDVTJuuxhymOHR3itA55mLaWyAP+ZWd78QrK4QlCCIDAr89HnOXEi644eJXpNuX vuFazJsNj4wiZ0cuM9HtpfJPBKHv+hXdU7vs5QwQrchYPdI8AGzqOK8OzgLPsowIUNpN +brg== X-Gm-Message-State: AOAM53242m2GO/EFlH2LxOmj/1zKZWaf5ALTQt/+yA3Q4wuQtxjQiONn Lb3QT4q3NvByQr6fZ6Q2Rvy/SA== X-Google-Smtp-Source: ABdhPJyf645dOOAMsh7wpiztoG02jGvlShCXRi0lMqu+WqciRvo3+vAUDq+txF2mOgBhS29HX8Wd2w== X-Received: by 2002:a17:902:f544:: with SMTP id h4mr3616182plf.158.1644434992609; Wed, 09 Feb 2022 11:29:52 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id e3sm14949840pgc.41.2022.02.09.11.29.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 11:29:52 -0800 (PST) Date: Wed, 9 Feb 2022 11:29:49 -0800 From: Stephen Hemminger To: Thomas Monjalon Cc: dev@dpdk.org, Stephen Hemminger , david.marchand@redhat.com Subject: Re: [PATCH] eal: remove unnecessary argv[0] handling Message-ID: <20220209112949.7742991d@hermes.local> In-Reply-To: <37375521.10thIPus4b@thomas> References: <20220202194738.404876-1-stephen@networkplumber.org> <2032198.bB369e8A3T@thomas> <20220209074519.6b3f3f5e@hermes.local> <37375521.10thIPus4b@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 09 Feb 2022 19:51:15 +0100 Thomas Monjalon wrote: > 09/02/2022 16:45, Stephen Hemminger: > > On Wed, 09 Feb 2022 15:58:26 +0100 > > Thomas Monjalon wrote: > > > > > 02/02/2022 20:47, Stephen Hemminger: > > > > The rte_eal_init function looks at argv[0] to determine > > > > the program name to pass to the log init function. > > > > This is both unnecessary and in a corner case a problem. > > > > > > > > Parsing argv[0] is unnecessary because the function openlog() > > > > already determines the log identifier from program name if > > > > NULL is passed, see openlog man page: > > > > The string pointed to by ident is prepended to every message, and is > > > > typically set to the program name. If ident is NULL, the program name > > > > is used. (POSIX.1-2008 does not specify the behavior when ident is > > > > NULL.) > > > > > > What about POSIX warning? > > > Did you test it? Which libc? What about musl? > > > > Source for musl shows that openlog accepts NULL as ident. > > It then generates log messages with ident in the message. > > In this case, it will be empty string. > It seems this solution does not work with musl. Good news: musl is available as debian package Bad news: DPDK build is broken with musl Library IPSec_MB found: YES drivers/crypto/ipsec_mb/meson.build:19:4: ERROR: Could not get define 'IMB_VERSION_STR'