Re: [PATCH v1] maintainers: update for testpmd

Re: [PATCH v1] maintainers: update for testpmd

[Ferruh Yigit]

On 2/9/2022 5:28 PM, Yuying Zhang wrote:
> Add Konstantin as maintainer of test-pmd/bpf_cmd.* files.
> 

I think makes sense, files are related to the bpf library.

> Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

> ---
>   MAINTAINERS | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index c65b753c6b..bf05e726b4 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1615,6 +1615,7 @@ M: Konstantin Ananyev <konstantin.ananyev@intel.com>
>   F: lib/bpf/
>   F: examples/bpf/
>   F: app/test/test_bpf.c
> +F: app/test-pmd/bpf_cmd.*
>   F: doc/guides/prog_guide/bpf_lib.rst
>   
>   Graph - EXPERIMENTAL

[PATCH v1] maintainers: update for testpmd

[Yuying Zhang]

Add Konstantin as maintainer of test-pmd/bpf_cmd.* files.

Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index c65b753c6b..bf05e726b4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1615,6 +1615,7 @@ M: Konstantin Ananyev <konstantin.ananyev@intel.com>
 F: lib/bpf/
 F: examples/bpf/
 F: app/test/test_bpf.c
+F: app/test-pmd/bpf_cmd.*
 F: doc/guides/prog_guide/bpf_lib.rst
 
 Graph - EXPERIMENTAL
-- 
2.25.1

[PATCH v2] maintainers: update for testpmd

[Yuying Zhang]

Move 'test-pmd/bpf_cmd.*' files under BPF component.

Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index c65b753c6b..bdbf2f9e7f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1616,6 +1616,7 @@ F: lib/bpf/
 F: examples/bpf/
 F: app/test/test_bpf.c
 F: doc/guides/prog_guide/bpf_lib.rst
+F: app/test-pmd/bpf_cmd.*
 
 Graph - EXPERIMENTAL
 M: Jerin Jacob <jerinj@marvell.com>
-- 
2.25.1

Re: [PATCH v2] maintainers: update for testpmd

[Thomas Monjalon]

10/02/2022 16:03, Yuying Zhang:
> Move 'test-pmd/bpf_cmd.*' files under BPF component.
> 
> Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Assuming Konstantin is OK.

Applied, thanks.

[PATCH v1] maintainers: update for testpmd

[Yuying Zhang]

Add Cristian as maintainer of test-pmd/cmdline_tm.* files.

Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index c65b753c6b..cab1821b11 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -406,6 +406,7 @@ F: lib/ethdev/rte_flow*
 Traffic Management API - EXPERIMENTAL
 M: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
 T: git://dpdk.org/next/dpdk-next-net
+F: app/test-pmd/cmdline_tm.*
 F: lib/ethdev/rte_tm*
 
 Traffic Metering and Policing API - EXPERIMENTAL
-- 
2.25.1

Re: [PATCH v1] maintainers: update for testpmd

[Ferruh Yigit]

On 2/9/2022 3:01 PM, Yuying Zhang wrote:
> Add Cristian as maintainer of test-pmd/cmdline_tm.* files.
> 

Hi Yuying,

Can you please update above wording slightly, instead of referring to
maintainer name, can you please say something like:

Move ' test-pmd/cmdline_tm.' under "Traffic Management API" component.

> Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
> ---
>   MAINTAINERS | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index c65b753c6b..cab1821b11 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -406,6 +406,7 @@ F: lib/ethdev/rte_flow*
>   Traffic Management API - EXPERIMENTAL
>   M: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>   T: git://dpdk.org/next/dpdk-next-net
> +F: app/test-pmd/cmdline_tm.*
>   F: lib/ethdev/rte_tm*
>   
>   Traffic Metering and Policing API - EXPERIMENTAL

Re: [PATCH v1] maintainers: update for testpmd

[Ferruh Yigit]

On 2/9/2022 9:23 AM, Dumitrescu, Cristian wrote:
> 
> 
>> -----Original Message-----
>> From: Zhang, Yuying <yuying.zhang@intel.com>
>> Sent: Wednesday, February 9, 2022 3:01 PM
>> To: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Li, Xiaoyun
>> <xiaoyun.li@intel.com>; Dumitrescu, Cristian
>> <cristian.dumitrescu@intel.com>; thomas@monjalon.net
>> Cc: Zhang, Yuying <yuying.zhang@intel.com>
>> Subject: [PATCH v1] maintainers: update for testpmd
>>
>> Add Cristian as maintainer of test-pmd/cmdline_tm.* files.
>>
>> Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
>> ---
>>   MAINTAINERS | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index c65b753c6b..cab1821b11 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -406,6 +406,7 @@ F: lib/ethdev/rte_flow*
>>   Traffic Management API - EXPERIMENTAL
>>   M: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>>   T: git://dpdk.org/next/dpdk-next-net
>> +F: app/test-pmd/cmdline_tm.*
>>   F: lib/ethdev/rte_tm*
>>
>>   Traffic Metering and Policing API - EXPERIMENTAL
>> --
>> 2.25.1
> 
> Hi Yoying,
> 
> I did not author these testpmd files myself, can you please remove my name from here and add the author instead?
> 

Hi Cristian,

Sorry, I didn't get the request.

Those testpmd files are directly related to the TM, they are added to test
the TM APIs.

 From maintenance point of view, you can comment better to changes to these
files than testpmd maintainers because they are related to the TM functionality,
and this is what happens in practice, waiting for your or Jasvinder's ack.

Is your request not to add these files under TM?
Or are you asking adding Jasvinder as additional maintainer to " Traffic Management"?


And indeed we should do the same for the 'app/test-pmd/cmdline_mtr.*' files and
add them under "Traffic Metering and Policing" component, if there will be a new
version I suggest adding this change.

  
Thanks,
ferruh

RE: [PATCH v1] maintainers: update for testpmd

[Dumitrescu, Cristian]

> -----Original Message-----
> From: Zhang, Yuying <yuying.zhang@intel.com>
> Sent: Wednesday, February 9, 2022 3:01 PM
> To: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Li, Xiaoyun
> <xiaoyun.li@intel.com>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>; thomas@monjalon.net
> Cc: Zhang, Yuying <yuying.zhang@intel.com>
> Subject: [PATCH v1] maintainers: update for testpmd
> 
> Add Cristian as maintainer of test-pmd/cmdline_tm.* files.
> 
> Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index c65b753c6b..cab1821b11 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -406,6 +406,7 @@ F: lib/ethdev/rte_flow*
>  Traffic Management API - EXPERIMENTAL
>  M: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>  T: git://dpdk.org/next/dpdk-next-net
> +F: app/test-pmd/cmdline_tm.*
>  F: lib/ethdev/rte_tm*
> 
>  Traffic Metering and Policing API - EXPERIMENTAL
> --
> 2.25.1

Hi Yoying,

I did not author these testpmd files myself, can you please remove my name from here and add the author instead?

Thanks,
Cristian

Re: [PATCH v1] maintainers: update for testpmd

[Thomas Monjalon]

> >> Add Yuying Zhang as a co-maintainer.
> >>
> >> Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
> > 
> > Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
> > 
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> > Thanks for the volunteer.
> 
> +1

Applied, thanks for volunteering,
we need more maintainers for testpmd.
I think there is room for one more, with different ideas,
ideally outside of Intel.

Re: [PATCH v1] maintainers: update for testpmd

[Ferruh Yigit]

On 1/7/2022 9:10 AM, Li, Xiaoyun wrote:
>> -----Original Message-----
>> From: Zhang, Yuying <yuying.zhang@intel.com>
>> Sent: Friday, January 7, 2022 16:54
>> To: dev@dpdk.org; Li, Xiaoyun <xiaoyun.li@intel.com>; Yigit, Ferruh
>> <ferruh.yigit@intel.com>; thomas@monjalon.net
>> Cc: Zhang, Yuying <yuying.zhang@intel.com>
>> Subject: [PATCH v1] maintainers: update for testpmd
>>
>> Add Yuying Zhang as a co-maintainer.
>>
>> Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
> 
> Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
> 

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

> Thanks for the volunteer.
> 

+1

>> ---
>>   MAINTAINERS | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 18d9edaf88..852595fe91 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1694,6 +1694,7 @@ F: app/test/sample_packet_forward.h  Networking
>> drivers testing tool
>>   M: Xiaoyun Li <xiaoyun.li@intel.com>
>>   M: Aman Singh <aman.deep.singh@intel.com>
>> +M: Yuying Zhang <yuying.zhang@intel.com>
>>   T: git://dpdk.org/next/dpdk-next-net
>>   F: app/test-pmd/
>>   F: doc/guides/testpmd_app_ug/
>> --
>> 2.25.1
> 

[PATCH v1] maintainers: update for testpmd

[Yuying Zhang]

Add Yuying Zhang as a co-maintainer.

Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 18d9edaf88..852595fe91 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1694,6 +1694,7 @@ F: app/test/sample_packet_forward.h
 Networking drivers testing tool
 M: Xiaoyun Li <xiaoyun.li@intel.com>
 M: Aman Singh <aman.deep.singh@intel.com>
+M: Yuying Zhang <yuying.zhang@intel.com>
 T: git://dpdk.org/next/dpdk-next-net
 F: app/test-pmd/
 F: doc/guides/testpmd_app_ug/
-- 
2.25.1

RE: [PATCH v1] maintainers: update for testpmd

[Li, Xiaoyun]

> -----Original Message-----
> From: Zhang, Yuying <yuying.zhang@intel.com>
> Sent: Friday, January 7, 2022 16:54
> To: dev@dpdk.org; Li, Xiaoyun <xiaoyun.li@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; thomas@monjalon.net
> Cc: Zhang, Yuying <yuying.zhang@intel.com>
> Subject: [PATCH v1] maintainers: update for testpmd
> 
> Add Yuying Zhang as a co-maintainer.
> 
> Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>

Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>

Thanks for the volunteer.

> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 18d9edaf88..852595fe91 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1694,6 +1694,7 @@ F: app/test/sample_packet_forward.h  Networking
> drivers testing tool
>  M: Xiaoyun Li <xiaoyun.li@intel.com>
>  M: Aman Singh <aman.deep.singh@intel.com>
> +M: Yuying Zhang <yuying.zhang@intel.com>
>  T: git://dpdk.org/next/dpdk-next-net
>  F: app/test-pmd/
>  F: doc/guides/testpmd_app_ug/
> --
> 2.25.1