From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2ECB1A0032; Wed, 9 Feb 2022 22:39:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7085A41199; Wed, 9 Feb 2022 22:39:01 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2065.outbound.protection.outlook.com [40.107.244.65]) by mails.dpdk.org (Postfix) with ESMTP id 207F040140 for ; Wed, 9 Feb 2022 22:38:59 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aS36Nr0CTw9oCr37wvDJsf9a0x4NuYVVS7wf8+XEVEkE1vl5fwSdcHYLmiI4KEhXS2vDXudLhr/pHYu0AeurLaOvw3jjwea701FP/YKgjgTsV5oZ96/Y/xBVY4y3MNQmFHN7Bf9s/DJd9mOLWTcv3m2sReKRPoTip769c3kEYHlrvGeTYiKFSwSH1d5egnXqhHdWHWxysVJeA+b1zSTY9f66G4M7cwuctWLXIblJo3LtexIL5Ban1qNip9IqAlxh6rB2qbgeEzgFiPBwYddj9XC/jrSo9uF0O1CJtwRfyfD25VTl5R/I2Mz8GJ3vclm9ywwX6S6f81MjU+409y7FNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UuyOyf0BPbCLnC0M2G/BM16Lb2S8HgPsQ5OG23fv07U=; b=O/okYqUhghCp/zOL1sz5kLA3KapIreZBVz3G4JG2j9AwcpaPG4Rbnfc0k28RoMD3xUuxCC8p0Ew5gGcAVhZqfeAntd+t5win1gMnAl7oTcIqEIFPMs9PPvCkVsP4CHqWJbNlyxnBb3dwQYtmaAfV30kmufIYb+Urzd0Ixlfr6im7qXBgZH47CIgOQOUEu6WzfkfKR3wm6S2s/m5e66TsAulfD8r4tDNO2qkjcnbQauiL4c4zcwCmzHWIrUkVKOrZNzd0yjm9K1ir71Lig0ZpnTp1Fh8swtqYJYuHQ86TtkB5IGu5TWk6EHfWle85mKnEXXPVlEhUh2tiPo0mfZJk7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.234) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UuyOyf0BPbCLnC0M2G/BM16Lb2S8HgPsQ5OG23fv07U=; b=kD2wMuPUWYIzEWqDzqonqGdp+dVkK6DDwW0RP25rwwKTqyJGRDWTFjDzLxU99VKeTy0t2xgQSoKZVVpY2gPfBRgwnfXauJ7fsdSPQgtToHox4LZ2W3fnm4yUfuoqxXRkjVu2DslqiRqANedet85IvoNwPfNZihSxerOEzt4VzMpQjnYWTyxxE2AjNI/eSnQrZmFY1K/yuS/Cb9CkxgqBrytoSeKrAxzCmup4HQrvY4Lf9qADjamjTD2RVSq76lZeecyMP3ouka3rBu+g+CNRYovrMHifWWvT+NWc8jjM/vqN0q3N0MP7otAoup/NdS1QEIgEeUSqrS9ReSXUILmrXg== Received: from CY4PR12MB1143.namprd12.prod.outlook.com (2603:10b6:903:38::7) by CY4PR12MB1734.namprd12.prod.outlook.com (2603:10b6:903:121::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.17; Wed, 9 Feb 2022 21:38:57 +0000 Received: from MWHPR18CA0041.namprd18.prod.outlook.com (2603:10b6:320:31::27) by CY4PR12MB1143.namprd12.prod.outlook.com (2603:10b6:903:38::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Wed, 9 Feb 2022 21:38:56 +0000 Received: from CO1NAM11FT034.eop-nam11.prod.protection.outlook.com (2603:10b6:320:31:cafe::61) by MWHPR18CA0041.outlook.office365.com (2603:10b6:320:31::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19 via Frontend Transport; Wed, 9 Feb 2022 21:38:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.234) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.234 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.234; helo=mail.nvidia.com; Received: from mail.nvidia.com (12.22.5.234) by CO1NAM11FT034.mail.protection.outlook.com (10.13.174.248) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4975.11 via Frontend Transport; Wed, 9 Feb 2022 21:38:56 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by DRHQMAIL101.nvidia.com (10.27.9.10) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 9 Feb 2022 21:38:56 +0000 Received: from pegasus01.mtr.labs.mlnx (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.9; Wed, 9 Feb 2022 13:38:52 -0800 From: Alexander Kozyrev To: CC: , , , , , , , , , Subject: [PATCH v4 08/10] app/testpmd: implement rte flow push operations Date: Wed, 9 Feb 2022 23:38:07 +0200 Message-ID: <20220209213809.1208269-9-akozyrev@nvidia.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20220209213809.1208269-1-akozyrev@nvidia.com> References: <20220206032526.816079-1-akozyrev@nvidia.com > <20220209213809.1208269-1-akozyrev@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e383a17e-87d5-424e-aea6-08d9ec14936b X-MS-TrafficTypeDiagnostic: CY4PR12MB1143:EE_|CY4PR12MB1734:EE_ X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4714; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kI48Rq8HkCc7bMT5hr7Jl99XtuRtXy7zVvHeiq4XwW5WYoN17GC5kHezTPFbriyblI+0zGOQJZ6jWNFzJFE53XsJUlmtrIeg2jDETKQLbV54csDuOzlDrBqP9xWDBkl7+JIchkc8XPgI6SoFqNFAUsvhxxK/DNmnFsCx86sAMDTkY3L0SIrC23nArTcI88zbeA5s7uarf24hTSZSZ/YLLJmImjzjXMZnphnlvHcfL+FfgbxzKWF+f6AdofWsqa9W/Q/qycqBC90YKChTzcARYCN3mMW22/wPz/V4wJFgOi+IHk7Lw4lXxc/6K8bvTsPf/hJ+rDqVOHGaGGcZzU3oTm/WI1nNKDL7VytEDcex8bHF03xF9/w5ANwjoVM4okkckwEQdfGQE86dHy7jmSGc/cFUJlVYl9XT6hvQxZKV+Hbp8BKptEYROD402HpWlqjbWf4UecSvhWyHahbt5/TNQAowQS1trhEerUUcR43XFAfMsCQkAW71455fa855Eku6M5bgz2HMYVLSjDs4vpob3Vc0CXw1yFQ3cpqxWjvj5MQ8Hf4wyAysGfC4w8wyHwoXE/o90qvc884ztuu5Mrm+VyUhVXwvo4JXB+INdtoX5Y7VBGFJ8gCwc/LcbMrcKeJvELnQLuVjVp4M8aGOuBbBZUgzGtMDcZ1dSqJbSi3HBJlSuBB/9do7c9IKa9dehYI0p5tgIPh2Ej+lUmqXSa1/Qg== X-Forefront-Antispam-Report: CIP:12.22.5.234; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(86362001)(6666004)(26005)(47076005)(2906002)(5660300002)(508600001)(2616005)(83380400001)(36756003)(36860700001)(82310400004)(186003)(7416002)(16526019)(356005)(1076003)(426003)(8676002)(8936002)(70586007)(316002)(70206006)(336012)(81166007)(40460700003)(54906003)(4326008)(6916009)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 21:38:56.5351 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e383a17e-87d5-424e-aea6-08d9ec14936b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.234]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT034.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1734 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add testpmd support for the rte_flow_q_push API. Provide the command line interface for pushing operations. Usage example: flow queue 0 push 0 Signed-off-by: Alexander Kozyrev Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 56 ++++++++++++++++++++- app/test-pmd/config.c | 28 +++++++++++ app/test-pmd/testpmd.h | 1 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 21 ++++++++ 4 files changed, 105 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index f794a83a07..11240d6f04 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -94,6 +94,7 @@ enum index { TUNNEL, FLEX, QUEUE, + PUSH, /* Flex arguments */ FLEX_ITEM_INIT, @@ -132,6 +133,9 @@ enum index { QUEUE_DESTROY_ID, QUEUE_DESTROY_POSTPONE, + /* Push arguments. */ + PUSH_QUEUE, + /* Table arguments. */ TABLE_CREATE, TABLE_DESTROY, @@ -2159,6 +2163,9 @@ static int parse_qo(struct context *, const struct token *, static int parse_qo_destroy(struct context *, const struct token *, const char *, unsigned int, void *, unsigned int); +static int parse_push(struct context *, const struct token *, + const char *, unsigned int, + void *, unsigned int); static int parse_tunnel(struct context *, const struct token *, const char *, unsigned int, void *, unsigned int); @@ -2437,7 +2444,8 @@ static const struct token token_list[] = { ISOLATE, TUNNEL, FLEX, - QUEUE)), + QUEUE, + PUSH)), .call = parse_init, }, /* Top-level command. */ @@ -2782,6 +2790,21 @@ static const struct token token_list[] = { .call = parse_qo_destroy, }, /* Top-level command. */ + [PUSH] = { + .name = "push", + .help = "push enqueued operations", + .next = NEXT(NEXT_ENTRY(PUSH_QUEUE), NEXT_ENTRY(COMMON_PORT_ID)), + .args = ARGS(ARGS_ENTRY(struct buffer, port)), + .call = parse_push, + }, + /* Sub-level commands. */ + [PUSH_QUEUE] = { + .name = "queue", + .help = "specify queue id", + .next = NEXT(NEXT_ENTRY(END), NEXT_ENTRY(COMMON_QUEUE_ID)), + .args = ARGS(ARGS_ENTRY(struct buffer, queue)), + }, + /* Top-level command. */ [INDIRECT_ACTION] = { .name = "indirect_action", .type = "{command} {port_id} [{arg} [...]]", @@ -8413,6 +8436,34 @@ parse_qo_destroy(struct context *ctx, const struct token *token, } } +/** Parse tokens for push queue command. */ +static int +parse_push(struct context *ctx, const struct token *token, + const char *str, unsigned int len, + void *buf, unsigned int size) +{ + struct buffer *out = buf; + + /* Token name must match. */ + if (parse_default(ctx, token, str, len, NULL, 0) < 0) + return -1; + /* Nothing else to do if there is no buffer. */ + if (!out) + return len; + if (!out->command) { + if (ctx->curr != PUSH) + return -1; + if (sizeof(*out) > size) + return -1; + out->command = ctx->curr; + ctx->objdata = 0; + ctx->object = out; + ctx->objmask = NULL; + out->args.vc.data = (uint8_t *)out + size; + } + return len; +} + static int parse_flex(struct context *ctx, const struct token *token, const char *str, unsigned int len, @@ -9784,6 +9835,9 @@ cmd_flow_parsed(const struct buffer *in) in->args.destroy.rule_n, in->args.destroy.rule); break; + case PUSH: + port_queue_flow_push(in->port, in->queue); + break; case INDIRECT_ACTION_CREATE: port_action_handle_create( in->port, in->args.vc.attr.group, diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index e8ae16a044..24660c01dd 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -2618,6 +2618,34 @@ port_queue_flow_destroy(portid_t port_id, queueid_t queue_id, return ret; } +/** Push all the queue operations in the queue to the NIC. */ +int +port_queue_flow_push(portid_t port_id, queueid_t queue_id) +{ + struct rte_port *port; + struct rte_flow_error error; + int ret = 0; + + if (port_id_is_invalid(port_id, ENABLED_WARN) || + port_id == (portid_t)RTE_PORT_ALL) + return -EINVAL; + port = &ports[port_id]; + + if (queue_id >= port->queue_nb) { + printf("Queue #%u is invalid\n", queue_id); + return -EINVAL; + } + + memset(&error, 0x55, sizeof(error)); + ret = rte_flow_q_push(port_id, queue_id, &error); + if (ret < 0) { + printf("Failed to push operations in the queue\n"); + return -EINVAL; + } + printf("Queue #%u operations pushed\n", queue_id); + return ret; +} + /** Create flow rule. */ int port_flow_create(portid_t port_id, diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index d0e1e3eeec..03f135ff46 100644 --- a/app/test-pmd/testpmd.h +++ b/app/test-pmd/testpmd.h @@ -939,6 +939,7 @@ int port_queue_flow_create(portid_t port_id, queueid_t queue_id, const struct rte_flow_action *actions); int port_queue_flow_destroy(portid_t port_id, queueid_t queue_id, bool postpone, uint32_t n, const uint32_t *rule); +int port_queue_flow_push(portid_t port_id, queueid_t queue_id); int port_flow_validate(portid_t port_id, const struct rte_flow_attr *attr, const struct rte_flow_item *pattern, diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst index b802288c66..01e5e3c19f 100644 --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst @@ -3396,6 +3396,10 @@ following sections. flow queue {port_id} destroy {queue_id} [postpone {boolean}] rule {rule_id} [...] +- Push enqueued operations:: + + flow push {port_id} queue {queue_id} + - Create a flow rule:: flow create {port_id} @@ -3611,6 +3615,23 @@ The usual error message is shown when a table cannot be destroyed:: Caught error type [...] ([...]): [...] +Pushing enqueued operations +~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +``flow push`` pushes all the outstanding enqueued operations +to the underlying device immediately. +It is bound to ``rte_flow_q_push()``:: + + flow push {port_id} queue {queue_id} + +If successful, it will show:: + + Queue #[...] operations pushed + +The usual error message is shown when operations cannot be pushed:: + + Caught error type [...] ([...]): [...] + Creating a tunnel stub for offload ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -- 2.18.2