From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2CE44A00C2; Thu, 10 Feb 2022 08:11:07 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E754D4013F; Thu, 10 Feb 2022 08:11:06 +0100 (CET) Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by mails.dpdk.org (Postfix) with ESMTP id 937F040041 for ; Thu, 10 Feb 2022 08:11:05 +0100 (CET) Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 21A6qGwT013543; Thu, 10 Feb 2022 07:11:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding; s=corp-2021-07-09; bh=wg9siHyLytW7KLR2sKcOQRL06ADETZjKH+6TG+bvuCE=; b=hxmF1U83s9KSXPXfRt4j1VK7Dox7b59vSJ2wxUN5ImGrbPmue+ZdR/pR25lfx/+uyc6g y5Hvudf7q9zrp+XjPTZEjXp6JSdRHt1gQQHChcyw+QUjpguhwQ5WJ/8VJ9wFO2q2Xn05 J+RRJtR+ovpqeb4BWTkwHv1zSIWaHmGDvXlfhUp1eC28JW395wE4mvg4Ui9gwOUVDVaC fROsA/cQfowyoTVsSzhrIe+iP3fCsgRqTyvPVx/yY1ZecDEuO0JLt11nrH0xqMT+3Mzn 8UrtYcczUpq+9/27alcvX69TQV2vgJgUjV1cyZvEWmS0fg8VW44YUPbTE2ApnadjxXAy wQ== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 3e345ss30q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Feb 2022 07:11:04 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 21A7B16v168378; Thu, 10 Feb 2022 07:11:03 GMT Received: from pps.reinject (localhost [127.0.0.1]) by userp3020.oracle.com with ESMTP id 3e1jpukukt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Feb 2022 07:11:03 +0000 Received: from userp3020.oracle.com (userp3020.oracle.com [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 21A7B3Di168909; Thu, 10 Feb 2022 07:11:03 GMT Received: from mmythri-7410.in.oracle.com (dhcp-10-76-41-169.vpn.oracle.com [10.76.41.169]) by userp3020.oracle.com with ESMTP id 3e1jpukugt-1; Thu, 10 Feb 2022 07:11:02 +0000 From: madhuker.mythri@oracle.com To: grive@u256.net Cc: dev@dpdk.org, Madhuker Mythri Subject: [PATCH] net/failsafe: Fix crash due to global devargs syntax parsing from secondary process Date: Thu, 10 Feb 2022 12:40:52 +0530 Message-Id: <20220210071052.527-1-madhuker.mythri@oracle.com> X-Mailer: git-send-email 2.32.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: kAuRM7qMrJ56lp51GPaUvYVG214lPIb- X-Proofpoint-ORIG-GUID: kAuRM7qMrJ56lp51GPaUvYVG214lPIb- X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Madhuker Mythri Failsafe pmd started crashing with global devargs syntax as devargs is not memset to zero. Access it to in rte_devargs_parse resulted in a crash when called from secondary process. Bugzilla Id: 933 Signed-off-by: Madhuker Mythri --- drivers/net/failsafe/failsafe.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c index 3c754a5f66..aa93cc6000 100644 --- a/drivers/net/failsafe/failsafe.c +++ b/drivers/net/failsafe/failsafe.c @@ -360,6 +360,7 @@ rte_pmd_failsafe_probe(struct rte_vdev_device *vdev) if (sdev->devargs.name[0] == '\0') continue; + memset(&devargs, 0, sizeof(devargs)); /* rebuild devargs to be able to get the bus name. */ ret = rte_devargs_parse(&devargs, sdev->devargs.name); -- 2.32.0.windows.1