DPDK patches and discussions
 help / color / mirror / Atom feed
* RE: [PATCH v1] maintainers: update for testpmd
  2022-02-09 15:01 [PATCH v1] maintainers: update for testpmd Yuying Zhang
@ 2022-02-09  9:23 ` Dumitrescu, Cristian
  2022-02-09 14:12   ` Ferruh Yigit
  2022-02-09 14:27 ` Ferruh Yigit
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 18+ messages in thread
From: Dumitrescu, Cristian @ 2022-02-09  9:23 UTC (permalink / raw)
  To: Zhang, Yuying, dev, Yigit, Ferruh, Li, Xiaoyun, thomas, Singh, Jasvinder



> -----Original Message-----
> From: Zhang, Yuying <yuying.zhang@intel.com>
> Sent: Wednesday, February 9, 2022 3:01 PM
> To: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Li, Xiaoyun
> <xiaoyun.li@intel.com>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>; thomas@monjalon.net
> Cc: Zhang, Yuying <yuying.zhang@intel.com>
> Subject: [PATCH v1] maintainers: update for testpmd
> 
> Add Cristian as maintainer of test-pmd/cmdline_tm.* files.
> 
> Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index c65b753c6b..cab1821b11 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -406,6 +406,7 @@ F: lib/ethdev/rte_flow*
>  Traffic Management API - EXPERIMENTAL
>  M: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>  T: git://dpdk.org/next/dpdk-next-net
> +F: app/test-pmd/cmdline_tm.*
>  F: lib/ethdev/rte_tm*
> 
>  Traffic Metering and Policing API - EXPERIMENTAL
> --
> 2.25.1

Hi Yoying,

I did not author these testpmd files myself, can you please remove my name from here and add the author instead?

Thanks,
Cristian

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v1] maintainers: update for testpmd
  2022-02-09  9:23 ` Dumitrescu, Cristian
@ 2022-02-09 14:12   ` Ferruh Yigit
  0 siblings, 0 replies; 18+ messages in thread
From: Ferruh Yigit @ 2022-02-09 14:12 UTC (permalink / raw)
  To: Dumitrescu, Cristian, Zhang, Yuying, dev, Li, Xiaoyun, thomas,
	Singh, Jasvinder

On 2/9/2022 9:23 AM, Dumitrescu, Cristian wrote:
> 
> 
>> -----Original Message-----
>> From: Zhang, Yuying <yuying.zhang@intel.com>
>> Sent: Wednesday, February 9, 2022 3:01 PM
>> To: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Li, Xiaoyun
>> <xiaoyun.li@intel.com>; Dumitrescu, Cristian
>> <cristian.dumitrescu@intel.com>; thomas@monjalon.net
>> Cc: Zhang, Yuying <yuying.zhang@intel.com>
>> Subject: [PATCH v1] maintainers: update for testpmd
>>
>> Add Cristian as maintainer of test-pmd/cmdline_tm.* files.
>>
>> Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
>> ---
>>   MAINTAINERS | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index c65b753c6b..cab1821b11 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -406,6 +406,7 @@ F: lib/ethdev/rte_flow*
>>   Traffic Management API - EXPERIMENTAL
>>   M: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>>   T: git://dpdk.org/next/dpdk-next-net
>> +F: app/test-pmd/cmdline_tm.*
>>   F: lib/ethdev/rte_tm*
>>
>>   Traffic Metering and Policing API - EXPERIMENTAL
>> --
>> 2.25.1
> 
> Hi Yoying,
> 
> I did not author these testpmd files myself, can you please remove my name from here and add the author instead?
> 

Hi Cristian,

Sorry, I didn't get the request.

Those testpmd files are directly related to the TM, they are added to test
the TM APIs.

 From maintenance point of view, you can comment better to changes to these
files than testpmd maintainers because they are related to the TM functionality,
and this is what happens in practice, waiting for your or Jasvinder's ack.

Is your request not to add these files under TM?
Or are you asking adding Jasvinder as additional maintainer to " Traffic Management"?


And indeed we should do the same for the 'app/test-pmd/cmdline_mtr.*' files and
add them under "Traffic Metering and Policing" component, if there will be a new
version I suggest adding this change.

  
Thanks,
ferruh

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v1] maintainers: update for testpmd
  2022-02-09 15:01 [PATCH v1] maintainers: update for testpmd Yuying Zhang
  2022-02-09  9:23 ` Dumitrescu, Cristian
@ 2022-02-09 14:27 ` Ferruh Yigit
  2022-02-10 14:51 ` [PATCH v3] " Yuying Zhang
  2022-02-10 17:11 ` [PATCH v2] " Yuying Zhang
  3 siblings, 0 replies; 18+ messages in thread
From: Ferruh Yigit @ 2022-02-09 14:27 UTC (permalink / raw)
  To: Yuying Zhang, dev, xiaoyun.li, cristian.dumitrescu, thomas

On 2/9/2022 3:01 PM, Yuying Zhang wrote:
> Add Cristian as maintainer of test-pmd/cmdline_tm.* files.
> 

Hi Yuying,

Can you please update above wording slightly, instead of referring to
maintainer name, can you please say something like:

Move ' test-pmd/cmdline_tm.' under "Traffic Management API" component.

> Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
> ---
>   MAINTAINERS | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index c65b753c6b..cab1821b11 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -406,6 +406,7 @@ F: lib/ethdev/rte_flow*
>   Traffic Management API - EXPERIMENTAL
>   M: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>   T: git://dpdk.org/next/dpdk-next-net
> +F: app/test-pmd/cmdline_tm.*
>   F: lib/ethdev/rte_tm*
>   
>   Traffic Metering and Policing API - EXPERIMENTAL


^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH v1] maintainers: update for testpmd
@ 2022-02-09 15:01 Yuying Zhang
  2022-02-09  9:23 ` Dumitrescu, Cristian
                   ` (3 more replies)
  0 siblings, 4 replies; 18+ messages in thread
From: Yuying Zhang @ 2022-02-09 15:01 UTC (permalink / raw)
  To: dev, ferruh.yigit, xiaoyun.li, cristian.dumitrescu, thomas; +Cc: Yuying Zhang

Add Cristian as maintainer of test-pmd/cmdline_tm.* files.

Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index c65b753c6b..cab1821b11 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -406,6 +406,7 @@ F: lib/ethdev/rte_flow*
 Traffic Management API - EXPERIMENTAL
 M: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
 T: git://dpdk.org/next/dpdk-next-net
+F: app/test-pmd/cmdline_tm.*
 F: lib/ethdev/rte_tm*
 
 Traffic Metering and Policing API - EXPERIMENTAL
-- 
2.25.1


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2] maintainers: update for testpmd
  2022-02-10 17:11 ` [PATCH v2] " Yuying Zhang
@ 2022-02-10 10:09   ` Ferruh Yigit
  0 siblings, 0 replies; 18+ messages in thread
From: Ferruh Yigit @ 2022-02-10 10:09 UTC (permalink / raw)
  To: Yuying Zhang, dev, xiaoyun.li, cristian.dumitrescu, thomas

On 2/10/2022 5:11 PM, Yuying Zhang wrote:
> Move 'test-pmd/cmdline_tm.*' files under
> "Traffic Management API" component.
> Move 'test-pmd/cmdline_mtr.*' files under
> "Traffic Metering and Policing API" component.
> 
> Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
> ---
>   MAINTAINERS | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index c65b753c6b..49fafd8be2 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -406,11 +406,13 @@ F: lib/ethdev/rte_flow*
>   Traffic Management API - EXPERIMENTAL
>   M: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>   T: git://dpdk.org/next/dpdk-next-net
> +F: app/test-pmd/cmdline_tm.*

Thanks Yuying,

Can you please move the testpm files under the lib files?
For both components.

>   F: lib/ethdev/rte_tm*
>   
>   Traffic Metering and Policing API - EXPERIMENTAL
>   M: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>   T: git://dpdk.org/next/dpdk-next-net
> +F: app/test-pmd/cmdline_mtr.*
>   F: lib/ethdev/rte_mtr*
>   
>   Baseband API


^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH v3] maintainers: update for testpmd
  2022-02-09 15:01 [PATCH v1] maintainers: update for testpmd Yuying Zhang
  2022-02-09  9:23 ` Dumitrescu, Cristian
  2022-02-09 14:27 ` Ferruh Yigit
@ 2022-02-10 14:51 ` Yuying Zhang
  2022-02-10 14:58   ` Ferruh Yigit
  2022-02-24 13:15   ` Dumitrescu, Cristian
  2022-02-10 17:11 ` [PATCH v2] " Yuying Zhang
  3 siblings, 2 replies; 18+ messages in thread
From: Yuying Zhang @ 2022-02-10 14:51 UTC (permalink / raw)
  To: dev, xiaoyun.li, ferruh.yigit, thomas, cristian.dumitrescu; +Cc: Yuying Zhang

Move 'test-pmd/cmdline_tm.*' files under
"Traffic Management API" component.
Move 'test-pmd/cmdline_mtr.*' files under
"Traffic Metering and Policing API" component.

Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index c65b753c6b..a650f312cd 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -407,11 +407,13 @@ Traffic Management API - EXPERIMENTAL
 M: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
 T: git://dpdk.org/next/dpdk-next-net
 F: lib/ethdev/rte_tm*
+F: app/test-pmd/cmdline_tm.*
 
 Traffic Metering and Policing API - EXPERIMENTAL
 M: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
 T: git://dpdk.org/next/dpdk-next-net
 F: lib/ethdev/rte_mtr*
+F: app/test-pmd/cmdline_mtr.*
 
 Baseband API
 M: Nicolas Chautru <nicolas.chautru@intel.com>
-- 
2.25.1


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v3] maintainers: update for testpmd
  2022-02-10 14:51 ` [PATCH v3] " Yuying Zhang
@ 2022-02-10 14:58   ` Ferruh Yigit
  2022-02-24 13:15   ` Dumitrescu, Cristian
  1 sibling, 0 replies; 18+ messages in thread
From: Ferruh Yigit @ 2022-02-10 14:58 UTC (permalink / raw)
  To: Yuying Zhang, dev, xiaoyun.li, thomas, cristian.dumitrescu

On 2/10/2022 2:51 PM, Yuying Zhang wrote:
> Move 'test-pmd/cmdline_tm.*' files under
> "Traffic Management API" component.
> Move 'test-pmd/cmdline_mtr.*' files under
> "Traffic Metering and Policing API" component.
> 
> Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH v2] maintainers: update for testpmd
  2022-02-09 15:01 [PATCH v1] maintainers: update for testpmd Yuying Zhang
                   ` (2 preceding siblings ...)
  2022-02-10 14:51 ` [PATCH v3] " Yuying Zhang
@ 2022-02-10 17:11 ` Yuying Zhang
  2022-02-10 10:09   ` Ferruh Yigit
  3 siblings, 1 reply; 18+ messages in thread
From: Yuying Zhang @ 2022-02-10 17:11 UTC (permalink / raw)
  To: dev, xiaoyun.li, ferruh.yigit, cristian.dumitrescu, thomas; +Cc: Yuying Zhang

Move 'test-pmd/cmdline_tm.*' files under
"Traffic Management API" component.
Move 'test-pmd/cmdline_mtr.*' files under
"Traffic Metering and Policing API" component.

Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index c65b753c6b..49fafd8be2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -406,11 +406,13 @@ F: lib/ethdev/rte_flow*
 Traffic Management API - EXPERIMENTAL
 M: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
 T: git://dpdk.org/next/dpdk-next-net
+F: app/test-pmd/cmdline_tm.*
 F: lib/ethdev/rte_tm*
 
 Traffic Metering and Policing API - EXPERIMENTAL
 M: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
 T: git://dpdk.org/next/dpdk-next-net
+F: app/test-pmd/cmdline_mtr.*
 F: lib/ethdev/rte_mtr*
 
 Baseband API
-- 
2.25.1


^ permalink raw reply	[flat|nested] 18+ messages in thread

* RE: [PATCH v3] maintainers: update for testpmd
  2022-02-10 14:51 ` [PATCH v3] " Yuying Zhang
  2022-02-10 14:58   ` Ferruh Yigit
@ 2022-02-24 13:15   ` Dumitrescu, Cristian
  2022-03-08 22:42     ` Thomas Monjalon
  1 sibling, 1 reply; 18+ messages in thread
From: Dumitrescu, Cristian @ 2022-02-24 13:15 UTC (permalink / raw)
  To: Zhang, Yuying, dev, Li, Xiaoyun, Yigit, Ferruh, thomas



> -----Original Message-----
> From: Zhang, Yuying <yuying.zhang@intel.com>
> Sent: Thursday, February 10, 2022 2:51 PM
> To: dev@dpdk.org; Li, Xiaoyun <xiaoyun.li@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; thomas@monjalon.net; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>
> Cc: Zhang, Yuying <yuying.zhang@intel.com>
> Subject: [PATCH v3] maintainers: update for testpmd
> 
> Move 'test-pmd/cmdline_tm.*' files under
> "Traffic Management API" component.
> Move 'test-pmd/cmdline_mtr.*' files under
> "Traffic Metering and Policing API" component.
> 
> Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index c65b753c6b..a650f312cd 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -407,11 +407,13 @@ Traffic Management API - EXPERIMENTAL
>  M: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>  T: git://dpdk.org/next/dpdk-next-net
>  F: lib/ethdev/rte_tm*
> +F: app/test-pmd/cmdline_tm.*
> 
>  Traffic Metering and Policing API - EXPERIMENTAL
>  M: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>  T: git://dpdk.org/next/dpdk-next-net
>  F: lib/ethdev/rte_mtr*
> +F: app/test-pmd/cmdline_mtr.*
> 
>  Baseband API
>  M: Nicolas Chautru <nicolas.chautru@intel.com>
> --
> 2.25.1

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v3] maintainers: update for testpmd
  2022-02-24 13:15   ` Dumitrescu, Cristian
@ 2022-03-08 22:42     ` Thomas Monjalon
  0 siblings, 0 replies; 18+ messages in thread
From: Thomas Monjalon @ 2022-03-08 22:42 UTC (permalink / raw)
  To: Zhang, Yuying, Dumitrescu, Cristian; +Cc: dev, Li, Xiaoyun, Yigit, Ferruh

24/02/2022 14:15, Dumitrescu, Cristian:
> 
> > -----Original Message-----
> > From: Zhang, Yuying <yuying.zhang@intel.com>
> > Sent: Thursday, February 10, 2022 2:51 PM
> > To: dev@dpdk.org; Li, Xiaoyun <xiaoyun.li@intel.com>; Yigit, Ferruh
> > <ferruh.yigit@intel.com>; thomas@monjalon.net; Dumitrescu, Cristian
> > <cristian.dumitrescu@intel.com>
> > Cc: Zhang, Yuying <yuying.zhang@intel.com>
> > Subject: [PATCH v3] maintainers: update for testpmd
> > 
> > Move 'test-pmd/cmdline_tm.*' files under
> > "Traffic Management API" component.
> > Move 'test-pmd/cmdline_mtr.*' files under
> > "Traffic Metering and Policing API" component.
> > 
> > Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
> > ---
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -407,11 +407,13 @@ Traffic Management API - EXPERIMENTAL
> >  M: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> >  T: git://dpdk.org/next/dpdk-next-net
> >  F: lib/ethdev/rte_tm*
> > +F: app/test-pmd/cmdline_tm.*
> > 
> >  Traffic Metering and Policing API - EXPERIMENTAL
> >  M: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> >  T: git://dpdk.org/next/dpdk-next-net
> >  F: lib/ethdev/rte_mtr*
> > +F: app/test-pmd/cmdline_mtr.*
> 
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Applied, thanks.



^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2] maintainers: update for testpmd
  2022-02-10 15:03 ` [PATCH v2] " Yuying Zhang
@ 2022-03-08 22:48   ` Thomas Monjalon
  0 siblings, 0 replies; 18+ messages in thread
From: Thomas Monjalon @ 2022-03-08 22:48 UTC (permalink / raw)
  To: Yuying Zhang; +Cc: dev, xiaoyun.li, ferruh.yigit, konstantin.ananyev

10/02/2022 16:03, Yuying Zhang:
> Move 'test-pmd/bpf_cmd.*' files under BPF component.
> 
> Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Assuming Konstantin is OK.

Applied, thanks.




^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH v2] maintainers: update for testpmd
  2022-02-09 17:28 [PATCH v1] " Yuying Zhang
@ 2022-02-10 15:03 ` Yuying Zhang
  2022-03-08 22:48   ` Thomas Monjalon
  0 siblings, 1 reply; 18+ messages in thread
From: Yuying Zhang @ 2022-02-10 15:03 UTC (permalink / raw)
  To: dev, xiaoyun.li, ferruh.yigit, thomas, konstantin.ananyev; +Cc: Yuying Zhang

Move 'test-pmd/bpf_cmd.*' files under BPF component.

Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index c65b753c6b..bdbf2f9e7f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1616,6 +1616,7 @@ F: lib/bpf/
 F: examples/bpf/
 F: app/test/test_bpf.c
 F: doc/guides/prog_guide/bpf_lib.rst
+F: app/test-pmd/bpf_cmd.*
 
 Graph - EXPERIMENTAL
 M: Jerin Jacob <jerinj@marvell.com>
-- 
2.25.1


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2] maintainers: update for testpmd
  2021-11-25 16:31         ` Ferruh Yigit
@ 2021-11-25 16:56           ` Thomas Monjalon
  0 siblings, 0 replies; 18+ messages in thread
From: Thomas Monjalon @ 2021-11-25 16:56 UTC (permalink / raw)
  To: Ferruh Yigit; +Cc: dev, Aman Singh, andrew.rybchenko

25/11/2021 17:31, Ferruh Yigit:
> On 11/25/2021 4:04 PM, Ferruh Yigit wrote:
> > On 11/25/2021 3:20 PM, Thomas Monjalon wrote:
> >> 25/11/2021 14:40, Ferruh Yigit:
> >>> On 11/25/2021 10:01 AM, Thomas Monjalon wrote:
> >>>> -Driver testing tool
> >>>> +Networking features testing tool
> >>>
> >>> "Networking features" scope is a little wide.
> >>> Not sure if "Networking features" or "Networking drivers" suits better,
> >>> according previous title it is for driver testing.
> >>
> >> Yes it is for drivers features.
> >> I want to distinguish testpmd and other tools like test-flow-perf
> >> which is also testing networking drivers.
> >>
> >> Maybe "Networking drivers features testing tool" ?
> >>
> > 
> > ack
> > 
> 
> thinking twice what additional meaning does 'features' adds here,
> "Networking drivers features testing"
> vs
> "Networking drivers testing"
> 
> Isn't "Networking drivers testing" implies features of drivers?

Yes
I was trying to avoid being too generic,
because the same title could apply to flow-perf.
But not mentioning "performance" should be enough.

OK for "Networking drivers testing tool"



^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2] maintainers: update for testpmd
  2021-11-25 16:04       ` Ferruh Yigit
@ 2021-11-25 16:31         ` Ferruh Yigit
  2021-11-25 16:56           ` Thomas Monjalon
  0 siblings, 1 reply; 18+ messages in thread
From: Ferruh Yigit @ 2021-11-25 16:31 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev, Aman Singh, andrew.rybchenko

On 11/25/2021 4:04 PM, Ferruh Yigit wrote:
> On 11/25/2021 3:20 PM, Thomas Monjalon wrote:
>> 25/11/2021 14:40, Ferruh Yigit:
>>> On 11/25/2021 10:01 AM, Thomas Monjalon wrote:
>>>> -Driver testing tool
>>>> +Networking features testing tool
>>>
>>> "Networking features" scope is a little wide.
>>> Not sure if "Networking features" or "Networking drivers" suits better,
>>> according previous title it is for driver testing.
>>
>> Yes it is for drivers features.
>> I want to distinguish testpmd and other tools like test-flow-perf
>> which is also testing networking drivers.
>>
>> Maybe "Networking drivers features testing tool" ?
>>
> 
> ack
> 

thinking twice what additional meaning does 'features' adds here,
"Networking drivers features testing"
vs
"Networking drivers testing"

Isn't "Networking drivers testing" implies features of drivers?

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2] maintainers: update for testpmd
  2021-11-25 15:20     ` Thomas Monjalon
@ 2021-11-25 16:04       ` Ferruh Yigit
  2021-11-25 16:31         ` Ferruh Yigit
  0 siblings, 1 reply; 18+ messages in thread
From: Ferruh Yigit @ 2021-11-25 16:04 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev, Aman Singh, andrew.rybchenko

On 11/25/2021 3:20 PM, Thomas Monjalon wrote:
> 25/11/2021 14:40, Ferruh Yigit:
>> On 11/25/2021 10:01 AM, Thomas Monjalon wrote:
>>> -Driver testing tool
>>> +Networking features testing tool
>>
>> "Networking features" scope is a little wide.
>> Not sure if "Networking features" or "Networking drivers" suits better,
>> according previous title it is for driver testing.
> 
> Yes it is for drivers features.
> I want to distinguish testpmd and other tools like test-flow-perf
> which is also testing networking drivers.
> 
> Maybe "Networking drivers features testing tool" ?
> 

ack


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2] maintainers: update for testpmd
  2021-11-25 13:40   ` Ferruh Yigit
@ 2021-11-25 15:20     ` Thomas Monjalon
  2021-11-25 16:04       ` Ferruh Yigit
  0 siblings, 1 reply; 18+ messages in thread
From: Thomas Monjalon @ 2021-11-25 15:20 UTC (permalink / raw)
  To: Ferruh Yigit; +Cc: dev, Aman Singh, andrew.rybchenko

25/11/2021 14:40, Ferruh Yigit:
> On 11/25/2021 10:01 AM, Thomas Monjalon wrote:
> > -Driver testing tool
> > +Networking features testing tool
> 
> "Networking features" scope is a little wide.
> Not sure if "Networking features" or "Networking drivers" suits better,
> according previous title it is for driver testing.

Yes it is for drivers features.
I want to distinguish testpmd and other tools like test-flow-perf
which is also testing networking drivers.

Maybe "Networking drivers features testing tool" ?





^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2] maintainers: update for testpmd
  2021-11-25 10:01 ` [PATCH v2] maintainers: update for testpmd Thomas Monjalon
@ 2021-11-25 13:40   ` Ferruh Yigit
  2021-11-25 15:20     ` Thomas Monjalon
  0 siblings, 1 reply; 18+ messages in thread
From: Ferruh Yigit @ 2021-11-25 13:40 UTC (permalink / raw)
  To: Thomas Monjalon, dev; +Cc: Aman Singh

On 11/25/2021 10:01 AM, Thomas Monjalon wrote:
> From: Aman Singh <aman.deep.singh@intel.com>
> 
> Add Aman Singh as co-maintainer of testpmd.
> 
> Make the title description more accurate for this tool.
> 
> Signed-off-by: Aman Singh <aman.deep.singh@intel.com>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> v2: update the section title
> ---
>   MAINTAINERS | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index d785363c5c..1b259a3d98 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1691,8 +1691,9 @@ M: Reshma Pattan <reshma.pattan@intel.com>
>   F: app/test/sample_packet_forward.c
>   F: app/test/sample_packet_forward.h
>   
> -Driver testing tool
> +Networking features testing tool

"Networking features" scope is a little wide.
Not sure if "Networking features" or "Networking drivers" suits better,
according previous title it is for driver testing.

>   M: Xiaoyun Li <xiaoyun.li@intel.com>
> +M: Aman Singh <aman.deep.singh@intel.com>
>   T: git://dpdk.org/next/dpdk-next-net
>   F: app/test-pmd/
>   F: doc/guides/testpmd_app_ug/
> 


^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH v2] maintainers: update for testpmd
  2021-10-22  7:19 [dpdk-dev] [PATCH] maintainers: update for driver testing tool Aman Singh
@ 2021-11-25 10:01 ` Thomas Monjalon
  2021-11-25 13:40   ` Ferruh Yigit
  0 siblings, 1 reply; 18+ messages in thread
From: Thomas Monjalon @ 2021-11-25 10:01 UTC (permalink / raw)
  To: dev; +Cc: Aman Singh, Ferruh Yigit

From: Aman Singh <aman.deep.singh@intel.com>

Add Aman Singh as co-maintainer of testpmd.

Make the title description more accurate for this tool.

Signed-off-by: Aman Singh <aman.deep.singh@intel.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
v2: update the section title
---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index d785363c5c..1b259a3d98 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1691,8 +1691,9 @@ M: Reshma Pattan <reshma.pattan@intel.com>
 F: app/test/sample_packet_forward.c
 F: app/test/sample_packet_forward.h
 
-Driver testing tool
+Networking features testing tool
 M: Xiaoyun Li <xiaoyun.li@intel.com>
+M: Aman Singh <aman.deep.singh@intel.com>
 T: git://dpdk.org/next/dpdk-next-net
 F: app/test-pmd/
 F: doc/guides/testpmd_app_ug/
-- 
2.33.0


^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2022-03-08 22:48 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-09 15:01 [PATCH v1] maintainers: update for testpmd Yuying Zhang
2022-02-09  9:23 ` Dumitrescu, Cristian
2022-02-09 14:12   ` Ferruh Yigit
2022-02-09 14:27 ` Ferruh Yigit
2022-02-10 14:51 ` [PATCH v3] " Yuying Zhang
2022-02-10 14:58   ` Ferruh Yigit
2022-02-24 13:15   ` Dumitrescu, Cristian
2022-03-08 22:42     ` Thomas Monjalon
2022-02-10 17:11 ` [PATCH v2] " Yuying Zhang
2022-02-10 10:09   ` Ferruh Yigit
  -- strict thread matches above, loose matches on Subject: below --
2022-02-09 17:28 [PATCH v1] " Yuying Zhang
2022-02-10 15:03 ` [PATCH v2] " Yuying Zhang
2022-03-08 22:48   ` Thomas Monjalon
2021-10-22  7:19 [dpdk-dev] [PATCH] maintainers: update for driver testing tool Aman Singh
2021-11-25 10:01 ` [PATCH v2] maintainers: update for testpmd Thomas Monjalon
2021-11-25 13:40   ` Ferruh Yigit
2021-11-25 15:20     ` Thomas Monjalon
2021-11-25 16:04       ` Ferruh Yigit
2021-11-25 16:31         ` Ferruh Yigit
2021-11-25 16:56           ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).