DPDK patches and discussions
 help / color / mirror / Atom feed
From: wenxuanx.wu@intel.com
To: qiming.yang@intel.com, qi.z.zhang@intel.com, nhorman@tuxdriver.com
Cc: dev@dpdk.org, longli@microsoft.com
Subject: [PATCH] eal/linux: fix fail to stop device monitor error
Date: Fri, 11 Feb 2022 06:53:15 +0000	[thread overview]
Message-ID: <20220211065315.66814-1-wenxuanx.wu@intel.com> (raw)

From: Wenxuan Wu <wenxuanx.wu@intel.com>

The ret value stands for whether the device monitor has been
successfully closed, and has nothing to do with
rte_intr_callback_unregister funcs once it return a value greater than 0
.So if the closure procedure has gone to the right exit point ,we should
set this value to 0.

Also ,the refmonitor has been carefully evaluted .at the beginning of
ret_dev_event_monitor_stop ,the value is 1, at the end of this func ,the
value is 0, it reveals that the monitor has been succefully closed.

Signed-off-by: Wenxuan Wu <wenxuanx.wu@intel.com>
---
 lib/eal/linux/eal_dev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/eal/linux/eal_dev.c b/lib/eal/linux/eal_dev.c
index babd444d9d..8cf7ea5520 100644
--- a/lib/eal/linux/eal_dev.c
+++ b/lib/eal/linux/eal_dev.c
@@ -366,7 +366,7 @@ rte_dev_event_monitor_stop(void)
 
 	if (!monitor_refcount) {
 		RTE_LOG(ERR, EAL, "device event monitor already stopped\n");
-		
+
 		goto exit;
 	}
 
@@ -381,7 +381,7 @@ rte_dev_event_monitor_stop(void)
 		RTE_LOG(ERR, EAL, "fail to unregister uevent callback.\n");
 		goto exit;
 	}
-	
+
 	close(rte_intr_fd_get(intr_handle));
 	rte_intr_instance_free(intr_handle);
 	intr_handle = NULL;
-- 
2.25.1


             reply	other threads:[~2022-02-11  7:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-11  6:53 wenxuanx.wu [this message]
2022-02-16  8:10 ` Long Li
2022-02-16 10:01   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220211065315.66814-1-wenxuanx.wu@intel.com \
    --to=wenxuanx.wu@intel.com \
    --cc=dev@dpdk.org \
    --cc=longli@microsoft.com \
    --cc=nhorman@tuxdriver.com \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).