* [PATCH] ethdev: remove dead code in telemetry handler
@ 2022-02-12 12:36 Gowrishankar Muthukrishnan
2022-02-14 12:10 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Gowrishankar Muthukrishnan @ 2022-02-12 12:36 UTC (permalink / raw)
To: dev
Cc: Thomas Monjalon, Ferruh Yigit, Andrew Rybchenko, jerinj,
Gowrishankar Muthukrishnan
In telemetry handler for port info, there is no need to check if
eth_dev object of a port id is not null, as it had already been
evaluated once in rte_eth_dev_is_valid_port function.
Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info")
Coverity issue: 373635
Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
---
lib/ethdev/rte_ethdev.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
index e03e669c31..3484aa2b32 100644
--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -6465,8 +6465,6 @@ eth_dev_handle_port_info(const char *cmd __rte_unused,
return -EINVAL;
eth_dev = &rte_eth_devices[port_id];
- if (!eth_dev)
- return -EINVAL;
rxq_state = rte_tel_data_alloc();
if (!rxq_state)
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ethdev: remove dead code in telemetry handler
2022-02-12 12:36 [PATCH] ethdev: remove dead code in telemetry handler Gowrishankar Muthukrishnan
@ 2022-02-14 12:10 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2022-02-14 12:10 UTC (permalink / raw)
To: Gowrishankar Muthukrishnan, dev; +Cc: Thomas Monjalon, Andrew Rybchenko, jerinj
On 2/12/2022 12:36 PM, Gowrishankar Muthukrishnan wrote:
> In telemetry handler for port info, there is no need to check if
> eth_dev object of a port id is not null, as it had already been
> evaluated once in rte_eth_dev_is_valid_port function.
>
> Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info")
> Coverity issue: 373635
>
> Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
> ---
> lib/ethdev/rte_ethdev.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
> index e03e669c31..3484aa2b32 100644
> --- a/lib/ethdev/rte_ethdev.c
> +++ b/lib/ethdev/rte_ethdev.c
> @@ -6465,8 +6465,6 @@ eth_dev_handle_port_info(const char *cmd __rte_unused,
> return -EINVAL;
>
> eth_dev = &rte_eth_devices[port_id];
> - if (!eth_dev)
> - return -EINVAL;
>
> rxq_state = rte_tel_data_alloc();
> if (!rxq_state)
Hi Gowrishankar,
Thanks for the patch.
There was already a patch for it [1] and it is merged already [2].
Updating this patch status in patchwork as rejected.
[1]
https://patches.dpdk.org/project/dpdk/patch/86e8c92e29214673983f4387dfc6a24338eae714.1644409051.git.wangyunjian@huawei.com/
[2]
https://git.dpdk.org/dpdk/commit/?id=8b8dd4451da45ce0419521d7e29fe246a5278251
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-14 12:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-12 12:36 [PATCH] ethdev: remove dead code in telemetry handler Gowrishankar Muthukrishnan
2022-02-14 12:10 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).