From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E21F4A00C4; Mon, 14 Feb 2022 10:13:53 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 76DA040DDA; Mon, 14 Feb 2022 10:13:53 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id A5DEA40C35 for ; Mon, 14 Feb 2022 10:13:51 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id E446120B96F0; Mon, 14 Feb 2022 01:13:50 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com E446120B96F0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1644830030; bh=7PX2vndunQIS8AD0AxdOZBlYNGl2OIQz+D5wtDuREMQ=; h=Date:From:To:Cc:Subject:From; b=siIKIMCWPEWXk4y+mDSSBBPMZNrx7BR/Knt7YMqgJb92aCI4B+sRn6x4FsfGxpQJj l6dlcSJ9Zzj4KtIhFsQrO6SiGXOsETXAnF0iM/MLUIkU7RgCL4l3fGDWTvCA0BAogM QdyWiY3YZUbTYUnjVIyAelnI8u52Tin6RWv43VaQ= Date: Mon, 14 Feb 2022 01:13:50 -0800 From: Tyler Retzlaff To: dev@dpdk.org, thomas@monjalon.net, ocardona@microsoft.com Cc: roretzla@microsoft.com Subject: out of tree driver builds broken with C++ Message-ID: <20220214091350.GA2793@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org while the driver api is "internal" we agreed some time ago that drivers could be built external to the dpdk tree. by enabling the meson setup option -Denable_driver_sdk=true. it was agreed that the driver api was internal and would attract no binary compatibility support which was fine. this change has now imposed a further restriction that out of tree drivers have to be authored in C only as non-C++ compatible code will invariably leak into the internal structures. you won't allow us to build C++ drivers in the dpdk tree and it seems now you are preventing building of C++ drivers outside of the tree too. could we please re-evaluate this. thanks. commit 7a335720575507f55b723b1e10bfea7daeba1386 Author: Thomas Monjalon Date: Wed Sep 15 18:46:35 2021 +0200 lib: remove C++ include guard from private headers The private headers are compiled internally with a C compiler. Thus extern "C" declaration is useless in such files. Signed-off-by: Thomas Monjalon