From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7BABEA0352; Mon, 14 Feb 2022 18:11:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6B50E41153; Mon, 14 Feb 2022 18:11:22 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 0B0154067E for ; Mon, 14 Feb 2022 18:11:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644858681; x=1676394681; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=hBTRFvg2Q9NLL5Qt4ZEvuka2Ex43eFNS+xLOsiDFymM=; b=F8qieb8TKnLuZo8MF1KOVzPhtB07YpE/1fFlyLwVOeXAxmbQ+FetLlSR fd+5MhuBffeifWWH4pa41CnMU0gQtLOkwfZfo6E4O6O9zh7SiPKacyXkj gRC2593p9WBitLfIEd83pOxFimgrnocGiHCE8b+JLj3/3BVR8oMqq7bln lwdlNZMNrIyhu4LoV2nHD/YGPOsZXpAOIohvm89lGVDCDAA1+2yDx4Jtb YDPD5P7d9jjk8QqKvRAob1pLgDd405q9xjkJ6dO0fXRFoTh13W7D9ihBP LyojtXQC3M8V2JIUNfURQMmdDTwCbDK1PTk+BxUpRsCVTXyJSnd4Qk6Qc w==; X-IronPort-AV: E=McAfee;i="6200,9189,10258"; a="230101458" X-IronPort-AV: E=Sophos;i="5.88,368,1635231600"; d="scan'208";a="230101458" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2022 09:10:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,368,1635231600"; d="scan'208";a="543746166" Received: from txandevlnx322.an.intel.com ([10.123.117.44]) by orsmga008.jf.intel.com with ESMTP; 14 Feb 2022 09:10:19 -0800 From: Naga Harish K S V To: jay.jayatheerthan@intel.com, jerinj@marvell.com Cc: dev@dpdk.org Subject: [PATCH v2] eventdev/eth_rx: fix queue config get logic Date: Mon, 14 Feb 2022 11:10:16 -0600 Message-Id: <20220214171016.961658-1-s.v.naga.harish.k@intel.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20220209050925.1552306-1-s.v.naga.harish.k@intel.com> References: <20220209050925.1552306-1-s.v.naga.harish.k@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org remove the memcpy usage in queue config get function for `event` variable which is 8 byte size and use direct copy. Also provide vector information and event buffer size in the queue config info. Fixes: da781e6488 ("eventdev/eth_rx: support Rx queue config get") Signed-off-by: Naga Harish K S V --- v2: * remove memcpy usage also provide vector data and event buffer size info --- lib/eventdev/rte_event_eth_rx_adapter.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c index ae1e260c08..28388d3abb 100644 --- a/lib/eventdev/rte_event_eth_rx_adapter.c +++ b/lib/eventdev/rte_event_eth_rx_adapter.c @@ -3194,11 +3194,11 @@ rte_event_eth_rx_adapter_queue_conf_get(uint8_t id, uint16_t rx_queue_id, struct rte_event_eth_rx_adapter_queue_conf *queue_conf) { +#define TICK2NSEC(_ticks, _freq) (((_ticks) * (1E9)) / (_freq)) struct rte_eventdev *dev; struct event_eth_rx_adapter *rx_adapter; struct eth_device_info *dev_info; struct eth_rx_queue_info *queue_info; - struct rte_event *qi_ev; int ret; if (rxa_memzone_lookup()) @@ -3229,7 +3229,6 @@ rte_event_eth_rx_adapter_queue_conf_get(uint8_t id, } queue_info = &dev_info->rx_queue[rx_queue_id]; - qi_ev = (struct rte_event *)&queue_info->event; memset(queue_conf, 0, sizeof(*queue_conf)); queue_conf->rx_queue_flags = 0; @@ -3238,7 +3237,18 @@ rte_event_eth_rx_adapter_queue_conf_get(uint8_t id, RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID; queue_conf->servicing_weight = queue_info->wt; - memcpy(&queue_conf->ev, qi_ev, sizeof(*qi_ev)); + queue_conf->ev.event = queue_info->event; + + queue_conf->vector_sz = queue_info->vector_data.max_vector_count; + queue_conf->vector_mp = queue_info->vector_data.vector_pool; + /* need to be converted from ticks to ns */ + queue_conf->vector_timeout_ns = TICK2NSEC( + queue_info->vector_data.vector_timeout_ticks, rte_get_timer_hz()); + + if (queue_info->event_buf != NULL) + queue_conf->event_buf_size = queue_info->event_buf->events_size; + else + queue_conf->event_buf_size = 0; dev = &rte_eventdevs[rx_adapter->eventdev_id]; if (dev->dev_ops->eth_rx_adapter_queue_conf_get != NULL) { -- 2.23.0