From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75E69A00C4; Thu, 17 Feb 2022 23:25:21 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 023E741153; Thu, 17 Feb 2022 23:25:15 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 28CC440395; Thu, 17 Feb 2022 23:25:12 +0100 (CET) Received: from bree.oktetlabs.ru (bree.oktetlabs.ru [192.168.34.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPS id 9F3314A; Fri, 18 Feb 2022 01:25:11 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 9F3314A Authentication-Results: shelob.oktetlabs.ru/9F3314A; dkim=none; dkim-atps=neutral From: Ivan Malov To: dev@dpdk.org Cc: stable@dpdk.org, Andrew Rybchenko , Andy Moreton Subject: [PATCH 2/3] common/sfc_efx/base: add missing handler for 1-byte fields Date: Fri, 18 Feb 2022 01:25:08 +0300 Message-Id: <20220217222509.667611-2-ivan.malov@oktetlabs.ru> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220217222509.667611-1-ivan.malov@oktetlabs.ru> References: <20220217222509.667611-1-ivan.malov@oktetlabs.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org One may set RECIRC_ID in a MAE action rule specification. This field is not a network one, and its handling goes to the code snippet which does not recognise field sizes other than 4 bytes. Add the missing handler. Fixes: 3a73dcfdb255 ("common/sfc_efx/base: match on recirc ID in action rules") Cc: stable@dpdk.org Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx_mae.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/common/sfc_efx/base/efx_mae.c b/drivers/common/sfc_efx/base/efx_mae.c index 7d48b5787e..31f51b5548 100644 --- a/drivers/common/sfc_efx/base/efx_mae.c +++ b/drivers/common/sfc_efx/base/efx_mae.c @@ -1027,6 +1027,10 @@ efx_mae_match_spec_field_set( memcpy(mvp + descp->emmd_value_offset, &dword, sizeof (dword)); break; + case 1: + memcpy(mvp + descp->emmd_value_offset, + value, 1); + break; default: EFSYS_ASSERT(B_FALSE); } @@ -1039,6 +1043,10 @@ efx_mae_match_spec_field_set( memcpy(mvp + descp->emmd_mask_offset, &dword, sizeof (dword)); break; + case 1: + memcpy(mvp + descp->emmd_mask_offset, + mask, 1); + break; default: EFSYS_ASSERT(B_FALSE); } -- 2.30.2