From: Stephen Hemminger <stephen@networkplumber.org>
To: Megha Ajmera <megha.ajmera@intel.com>
Cc: dev@dpdk.org, jasvinder.singh@intel.com,
cristian.dumitrescu@intel.com, thomas@monjalon.net
Subject: Re: [PATCH v1 1/4] sched: Cleanup qos scheduler defines from rte_config
Date: Fri, 18 Feb 2022 08:23:58 -0800 [thread overview]
Message-ID: <20220218082358.4cdc5eab@hermes.local> (raw)
In-Reply-To: <20220218074148.2549134-2-megha.ajmera@intel.com>
On Fri, 18 Feb 2022 07:41:45 +0000
Megha Ajmera <megha.ajmera@intel.com> wrote:
> diff --git a/doc/guides/sample_app_ug/qos_scheduler.rst b/doc/guides/sample_app_ug/qos_scheduler.rst
> index 49c14a00da..7016ca4078 100644
> --- a/doc/guides/sample_app_ug/qos_scheduler.rst
> +++ b/doc/guides/sample_app_ug/qos_scheduler.rst
> @@ -42,8 +42,7 @@ The application is located in the ``qos_sched`` sub-directory.
> .. note::
>
> To get statistics on the sample app using the command line interface as described in the next section,
> - DPDK must be compiled defining *RTE_SCHED_COLLECT_STATS*, which can be done by changing the relevant
> - entry in the ``config/rte_config.h`` file.
> + DPDK must be compiled after defining *RTE_SCHED_COLLECT_STATS* in the ``config/rte_config.h`` file.
Please don't have a process that requires users to edit rte_config.h
If necessary use meson options?
next prev parent reply other threads:[~2022-02-18 16:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 7:41 [PATCH v1 0/4] sched: HQoS Library cleanup Megha Ajmera
2022-02-18 7:41 ` [PATCH v1 1/4] sched: Cleanup qos scheduler defines from rte_config Megha Ajmera
2022-02-18 16:23 ` Stephen Hemminger [this message]
2022-02-18 7:41 ` [PATCH v1 2/4] sched: Always enable stats in HQoS library Megha Ajmera
2022-02-18 7:41 ` [PATCH v1 3/4] sched: Always enable best effort TC oversubscription " Megha Ajmera
2022-02-18 7:41 ` [PATCH v1 4/4] sched: Removed code defined under VECTOR Defines Megha Ajmera
2022-02-18 8:11 ` [PATCH v1 0/4] sched: HQoS Library cleanup David Marchand
2022-02-18 9:41 ` Ajmera, Megha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220218082358.4cdc5eab@hermes.local \
--to=stephen@networkplumber.org \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=megha.ajmera@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).