From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15050A034C; Wed, 23 Feb 2022 07:09:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 898E940E5A; Wed, 23 Feb 2022 07:09:48 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id 4979A40DF6 for ; Wed, 23 Feb 2022 07:09:47 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id ACDD8106F; Tue, 22 Feb 2022 22:09:46 -0800 (PST) Received: from 2p2660v4-1.austin.arm.com (2p2660v4-1.austin.arm.com [10.118.13.211]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A1A233F66F; Tue, 22 Feb 2022 22:09:46 -0800 (PST) From: Honnappa Nagarahalli To: dev@dpdk.org, honnappa.nagarahalli@arm.com, lijuan.tu@intel.com, juraj.linkes@pantheon.tech, ohilyard@iol.unh.edu, david.marchand@redhat.com, thomas@monjalon.net, jerinj@marvell.com, bruce.richardson@intel.com, stephen@networkplumber.org, bluca@debian.org, ktraynor@redhat.com, christian.ehrhardt@canonical.com, xuemingl@nvidia.com Cc: kathleen.capella@arm.com, nd@arm.com, Ruifeng Wang Subject: [PATCH v3 1/2] examples/l3fwd: use single set of variables throughout the code Date: Wed, 23 Feb 2022 00:09:30 -0600 Message-Id: <20220223060931.2661907-1-honnappa.nagarahalli@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220202060403.118301-1-honnappa.nagarahalli@arm.com> References: <20220202060403.118301-1-honnappa.nagarahalli@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org nb_rxd and nb_txd are used in polling mode and event mode of operation. nb_rxd and nb_txd are already global in polling mode but are not visible to event mode code. Make them visible to all parts of the application. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Kathleen Capella Reviewed-by: Ruifeng Wang Acked-by: Bruce Richardson --- DTS test cases require changing the RX and TX queue depths. Currently, this is achieved by patching the DPDK code. This patch set provides a mechanism to configure the queue depths while launching the application. With this change DTS test cases do not need to modify the DPDK code. v2 - Single parse function, additional validation on input (Stephen) v2 - Fixed typo (Ruifeng) and adjusted the commit msg (Kathleen). examples/l3fwd/l3fwd.h | 4 ++++ examples/l3fwd/l3fwd_event.c | 2 -- examples/l3fwd/main.c | 5 ++--- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/examples/l3fwd/l3fwd.h b/examples/l3fwd/l3fwd.h index 38ca19133c..4ccdb28b4a 100644 --- a/examples/l3fwd/l3fwd.h +++ b/examples/l3fwd/l3fwd.h @@ -81,6 +81,10 @@ struct lcore_conf { extern volatile bool force_quit; +/* RX and TX queue depths */ +extern uint16_t nb_rxd; +extern uint16_t nb_txd; + /* ethernet addresses of ports */ extern uint64_t dest_eth_addr[RTE_MAX_ETHPORTS]; extern struct rte_ether_addr ports_eth_addr[RTE_MAX_ETHPORTS]; diff --git a/examples/l3fwd/l3fwd_event.c b/examples/l3fwd/l3fwd_event.c index dd9eafa9b9..7a401290f8 100644 --- a/examples/l3fwd/l3fwd_event.c +++ b/examples/l3fwd/l3fwd_event.c @@ -43,8 +43,6 @@ l3fwd_eth_dev_port_setup(struct rte_eth_conf *port_conf) { struct l3fwd_event_resources *evt_rsrc = l3fwd_get_eventdev_rsrc(); uint16_t nb_ports = rte_eth_dev_count_avail(); - uint16_t nb_rxd = RTE_TEST_RX_DESC_DEFAULT; - uint16_t nb_txd = RTE_TEST_TX_DESC_DEFAULT; unsigned int nb_lcores = rte_lcore_count(); struct rte_eth_conf local_port_conf; struct rte_eth_dev_info dev_info; diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c index eb68ffc5aa..acd186ab7d 100644 --- a/examples/l3fwd/main.c +++ b/examples/l3fwd/main.c @@ -53,9 +53,8 @@ #define MAX_LCORE_PARAMS 1024 -/* Static global variables used within this file. */ -static uint16_t nb_rxd = RTE_TEST_RX_DESC_DEFAULT; -static uint16_t nb_txd = RTE_TEST_TX_DESC_DEFAULT; +uint16_t nb_rxd = RTE_TEST_RX_DESC_DEFAULT; +uint16_t nb_txd = RTE_TEST_TX_DESC_DEFAULT; /**< Ports set in promiscuous mode off by default. */ static int promiscuous_on; -- 2.25.1