From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3338BA034E; Thu, 24 Feb 2022 16:24:53 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF28A42710; Thu, 24 Feb 2022 16:24:50 +0100 (CET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2118.outbound.protection.outlook.com [40.107.22.118]) by mails.dpdk.org (Postfix) with ESMTP id E104840040; Thu, 24 Feb 2022 16:24:48 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dlheyVPSf+TO3TAxYS/Nj6yVhMZe78EyXOV5ZsMJT6klzYm4T5W+SQfeqanqNLB9gF+H2Icra1f6mOnaZTqnqzosbGZj0OIVxQl+cjJBrtpUBkMXzM2z7UGwUCX6cvtjEKmra+HmWpwztgQ0q6d9xdO91Tz/XTRYkR/G0V5/yCXkLhtSRlRur5Nge1RoFBYOv98hmby/sSGABTx6U1SBLzl2OEu4QGr2xnIXvOINg9+PwdyE14L8HIuPdyyceh8UQ3D3kKPwlPkdOVxBXizAUX/axO8pJ3SgrxeCZ/H4zwOkE3MEhjX4XM2XiQR6bMGDdHNxTMxANjGQjGydB2mQLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Zige4E52vW9HOI4AZ210UUffyQkW/GUDvd0qsrYPSWc=; b=GBlvPfjRkwkQ942WWKBv7rn3x31QsUhaU8MSU8E+yAHyA92UQiOdk/a2IE0/Cao1Ebni+YvF+E5Xw0MtwVD5cpICYFcmgNb42nw0T8d+HbhptPnTk+4EVKxIWn62DWMpfeZICbXQCzmHmZDkeNzKYCx++sDuUhaIxUF1Htuqd/h8GTGLYip6+XrDGVygmjDHSWzicA9BZpShR7+v1nilTUdaqR1rnxunknIYLUsMMiEcGMfKLlSp3htXvNNaX4vWZbz56dsFMh3M4nuUbA8gSOyHizrMll0txiB2N5UaIjCyUvh+xijt9C7COleu7CiEG2EVU0qOIbGI/Y/b5zSjNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silicom-usa.com; dmarc=pass action=none header.from=silicom-usa.com; dkim=pass header.d=silicom-usa.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SILICOMLTD.onmicrosoft.com; s=selector2-SILICOMLTD-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zige4E52vW9HOI4AZ210UUffyQkW/GUDvd0qsrYPSWc=; b=CnWHsrR6kWmizBcuC1ol/MucJcMzw6+gt7VMFfH//+vL3wV+aK/VmqjF87UNHHyQycn6sbeDwMMHAGVCs1e3pJYsZyVLz07Ao7e8jyduy9w3uwMARp8MdiBf8h0Zh9JOfK43BO45dZ0ROR99LWaMu9s+H8bR6dznASXDQvgzmW0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=silicom-usa.com; Received: from VI1PR0402MB3517.eurprd04.prod.outlook.com (2603:10a6:803:b::16) by AM6PR04MB4200.eurprd04.prod.outlook.com (2603:10a6:209:4f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.24; Thu, 24 Feb 2022 15:24:48 +0000 Received: from VI1PR0402MB3517.eurprd04.prod.outlook.com ([fe80::60a7:f65b:9a18:4d71]) by VI1PR0402MB3517.eurprd04.prod.outlook.com ([fe80::60a7:f65b:9a18:4d71%4]) with mapi id 15.20.4975.021; Thu, 24 Feb 2022 15:24:48 +0000 From: Jeff Daly To: dev@dpdk.org Cc: stable@dpdk.org, Haiyue Wang , Wei Zhao , Xiaolong Ye , Xiao Zhang , Lunyuan Cui Subject: [PATCH v3 2/3] net/ixgbe: Limit SDP3 check of TX_DISABLE to appropriate devices Date: Thu, 24 Feb 2022 10:23:56 -0500 Message-Id: <20220224152357.12277-3-jeffd@silicom-usa.com> In-Reply-To: <20220224152357.12277-1-jeffd@silicom-usa.com> References: <20211206221922.644187-1-stephend@silicom-usa.com> <20220224152357.12277-1-jeffd@silicom-usa.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: BN0PR03CA0043.namprd03.prod.outlook.com (2603:10b6:408:e7::18) To VI1PR0402MB3517.eurprd04.prod.outlook.com (2603:10a6:803:b::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dbf4b355-e9f3-4398-8592-08d9f7a9cafc X-MS-TrafficTypeDiagnostic: AM6PR04MB4200:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dc6IhykPe3iVvS1L7z3QALQu1r/H6AOfS3WXVB9O6wMnJ4BsMcsxs5mO/UewJm0mRp41eOXR9j3BYjG00efcrBkohr2lU37G90inhprOFg7mW5f6LVLjJiTk3AMuYvXdEGjhYi6TggcFoFDbbU+NYipBRZs/BSeFb27ugaFYHD72miyeDCbCmv0iFDTobmw6ylkbZLB0nNXbS1J9fIPZhWDjAIY4l+Hn8OumnK7hw8iSusHEXVO60om5h7ZkUQ1Vl5O1sqalcWlDc4u5iUxVqkiZNcEfMGVlyXvctWtTuU0CV0bQMGR5lIHng9PaTHqSqi+UVVkMYXxmrwHB+urKAumyM3ZugUbx4nJGS21DcBEaUGcsmTNZxwP2UV1sO7jD2PtfZqwnNnJ/t3bqiBZTJLcyXER3dFqgApdv8Z4DrpqlRmZWJuSnNw2JBcphM7WQ0QTPsxmVlrRlWylUOp4B+MJXnEgRerny96qEzA9CxQSBui+RXGBxbbkgKXB8Ym1MiOkSWWOaNZZRL2CDcUo1SuhFZdVkXe5W6CIkReADddjPmXgh+29fNAxz8pBbOCE4QAN9YZiE7Mk7wKBQVIVGwyIIFoDnANGn7jezeO6QayuK4S8ZBQVt/MlcDI4mJ/ISN/C5WjDXKcPSuH4mE8Oj4WezvT79a8MNmO8kytXH8juhHkr26MRib8/qaZO7LKnJjTh9+vxCQHNyhEKU1PecnQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR0402MB3517.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(8936002)(5660300002)(66556008)(66946007)(36756003)(4326008)(8676002)(2906002)(38350700002)(38100700002)(186003)(316002)(6916009)(6506007)(66476007)(54906003)(26005)(52116002)(6512007)(2616005)(1076003)(6666004)(6486002)(508600001)(83380400001)(86362001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?n1kpEtmZVGD2yYrpt+sB7WsgA/aIk4jPDyaTJwnqmeeZ1c1ZSo5MEv1FSMgz?= =?us-ascii?Q?Bkccv4GSw9ZUeazd7y/lnM+Rlx3irwEc/DqR7LgaNpI44Z7cbtZyEnaQq2rU?= =?us-ascii?Q?xq3sW7cVsgI1K4QN10pkU41FeBRs4rHFo5dzhog25azGydE4uWg/DpR7A9d+?= =?us-ascii?Q?haH2ltaEOxHBDaachcen4BCukwqge8n5lOtmEL0miK8LLIaXrYMOi6YxJDjg?= =?us-ascii?Q?DgMfvsWS+f5xLoTdFTTjrU4a9qCcV/fgda4bTVYX7+p8TgeIEZj7R8XucjHI?= =?us-ascii?Q?1YBXoQB/W7BUdUlrKvuYXdUana8Osp9nRKmtVLHKF3rr6aIkah8PPq6hww0Y?= =?us-ascii?Q?0jsB3uV6KHBSPGFbFiT5dqgaUiUTdNlIdE9BISO5XSA0m6lc73XUJjL2cWPI?= =?us-ascii?Q?aZy9JmSdXSw0+PuGQ0z14yvgMxadeEgOZXLOMQ2PslARS2oazHgE5mjNwgKe?= =?us-ascii?Q?wfvlGrmHenDTgWjbqPT1z0rctQbP20/JUknKunyVkxdY0DzYzu6twnH/oz+u?= =?us-ascii?Q?qE0w3KK54JTm7SpbwkPeR7lDCf35MMsDwPfkseacZnG1HHwKma8HWWnb6uSp?= =?us-ascii?Q?z683L5VFNr1GvCIfS3B99YrSh4O+fXG5xFw6OrrgJO0uC6p2es1eNVDiGiy7?= =?us-ascii?Q?KlMoF6DXXgQN6v6a79+2eqWb0g2kU7FEC+g7PkDpoP2rzY6Xh8VvmXpQGwlx?= =?us-ascii?Q?y4s1Y554AD5kxrxY9uIoiTajT2NfRfKH1djphUUAxx0OQde28Qvnkzv61Ous?= =?us-ascii?Q?EWBGqRhbclGDFkQueMHhruxhtEJh2DZcCsbLVaB5uhM0vPT2fV2BoL+sFOxG?= =?us-ascii?Q?Qw9yM4lkZy0howdighZ65ARJfftizmwr9l6XMcGTz5U8Z0Wn8anmjmsaY2XV?= =?us-ascii?Q?yOSdI5FB3iMsgQe4xaHhPDNIZX0Hz648Tgy5mf1MBKXMjQsIKj2WOk9WlAgz?= =?us-ascii?Q?lK5ynM6ZVAoM4GGQgWBOA+nAvhHYwnWJ6Sa/bd3qCxJcHjxqTsRgXeRR+Vbh?= =?us-ascii?Q?ChMqtMh9BdVpxiX0iv+3l0o6t21vsHXe2Bcp3JTfxI1Zyb5WEsj0VdiS71aV?= =?us-ascii?Q?aMANnUxmi5R2SaMCm/OcF0pzJAB1Ebhu2MEqpa/XNEU/IU11Fgsqawdc36Ex?= =?us-ascii?Q?JOSxIGDkU5/sQYFfjCVCZta8Rt9kwyntSjzVczhSD0aedbzplsT4j8WOQ60R?= =?us-ascii?Q?EvJxvAjXe9v0P+sCwuWOqlzORdtaiFXvvl9MLCc/xeAIBx+K+ecICEkSqbvJ?= =?us-ascii?Q?syhMEzYEJ3SgV677u+rbPdSSUhhWF+oFvJgvxbbyLE1RloYCHgk5rwr97KcC?= =?us-ascii?Q?on96AIeRh09CWlXMHE7wyAWUmaIeJqrVypssCEUuvlXbQJDrLJSduuzyv0Pb?= =?us-ascii?Q?xWUXyZxrKu+9mRUQD9IlaQ3IuHps/LULbZUpyOqao1xY72NKKL/S609vNQJj?= =?us-ascii?Q?9PaGfo2IpwxiwU9tHlGfeMsse6EXTaw5hSegUpxZwhrdpyWt75Wamtm0NKEo?= =?us-ascii?Q?Wm34K0/QDqpGd3d+00hbCT8H46egZzibqWd+cKUqixBlf33JDxqcuqpssXbI?= =?us-ascii?Q?x8xtKaat51uyVhnFsul2zADEAfAoWihGTTCvvycIS2wEqPM5HXhxIOJ9EsCr?= =?us-ascii?Q?kiN47pDsGkmQwEy8TJgqAAc=3D?= X-OriginatorOrg: silicom-usa.com X-MS-Exchange-CrossTenant-Network-Message-Id: dbf4b355-e9f3-4398-8592-08d9f7a9cafc X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3517.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 15:24:47.9060 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: c9e326d8-ce47-4930-8612-cc99d3c87ad1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 14yVeZ/GgBQWOABN8UB9NHZWUcOH3ag8qZteKLAYKFsYNjWc+pZFKSOY/N1iM+LHCdrZpfPtLDy8ik58LbsOqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4200 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 1ca05831b9b added a check that SDP3 (used as a TX_DISABLE output to the SFP cage on these cards) is not asserted to avoid incorrectly reporting link up when the SFP's laser is turned off. ff8162cb957 limited this workaround to fiber ports This patch: * Adds additional check for 82599 type, not all fiber ixgbe devs use SDP3 as TX_DISABLE Fixes: 1ca05831b9b ("net/ixgbe: fix link status") Fixes: ff8162cb957 ("net/ixgbe: fix link status") Cc: stable@dpdk.org Signed-off-by: Jeff Daly --- drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 68b28b1ce6..e8f07cb405 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -4260,7 +4260,8 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, return rte_eth_linkstatus_set(dev, &link); } - if (ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) { + if (hw->mac.type == ixgbe_mac_82599EB && + ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) { esdp_reg = IXGBE_READ_REG(hw, IXGBE_ESDP); if ((esdp_reg & IXGBE_ESDP_SDP3)) link_up = 0; -- 2.25.1