* [PATCH] ci: remove redundant drivers enabling
@ 2022-02-26 18:36 Thomas Monjalon
2022-02-28 9:46 ` Bruce Richardson
2022-03-01 10:04 ` [PATCH v2] " Thomas Monjalon
0 siblings, 2 replies; 7+ messages in thread
From: Thomas Monjalon @ 2022-02-26 18:36 UTC (permalink / raw)
To: dev; +Cc: Aaron Conole, Michael Santana, Bruce Richardson
No need to explicitly enable drivers bus/vdev and mempool/ring.
bus/vdev is always enabled since
commit 2e33309ebe03 ("config: enable/disable drivers in Arm builds")
mempool/ring is always enabled since
commit 81c2337e044d ("build: make ring mempool driver mandatory")
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
.ci/linux-build.sh | 2 +-
devtools/test-meson-builds.sh | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
index 67d68535e0..77c0d1976b 100755
--- a/.ci/linux-build.sh
+++ b/.ci/linux-build.sh
@@ -89,7 +89,7 @@ OPTS="$OPTS --default-library=$DEF_LIB"
OPTS="$OPTS --buildtype=debugoptimized"
OPTS="$OPTS -Dcheck_includes=true"
if [ "$MINI" = "true" ]; then
- OPTS="$OPTS -Denable_drivers=bus/vdev,mempool/ring,net/null"
+ OPTS="$OPTS -Denable_drivers=net/null"
OPTS="$OPTS -Ddisable_libs=*"
fi
meson build --werror $OPTS
diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh
index c07fd16fdc..a653b253cb 100755
--- a/devtools/test-meson-builds.sh
+++ b/devtools/test-meson-builds.sh
@@ -221,7 +221,7 @@ for c in gcc clang ; do
done
build build-mini cc skipABI $use_shared -Ddisable_libs=* \
- -Denable_drivers=bus/vdev,mempool/ring,net/null
+ -Denable_drivers=net/null
# test compilation with minimal x86 instruction set
# Set the install path for libraries to "lib" explicitly to prevent problems
--
2.34.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ci: remove redundant drivers enabling
2022-02-26 18:36 [PATCH] ci: remove redundant drivers enabling Thomas Monjalon
@ 2022-02-28 9:46 ` Bruce Richardson
2022-02-28 10:17 ` David Marchand
2022-03-01 10:04 ` [PATCH v2] " Thomas Monjalon
1 sibling, 1 reply; 7+ messages in thread
From: Bruce Richardson @ 2022-02-28 9:46 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, Aaron Conole, Michael Santana
On Sat, Feb 26, 2022 at 07:36:51PM +0100, Thomas Monjalon wrote:
> No need to explicitly enable drivers bus/vdev and mempool/ring.
>
> bus/vdev is always enabled since
> commit 2e33309ebe03 ("config: enable/disable drivers in Arm builds")
>
> mempool/ring is always enabled since
> commit 81c2337e044d ("build: make ring mempool driver mandatory")
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
One comment inline below.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> .ci/linux-build.sh | 2 +-
> devtools/test-meson-builds.sh | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
> index 67d68535e0..77c0d1976b 100755
> --- a/.ci/linux-build.sh
> +++ b/.ci/linux-build.sh
> @@ -89,7 +89,7 @@ OPTS="$OPTS --default-library=$DEF_LIB"
> OPTS="$OPTS --buildtype=debugoptimized"
> OPTS="$OPTS -Dcheck_includes=true"
> if [ "$MINI" = "true" ]; then
> - OPTS="$OPTS -Denable_drivers=bus/vdev,mempool/ring,net/null"
> + OPTS="$OPTS -Denable_drivers=net/null"
> OPTS="$OPTS -Ddisable_libs=*"
> fi
> meson build --werror $OPTS
> diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh
> index c07fd16fdc..a653b253cb 100755
> --- a/devtools/test-meson-builds.sh
> +++ b/devtools/test-meson-builds.sh
> @@ -221,7 +221,7 @@ for c in gcc clang ; do
> done
>
> build build-mini cc skipABI $use_shared -Ddisable_libs=* \
> - -Denable_drivers=bus/vdev,mempool/ring,net/null
> + -Denable_drivers=net/null
Do we even need this enabled for a mini-build. Would disable_drivers=*/*
not work better to truly have a minimal build?
>
> # test compilation with minimal x86 instruction set
> # Set the install path for libraries to "lib" explicitly to prevent problems
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ci: remove redundant drivers enabling
2022-02-28 9:46 ` Bruce Richardson
@ 2022-02-28 10:17 ` David Marchand
2022-02-28 10:19 ` Bruce Richardson
0 siblings, 1 reply; 7+ messages in thread
From: David Marchand @ 2022-02-28 10:17 UTC (permalink / raw)
To: Bruce Richardson; +Cc: Thomas Monjalon, dev, Aaron Conole, Michael Santana
On Mon, Feb 28, 2022 at 10:46 AM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> On Sat, Feb 26, 2022 at 07:36:51PM +0100, Thomas Monjalon wrote:
> > No need to explicitly enable drivers bus/vdev and mempool/ring.
> >
> > bus/vdev is always enabled since
> > commit 2e33309ebe03 ("config: enable/disable drivers in Arm builds")
> >
> > mempool/ring is always enabled since
> > commit 81c2337e044d ("build: make ring mempool driver mandatory")
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
> One comment inline below.
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> > .ci/linux-build.sh | 2 +-
> > devtools/test-meson-builds.sh | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
> > index 67d68535e0..77c0d1976b 100755
> > --- a/.ci/linux-build.sh
> > +++ b/.ci/linux-build.sh
> > @@ -89,7 +89,7 @@ OPTS="$OPTS --default-library=$DEF_LIB"
> > OPTS="$OPTS --buildtype=debugoptimized"
> > OPTS="$OPTS -Dcheck_includes=true"
> > if [ "$MINI" = "true" ]; then
> > - OPTS="$OPTS -Denable_drivers=bus/vdev,mempool/ring,net/null"
> > + OPTS="$OPTS -Denable_drivers=net/null"
> > OPTS="$OPTS -Ddisable_libs=*"
> > fi
> > meson build --werror $OPTS
> > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh
> > index c07fd16fdc..a653b253cb 100755
> > --- a/devtools/test-meson-builds.sh
> > +++ b/devtools/test-meson-builds.sh
> > @@ -221,7 +221,7 @@ for c in gcc clang ; do
> > done
> >
> > build build-mini cc skipABI $use_shared -Ddisable_libs=* \
> > - -Denable_drivers=bus/vdev,mempool/ring,net/null
> > + -Denable_drivers=net/null
>
> Do we even need this enabled for a mini-build. Would disable_drivers=*/*
> not work better to truly have a minimal build?
In GHA, for native builds, test-null.sh is called, and it uses net/null ports.
https://git.dpdk.org/dpdk/tree/.ci/linux-build.sh#n101
--
David Marchand
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ci: remove redundant drivers enabling
2022-02-28 10:17 ` David Marchand
@ 2022-02-28 10:19 ` Bruce Richardson
0 siblings, 0 replies; 7+ messages in thread
From: Bruce Richardson @ 2022-02-28 10:19 UTC (permalink / raw)
To: David Marchand; +Cc: Thomas Monjalon, dev, Aaron Conole, Michael Santana
On Mon, Feb 28, 2022 at 11:17:07AM +0100, David Marchand wrote:
> On Mon, Feb 28, 2022 at 10:46 AM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > On Sat, Feb 26, 2022 at 07:36:51PM +0100, Thomas Monjalon wrote:
> > > No need to explicitly enable drivers bus/vdev and mempool/ring.
> > >
> > > bus/vdev is always enabled since
> > > commit 2e33309ebe03 ("config: enable/disable drivers in Arm builds")
> > >
> > > mempool/ring is always enabled since
> > > commit 81c2337e044d ("build: make ring mempool driver mandatory")
> > >
> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> >
> > One comment inline below.
> >
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> > > ---
> > > .ci/linux-build.sh | 2 +-
> > > devtools/test-meson-builds.sh | 2 +-
> > > 2 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
> > > index 67d68535e0..77c0d1976b 100755
> > > --- a/.ci/linux-build.sh
> > > +++ b/.ci/linux-build.sh
> > > @@ -89,7 +89,7 @@ OPTS="$OPTS --default-library=$DEF_LIB"
> > > OPTS="$OPTS --buildtype=debugoptimized"
> > > OPTS="$OPTS -Dcheck_includes=true"
> > > if [ "$MINI" = "true" ]; then
> > > - OPTS="$OPTS -Denable_drivers=bus/vdev,mempool/ring,net/null"
> > > + OPTS="$OPTS -Denable_drivers=net/null"
> > > OPTS="$OPTS -Ddisable_libs=*"
> > > fi
> > > meson build --werror $OPTS
> > > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh
> > > index c07fd16fdc..a653b253cb 100755
> > > --- a/devtools/test-meson-builds.sh
> > > +++ b/devtools/test-meson-builds.sh
> > > @@ -221,7 +221,7 @@ for c in gcc clang ; do
> > > done
> > >
> > > build build-mini cc skipABI $use_shared -Ddisable_libs=* \
> > > - -Denable_drivers=bus/vdev,mempool/ring,net/null
> > > + -Denable_drivers=net/null
> >
> > Do we even need this enabled for a mini-build. Would disable_drivers=*/*
> > not work better to truly have a minimal build?
>
> In GHA, for native builds, test-null.sh is called, and it uses net/null ports.
> https://git.dpdk.org/dpdk/tree/.ci/linux-build.sh#n101
>
Ok, thanks for clarifying, all good so.
/Bruce
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] ci: remove redundant drivers enabling
2022-02-26 18:36 [PATCH] ci: remove redundant drivers enabling Thomas Monjalon
2022-02-28 9:46 ` Bruce Richardson
@ 2022-03-01 10:04 ` Thomas Monjalon
2022-03-01 10:57 ` David Marchand
1 sibling, 1 reply; 7+ messages in thread
From: Thomas Monjalon @ 2022-03-01 10:04 UTC (permalink / raw)
To: dev; +Cc: david.marchand, Bruce Richardson, Aaron Conole, Michael Santana
No need to explicitly enable drivers bus/vdev and mempool/ring.
bus/vdev is always enabled since
commit 2e33309ebe03 ("config: enable/disable drivers in Arm builds")
mempool/ring is always enabled since
commit 81c2337e044d ("build: make ring mempool driver mandatory")
The driver net/null is kept to allow running test-null.sh.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
v2: precise net/null justification in commit log
---
.ci/linux-build.sh | 2 +-
devtools/test-meson-builds.sh | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
index 05aa21ec69..69940dec8b 100755
--- a/.ci/linux-build.sh
+++ b/.ci/linux-build.sh
@@ -89,7 +89,7 @@ OPTS="$OPTS --default-library=$DEF_LIB"
OPTS="$OPTS --buildtype=debugoptimized"
OPTS="$OPTS -Dcheck_includes=true"
if [ "$MINI" = "true" ]; then
- OPTS="$OPTS -Denable_drivers=bus/vdev,mempool/ring,net/null"
+ OPTS="$OPTS -Denable_drivers=net/null"
OPTS="$OPTS -Ddisable_libs=*"
fi
meson build --werror $OPTS
diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh
index c07fd16fdc..a653b253cb 100755
--- a/devtools/test-meson-builds.sh
+++ b/devtools/test-meson-builds.sh
@@ -221,7 +221,7 @@ for c in gcc clang ; do
done
build build-mini cc skipABI $use_shared -Ddisable_libs=* \
- -Denable_drivers=bus/vdev,mempool/ring,net/null
+ -Denable_drivers=net/null
# test compilation with minimal x86 instruction set
# Set the install path for libraries to "lib" explicitly to prevent problems
--
2.34.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] ci: remove redundant drivers enabling
2022-03-01 10:04 ` [PATCH v2] " Thomas Monjalon
@ 2022-03-01 10:57 ` David Marchand
2022-03-06 9:27 ` Thomas Monjalon
0 siblings, 1 reply; 7+ messages in thread
From: David Marchand @ 2022-03-01 10:57 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, Bruce Richardson, Aaron Conole, Michael Santana
On Tue, Mar 1, 2022 at 11:05 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> No need to explicitly enable drivers bus/vdev and mempool/ring.
>
> bus/vdev is always enabled since
> commit 2e33309ebe03 ("config: enable/disable drivers in Arm builds")
>
> mempool/ring is always enabled since
> commit 81c2337e044d ("build: make ring mempool driver mandatory")
>
> The driver net/null is kept to allow running test-null.sh.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] ci: remove redundant drivers enabling
2022-03-01 10:57 ` David Marchand
@ 2022-03-06 9:27 ` Thomas Monjalon
0 siblings, 0 replies; 7+ messages in thread
From: Thomas Monjalon @ 2022-03-06 9:27 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson, Aaron Conole, Michael Santana, David Marchand
01/03/2022 11:57, David Marchand:
> On Tue, Mar 1, 2022 at 11:05 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > No need to explicitly enable drivers bus/vdev and mempool/ring.
> >
> > bus/vdev is always enabled since
> > commit 2e33309ebe03 ("config: enable/disable drivers in Arm builds")
> >
> > mempool/ring is always enabled since
> > commit 81c2337e044d ("build: make ring mempool driver mandatory")
> >
> > The driver net/null is kept to allow running test-null.sh.
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: David Marchand <david.marchand@redhat.com>
Applied
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-03-06 9:27 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-26 18:36 [PATCH] ci: remove redundant drivers enabling Thomas Monjalon
2022-02-28 9:46 ` Bruce Richardson
2022-02-28 10:17 ` David Marchand
2022-02-28 10:19 ` Bruce Richardson
2022-03-01 10:04 ` [PATCH v2] " Thomas Monjalon
2022-03-01 10:57 ` David Marchand
2022-03-06 9:27 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).