From: Harold Huang <baymaxhuang@gmail.com>
To: dev@dpdk.org
Cc: ophirmu@mellanox.com, Harold Huang <baymaxhuang@gmail.com>,
stable@dpdk.org, Keith Wiles <keith.wiles@intel.com>,
Raslan Darawsheh <rasland@mellanox.com>
Subject: [PATCH] net/tap: do not include l2 header in gso size when compared with mtu
Date: Mon, 28 Feb 2022 16:27:23 +0800 [thread overview]
Message-ID: <20220228082724.1646930-1-baymaxhuang@gmail.com> (raw)
The gso size is calculated with all of the headers and payload. As a
result, the l2 header should not be included when comparing gso size
with mtu.
Fixes: 050316a88313 ("net/tap: support TSO (TCP Segment Offload)")
Cc: stable@dpdk.org
Signed-off-by: Harold Huang <baymaxhuang@gmail.com>
---
drivers/net/tap/rte_eth_tap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index f1b48cae82..2b561d232c 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -731,7 +731,7 @@ pmd_tx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
mbuf_in->l4_len;
tso_segsz = mbuf_in->tso_segsz + hdrs_len;
if (unlikely(tso_segsz == hdrs_len) ||
- tso_segsz > *txq->mtu) {
+ tso_segsz > *txq->mtu + mbuf_in->l2_len) {
txq->stats.errs++;
break;
}
--
2.27.0
next reply other threads:[~2022-02-28 8:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 8:27 Harold Huang [this message]
2022-03-04 16:30 ` Ferruh Yigit
2022-03-08 14:35 ` Harold Huang
2022-05-20 22:08 ` Ferruh Yigit
2022-05-24 14:01 ` Ophir Munk
2023-10-17 16:47 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220228082724.1646930-1-baymaxhuang@gmail.com \
--to=baymaxhuang@gmail.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=ophirmu@mellanox.com \
--cc=rasland@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).