From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A5E3A034F; Tue, 1 Mar 2022 10:57:07 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CA7FE40DF6; Tue, 1 Mar 2022 10:57:06 +0100 (CET) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id 53B2A407FF for ; Tue, 1 Mar 2022 10:57:05 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id D2C333200E90; Tue, 1 Mar 2022 04:57:03 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 01 Mar 2022 04:57:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; bh=Xxi/7s1rbh3oaV8vZ55+fAgzXA9pQP c890BhD7RQHf8=; b=L5O+SOpxx8oB8ajjR4dsTkMjwPbCHr/ZDJH6REOADjQx5P PRCG4O2iUNkDSMTLyPWoqdPcH9x1x2VYOIp0Z3toq/5bLorgi4EJcdSm50G2gT8x AFOSFQIyl91bFFjG/oTGivv9yKyToNMXhsEwegA04n0uZ1NOjDyZTrOfOLsjbGV0 UOKQyXYR8BuMO6krJG4xMEBIcMKjXW3V1pWEoGxympefMpBRHtNXBoHLSEdf8oR1 vNinaI7RX+nww1x/FDrmCEU6HxfVn/SHCYZW6edzN53laXrfGCh3gAXFsrmIaG17 vwvkGBUi2FJnHBSFrX6XY5LekFyBlII10Lv6qWsA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Xxi/7s 1rbh3oaV8vZ55+fAgzXA9pQPc890BhD7RQHf8=; b=NHtZ9UXrubsAtz5esLKsbu ogAAPOfzUIM94JCNnZ3HY0OyN8/G0OWrkd2h1nJLpqaej31M7CVfE2GcRKiFRcbP 6KRlOCLan4EHBKbu25Mi/bnebH5TfPyOBsvDbxGwlpu4ATrril3r5jJRhgtJeZFW 6MKmXJabseO0YkMOwRBES+52oFfyWIib6jHaKHSUDnb2Ngix6SJQmRhInv5Ak9wN cfFTDb27tERY7Wa7SnvcM4B176zsD+gbLbNGREK6fCRmUMe/Oq4PIm7kGqPiIx5Z tcgntaGT18+ouen7Kfs8ttQDPBEMGHF7fnNMO5FgvotiMmW6iTJ9AJ/1UOKedmeg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddruddtvddgtdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepheffvdevteevtefhtedutefgudefgeegjeehffelkeeffedukeej ieevkeejhfdunecuffhomhgrihhnpehshhgsrdgtihdplhhinhhugidqsghuihhlugdrsh hhpdguphgukhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgr ihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 1 Mar 2022 04:57:02 -0500 (EST) From: Thomas Monjalon To: dev@dpdk.org Cc: david.marchand@redhat.com, Aaron Conole , Michael Santana Subject: [PATCH v2] ci: remove outdated default versions for ABI check Date: Tue, 1 Mar 2022 10:56:45 +0100 Message-Id: <20220301095645.2046124-1-thomas@monjalon.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220208134715.796609-1-thomas@monjalon.net> References: <20220208134715.796609-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The variables REF_GIT_TAG and LIBABIGAIL_VERSION are set in the CI configuration like .travis.yml or .github/workflows/build.yml. The default values are outdated and probably unused. The default values are removed completely to avoid forgetting an update in future. The use of the variables is quoted to make sure a missing value will trigger an appropriate failure. Signed-off-by: Thomas Monjalon Acked-by: Aaron Conole --- .ci/linux-build.sh | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh index 67d68535e0..05aa21ec69 100755 --- a/.ci/linux-build.sh +++ b/.ci/linux-build.sh @@ -104,8 +104,6 @@ if [ "$AARCH64" != "true" ] && [ "$PPC64LE" != "true" ]; then fi if [ "$ABI_CHECKS" = "true" ]; then - LIBABIGAIL_VERSION=${LIBABIGAIL_VERSION:-libabigail-1.6} - if [ "$(cat libabigail/VERSION 2>/dev/null)" != "$LIBABIGAIL_VERSION" ]; then rm -rf libabigail # if we change libabigail, invalidate existing abi cache @@ -113,14 +111,13 @@ if [ "$ABI_CHECKS" = "true" ]; then fi if [ ! -d libabigail ]; then - install_libabigail $LIBABIGAIL_VERSION $(pwd)/libabigail + install_libabigail "$LIBABIGAIL_VERSION" $(pwd)/libabigail echo $LIBABIGAIL_VERSION > libabigail/VERSION fi export PATH=$(pwd)/libabigail/bin:$PATH REF_GIT_REPO=${REF_GIT_REPO:-https://dpdk.org/git/dpdk} - REF_GIT_TAG=${REF_GIT_TAG:-v19.11} if [ "$(cat reference/VERSION 2>/dev/null)" != "$REF_GIT_TAG" ]; then rm -rf reference @@ -128,7 +125,7 @@ if [ "$ABI_CHECKS" = "true" ]; then if [ ! -d reference ]; then refsrcdir=$(readlink -f $(pwd)/../dpdk-$REF_GIT_TAG) - git clone --single-branch -b $REF_GIT_TAG $REF_GIT_REPO $refsrcdir + git clone --single-branch -b "$REF_GIT_TAG" $REF_GIT_REPO $refsrcdir meson $OPTS -Dexamples= $refsrcdir $refsrcdir/build ninja -C $refsrcdir/build DESTDIR=$(pwd)/reference ninja -C $refsrcdir/build install -- 2.34.1