From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 51D5FA00C2; Sun, 6 Mar 2022 10:20:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F14384115A; Sun, 6 Mar 2022 10:20:35 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id A67CD41158; Sun, 6 Mar 2022 10:20:34 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 5968C5C023B; Sun, 6 Mar 2022 04:20:34 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sun, 06 Mar 2022 04:20:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; bh=2vBlsIbyN9TKWKs6acS3L04bwlpUPt tDqLSNsdLd3k8=; b=rqI903zeKP9OtOA59SYqWcQZ7y0deWRUYAOhm7g1gaOqDc 4Em0v6ME5bFJUFXl02u/+CPlR5PdO87cJl8a6LBEuMQwSEkvcu4jojuAj3tMrJZS ciq3Ydma69GqrIjvqqrAjjsNXSSC5GG4TFgq83EXxucglWcqo1QFmZqlcdphJFvZ /yyqwADgqdgP/6eUk3oGprXzTh0iBal2L//G3ykvgS7jjZMbB1SkHw1kBgpwSve7 zwITpAhl2QT61vM45ebwLfzW98Fzyn4wCDs+uVRhF6TCbiqih8VVT2sqcYCLk9Yg l5cdd7qOKwYyhmqrX06080mA3/Z0vlSQ+OTFtRsw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=2vBlsI byN9TKWKs6acS3L04bwlpUPttDqLSNsdLd3k8=; b=Q1x1u/oOyYPBeVKaYvhbe3 tsX/Ddwx/9XUibSnRO+K77emofq/B3oyJQ5EO0bLBwgZp11nYTLA+LI9+udcuLNd mmBZC8DLQgH4jBep1OrrCKjiU/GEIuly323TsamJqsqAgh29btZ/T/qVSP4+fpUW E8rhsAz1fv1RKjhagSXZMtB9iOlXJWhqhCwKutqQXqyB3SXQ9oyn8Z3gmGJm1H+q 9n82jihBMW9WZ/XtsKsg1ttaIXpfnK7wBecBe8xaghElRJ4mMn58quqLe8LXuYrV PJSdzjc/5JuCUB7cNPj1ZtpfQ8why/PjsmePir0eH1V2pGlgskyGZ0zvynIJQveg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudduvddgtdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepvdehgfeivdejgedtveehfefhteelfefgieevgfffveefjeegtdfg uedthedtgeevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 6 Mar 2022 04:20:32 -0500 (EST) From: Thomas Monjalon To: dev@dpdk.org Cc: stable@dpdk.org, Ray Kinsella , Parav Pandit , Xueming Li , Elena Agostini , Ori Kam , Andrew Rybchenko Subject: [PATCH 2/2] build: hide local symbols in shared libraries Date: Sun, 6 Mar 2022 10:20:23 +0100 Message-Id: <20220306092023.2461466-3-thomas@monjalon.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220306092023.2461466-1-thomas@monjalon.net> References: <20220306092023.2461466-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The symbols which are not listed in the version script are exported by default. Adding a local section with a wildcard make non-listed functions and variables as hidden, as it should be in all version.map files. These are the changes done in the shared libraries: - DF .text Base auxiliary_add_device - DF .text Base auxiliary_dev_exists - DF .text Base auxiliary_dev_iterate - DF .text Base auxiliary_insert_device - DF .text Base auxiliary_is_ignored_device - DF .text Base auxiliary_match - DF .text Base auxiliary_on_scan - DF .text Base auxiliary_scan - DO .bss Base auxiliary_bus_logtype - DO .data Base auxiliary_bus - DO .bss Base gpu_logtype There is no impact on regexdev library. Because these local symbols were exported as non-internal in DPDK 21.11, any change in these functions would break the ABI. Exception rules are added for these experimental libraries, so the ABI check will skip them until the next ABI version. Fixes: 1afce3086cf4 ("bus/auxiliary: introduce auxiliary bus") Fixes: 8b8036a66e3d ("gpudev: introduce GPU device class library") Cc: stable@dpdk.org Signed-off-by: Thomas Monjalon --- devtools/libabigail.abignore | 8 ++++++++ drivers/bus/auxiliary/version.map | 2 ++ lib/gpudev/version.map | 2 ++ lib/regexdev/version.map | 2 ++ 4 files changed, 14 insertions(+) diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore index cff7a293ae..d698d8199d 100644 --- a/devtools/libabigail.abignore +++ b/devtools/libabigail.abignore @@ -28,3 +28,11 @@ ; Ignore changes in common mlx5 driver, should be all internal [suppress_file] soname_regexp = ^librte_common_mlx5\. + +; Ignore visibility fix of local functions in experimental auxiliary driver +[suppress_file] + soname_regexp = ^librte_bus_auxiliary\. + +; Ignore visibility fix of local functions in experimental gpudev library +[suppress_file] + soname_regexp = ^librte_gpudev\. diff --git a/drivers/bus/auxiliary/version.map b/drivers/bus/auxiliary/version.map index a52260657c..dc993e84ff 100644 --- a/drivers/bus/auxiliary/version.map +++ b/drivers/bus/auxiliary/version.map @@ -4,4 +4,6 @@ EXPERIMENTAL { # added in 21.08 rte_auxiliary_register; rte_auxiliary_unregister; + + local: *; }; diff --git a/lib/gpudev/version.map b/lib/gpudev/version.map index b23e3fd6eb..a2c8ce5759 100644 --- a/lib/gpudev/version.map +++ b/lib/gpudev/version.map @@ -39,4 +39,6 @@ INTERNAL { rte_gpu_get_by_name; rte_gpu_notify; rte_gpu_release; + + local: *; }; diff --git a/lib/regexdev/version.map b/lib/regexdev/version.map index 988b909638..3c6e9fffa1 100644 --- a/lib/regexdev/version.map +++ b/lib/regexdev/version.map @@ -26,6 +26,8 @@ EXPERIMENTAL { rte_regexdev_xstats_get; rte_regexdev_xstats_names_get; rte_regexdev_xstats_reset; + + local: *; }; INTERNAL { -- 2.34.1