DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] net/mlx5: fix the port match in sample flow
@ 2022-03-07  2:10 Jiawei Wang
  2022-03-09 19:43 ` Slava Ovsiienko
  2022-03-10 15:37 ` Raslan Darawsheh
  0 siblings, 2 replies; 3+ messages in thread
From: Jiawei Wang @ 2022-03-07  2:10 UTC (permalink / raw)
  To: viacheslavo, matan, orika; +Cc: dev, rasland, stable

If there are an explicit port match and sample action in the same flow,
mlx5 PMD pushes the explicit port match in the prefix subflow, and
uses the tag item match in the suffix subflow.

The explicit port match was translated into source vport match so
the sample suffix subflow lost this match after flow split.

This patch copies the explicit port match to the sample suffix subflow,
and the latter gets the correct source vport value in the flow matcher.

Fixes: b4c0ddbfcc58 ("net/mlx5: split sample flow into two sub-flows")
Cc: stable@dpdk.org

Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com>
---
 drivers/net/mlx5/mlx5_flow.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 179cc3b303..34b8f97a14 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -5543,7 +5543,7 @@ flow_check_match_action(const struct rte_flow_action actions[],
 	return flag ? actions_n + 1 : 0;
 }
 
-#define SAMPLE_SUFFIX_ITEM 2
+#define SAMPLE_SUFFIX_ITEM 3
 
 /**
  * Split the sample flow.
@@ -5584,6 +5584,7 @@ flow_check_match_action(const struct rte_flow_action actions[],
 static int
 flow_sample_split_prep(struct rte_eth_dev *dev,
 		       int add_tag,
+		       const struct rte_flow_item items[],
 		       struct rte_flow_item sfx_items[],
 		       const struct rte_flow_action actions[],
 		       struct rte_flow_action actions_sfx[],
@@ -5650,6 +5651,12 @@ flow_sample_split_prep(struct rte_eth_dev *dev,
 			.data = tag_id,
 		};
 		/* Prepare the suffix subflow items. */
+		for (; items->type != RTE_FLOW_ITEM_TYPE_END; items++) {
+			if (items->type == RTE_FLOW_ITEM_TYPE_PORT_ID) {
+				memcpy(sfx_items, items, sizeof(*sfx_items));
+				sfx_items++;
+			}
+		}
 		tag_spec = (void *)(sfx_items + SAMPLE_SUFFIX_ITEM);
 		tag_spec->data = tag_id;
 		tag_spec->id = set_tag->id;
@@ -6257,7 +6264,7 @@ flow_create_split_sample(struct rte_eth_dev *dev,
 			jump_table = attr->group * MLX5_FLOW_TABLE_FACTOR +
 				     next_ft_step;
 		pre_actions = sfx_actions + actions_n;
-		tag_id = flow_sample_split_prep(dev, add_tag, sfx_items,
+		tag_id = flow_sample_split_prep(dev, add_tag, items, sfx_items,
 						actions, sfx_actions,
 						pre_actions, actions_n,
 						sample_action_pos,
-- 
2.18.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] net/mlx5: fix the port match in sample flow
  2022-03-07  2:10 [PATCH] net/mlx5: fix the port match in sample flow Jiawei Wang
@ 2022-03-09 19:43 ` Slava Ovsiienko
  2022-03-10 15:37 ` Raslan Darawsheh
  1 sibling, 0 replies; 3+ messages in thread
From: Slava Ovsiienko @ 2022-03-09 19:43 UTC (permalink / raw)
  To: Jiawei(Jonny) Wang, Matan Azrad, Ori Kam; +Cc: dev, Raslan Darawsheh, stable

> -----Original Message-----
> From: Jiawei(Jonny) Wang <jiaweiw@nvidia.com>
> Sent: Monday, March 7, 2022 4:11
> To: Slava Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; Ori Kam <orika@nvidia.com>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>;
> stable@dpdk.org
> Subject: [PATCH] net/mlx5: fix the port match in sample flow
> 
> If there are an explicit port match and sample action in the same flow,
> mlx5 PMD pushes the explicit port match in the prefix subflow, and uses the
> tag item match in the suffix subflow.
> 
> The explicit port match was translated into source vport match so the sample
> suffix subflow lost this match after flow split.
> 
> This patch copies the explicit port match to the sample suffix subflow, and
> the latter gets the correct source vport value in the flow matcher.
> 
> Fixes: b4c0ddbfcc58 ("net/mlx5: split sample flow into two sub-flows")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] net/mlx5: fix the port match in sample flow
  2022-03-07  2:10 [PATCH] net/mlx5: fix the port match in sample flow Jiawei Wang
  2022-03-09 19:43 ` Slava Ovsiienko
@ 2022-03-10 15:37 ` Raslan Darawsheh
  1 sibling, 0 replies; 3+ messages in thread
From: Raslan Darawsheh @ 2022-03-10 15:37 UTC (permalink / raw)
  To: Jiawei(Jonny) Wang, Slava Ovsiienko, Matan Azrad, Ori Kam; +Cc: dev, stable

Hi,

> -----Original Message-----
> From: Jiawei(Jonny) Wang <jiaweiw@nvidia.com>
> Sent: Monday, March 7, 2022 4:11 AM
> To: Slava Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; Ori Kam <orika@nvidia.com>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>;
> stable@dpdk.org
> Subject: [PATCH] net/mlx5: fix the port match in sample flow
> 
> If there are an explicit port match and sample action in the same flow,
> mlx5 PMD pushes the explicit port match in the prefix subflow, and uses the
> tag item match in the suffix subflow.
> 
> The explicit port match was translated into source vport match so the sample
> suffix subflow lost this match after flow split.
> 
> This patch copies the explicit port match to the sample suffix subflow, and
> the latter gets the correct source vport value in the flow matcher.
> 
> Fixes: b4c0ddbfcc58 ("net/mlx5: split sample flow into two sub-flows")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com>

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-03-10 15:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-07  2:10 [PATCH] net/mlx5: fix the port match in sample flow Jiawei Wang
2022-03-09 19:43 ` Slava Ovsiienko
2022-03-10 15:37 ` Raslan Darawsheh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).