From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6CF0DA0093; Mon, 7 Mar 2022 13:54:19 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F156D411DB; Mon, 7 Mar 2022 13:54:12 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2060.outbound.protection.outlook.com [40.107.237.60]) by mails.dpdk.org (Postfix) with ESMTP id 21DDA4014E for ; Mon, 7 Mar 2022 13:54:11 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CE9N+Jy1Luns5ZeNQNa5fedh2wWo7QixCXSJsMViCDEbZzkrc7+hRlIeepNgOvYoiPuex2XCkhqm/OPEM+LybrHXP5NSc+ky3IalgPkCLv/vfDD5/BRWw7LoiKCe69nRzoSTiEEP/JcBp7Gw62dqI3oYTN3OJmKHnNO/6bLXK8+f7dgPhUAbHA7uu9QQGeW1cC3N6+nB0yhkIZ7afgH9IuilbEogePMylEV4ohEW0NRzeJsjg+eHflVtyGlB9EIfQYHWcshxkyihu78kip2AyW/ulMp1vlzXCmAUvk8NKrZBcKPFuYVC9dtstEfJSg7eKgz7jIWyMguNTfHM/dA4gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4fuoekaZ4nUQwSt5V9+z4jeuCNmdLIRr9Fv8Jlx08xA=; b=OvSI46d9LzKj7Pr+Zgft2idlhDzKJEB7nVf8gdBd/WX42ZCnR75Y4TomcSHQ9Hqu1xQI8ZLlVJRp3UqwT145Ytlw/M807GbojklGdeeTzf3AlkmxldC55oHwtf+xYlFoP5rQbN/P2T5k/YIVeSOHAaVmQvryfPjnpQR5cpSySE1uUX68/qqmiAUckrIHBwHOa/JfTXME7ENq2MimAZXNNTjko5Hnc9X+2JDVIFkGI38XycFi33A+9ZY+tqYI+e/fGSLZrR6n0y5ArGHrX5Ty0V8iyBtAWyEhjb36ZKdNsb+/gh7F9VPxhHAkur1qVL94oIh+BRDZAWRqer6yUDdIxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.235) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4fuoekaZ4nUQwSt5V9+z4jeuCNmdLIRr9Fv8Jlx08xA=; b=I4+EBl7Fu8et/69EVSprDyM8S7IfhUMp5pXWjFrl4RbpvRcUaAWCEgAOUbxfVrcqByImloO5+8uwxIGQJVU3v6de7jjS4RmIp1IX3pC+Rv1fBKZebD9iSYQ5ywigMECuBXMvsNhdhyMf4F4p8sHsdo++tTTUYsaMeE5HG26mHE1zNxcnemwv4WMvXbpffLOccZG4mLeBZQ8rNuZgyZ9d6swnW6ZiEqQsvM3Ph1l0y4iDWyf+4ld2Qx/SH7Oe1hjOiW5YHle5BF1xrRJbdESI/SwnQBVFLuPMm3pxT8u4iIvjLHWdRtPR9zo6ytLD3FB7jKcGksfDGB8JohoA2olxsQ== Received: from BN6PR17CA0023.namprd17.prod.outlook.com (2603:10b6:404:65::33) by CY4PR12MB1142.namprd12.prod.outlook.com (2603:10b6:903:40::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.20; Mon, 7 Mar 2022 12:54:06 +0000 Received: from BN8NAM11FT055.eop-nam11.prod.protection.outlook.com (2603:10b6:404:65:cafe::e2) by BN6PR17CA0023.outlook.office365.com (2603:10b6:404:65::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14 via Frontend Transport; Mon, 7 Mar 2022 12:54:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.235) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.235 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.235; helo=mail.nvidia.com; Received: from mail.nvidia.com (12.22.5.235) by BN8NAM11FT055.mail.protection.outlook.com (10.13.177.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5038.14 via Frontend Transport; Mon, 7 Mar 2022 12:54:05 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 7 Mar 2022 12:54:03 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.9; Mon, 7 Mar 2022 04:54:02 -0800 Received: from nvidia.com (10.127.8.11) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server id 15.2.986.9 via Frontend Transport; Mon, 7 Mar 2022 04:54:01 -0800 From: Dmitry Kozlyuk To: Subject: [PATCH v3 0/2] app/testpmd: skip stopped queues when forwarding Date: Mon, 7 Mar 2022 14:53:49 +0200 Message-ID: <20220307125351.697936-1-dkozlyuk@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220306232310.613552-1-dkozlyuk@nvidia.com> References: <20220306232310.613552-1-dkozlyuk@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bc0a4f4a-ea44-4d75-72f1-08da0039901a X-MS-TrafficTypeDiagnostic: CY4PR12MB1142:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Xz8tOoTrHRYtnzE6susHqtaIwfZrOKbrsS/6S8z2WeVz+rb5WPjI8lRcvXqRYDuPAin7wZhJvmstUU03ElTCOJ34VbkebebeyICnbOF6PvI+jnsO2fJPkYIHUOE2CWp+7/hjMif7LtX2f447bLeu2oQHW5xGbCpspRvnL9OW+HBhMks+6q1bwFSrr0vy6vipuFDSW4a7+z4DhgyQyavmIet8DoLRni2a/suoqf0FtFGqAmBSz6t7oH8AjUrGmqgvSqGsCmaCIQN4WR96Gdkw5CfgGTP6+DcLmwT+OAYf9EfgHz5uf5I875k1ffFVP9ewOlRmkaGVAYotfNXFoWl36jQWDwyl1Hpv9mQijFbxNEpMUDNO7ajNkqkHfRXIVdpYubp27cCBLnSruOJdNHzIHOtf9JOx6JHjqTLL+4nxXG8bCLnPjNTaD/HLbmWIfDcvdfp2Bd/mM0DfW7iTNep1zmUsKeYrqXSmbCNCCt2CYEVdI+FA31IGUPNVF79XtQCcR/bFgQlg4a+slhIiMnAl59mf/Y48craBuHLgHCOYLiYhkS5R45L5bS3YEEpV5UoqZBQrd9bvytJUZUcORokwQVMlnr2DUS8WHw5B3QgSQ0i4MmXi1gljAx5+yzCRLWY22fHkMIu6n6mSebecuNOEA58+Sw53PGh5z0hO1sTRDR5foVzqwSav1z9NPC/Rzzj4oycO52SyK/q+3R2Doek3CA5NwoanWulCG0prjqCD0HdpMUe4xCPuUqwu6Vxopwqxkkxu444XHuetXqGhHyxjighdzC0gD47XnVcukeV71XE= X-Forefront-Antispam-Report: CIP:12.22.5.235; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(2906002)(26005)(5660300002)(2616005)(82310400004)(336012)(426003)(40460700003)(186003)(1076003)(83380400001)(86362001)(356005)(36756003)(81166007)(508600001)(55016003)(6916009)(36860700001)(966005)(6286002)(316002)(8936002)(70206006)(70586007)(8676002)(47076005)(45080400002)(7696005)(6666004)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2022 12:54:05.5416 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bc0a4f4a-ea44-4d75-72f1-08da0039901a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.235]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT055.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1142 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org It was unspecified what happens of a stopped queue is polled. Declare that polling is prohibited and modify testpmd to follow this. Rationale is described in the commit log; it follows the discussion: http://inbox.dpdk.org/dev/BL1PR12MB594551A71273709E1C04A8BAB9309@BL1PR12MB5945.namprd12.prod.outlook.com/ v3: * Revert to storing queue status in testpmd to handle PMDs that don't implement rte_eth_rx/tx_queue_info_get() (Daxue Gao). * Add missed "macswap" support. v2: * Do not try to change forwarding mode partially, disable individual flows that need stopped queues instead. * Do not store queue status in testpmd, query it as needed instead. Dmitry Kozlyuk (2): app/testpmd: do not poll stopped queues ethdev: prohibit polling of a stopped queue app/test-pmd/5tswap.c | 13 +++++ app/test-pmd/cmdline.c | 45 +++++++++------- app/test-pmd/config.c | 8 +-- app/test-pmd/csumonly.c | 13 +++++ app/test-pmd/flowgen.c | 13 +++++ app/test-pmd/icmpecho.c | 13 +++++ app/test-pmd/ieee1588fwd.c | 13 +++++ app/test-pmd/iofwd.c | 13 +++++ app/test-pmd/macfwd.c | 13 +++++ app/test-pmd/macswap.c | 13 +++++ app/test-pmd/noisy_vnf.c | 13 +++++ app/test-pmd/rxonly.c | 8 +++ app/test-pmd/shared_rxq_fwd.c | 8 +++ app/test-pmd/testpmd.c | 96 +++++++++++++++++++++++------------ app/test-pmd/testpmd.h | 19 ++++++- app/test-pmd/txonly.c | 8 +++ lib/ethdev/rte_ethdev.h | 2 +- 17 files changed, 254 insertions(+), 57 deletions(-) -- 2.25.1