DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] examples/distributor: one Tx queue is enough
@ 2022-03-07 22:39 Honnappa Nagarahalli
  2022-03-08  3:26 ` Honnappa Nagarahalli
  2022-03-08 10:00 ` Bruce Richardson
  0 siblings, 2 replies; 5+ messages in thread
From: Honnappa Nagarahalli @ 2022-03-07 22:39 UTC (permalink / raw)
  To: dev, honnappa.nagarahalli, lijuan.tu, juraj.linkes, ohilyard,
	david.marchand, thomas, david.hunt
  Cc: ruifeng.wang, nd, bruce.richardson, reshma.pattan, stable

Distributor application creates one Tx queue per core. However
the transmit is done only from a single core. Hence creating
one Tx queue is enough.

Fixes: 07db4a975094 ("examples/distributor: new sample app")
Cc: bruce.richardson@intel.com
Cc: reshma.pattan@intel.com
Cc: stable@dpdk.org

Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
DTS test cases make this change to DPDK. However, I find that, one
queue is enough. Hence we could make this change in DPDK.

 examples/distributor/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/distributor/main.c b/examples/distributor/main.c
index c681e237ea..02bf91f555 100644
--- a/examples/distributor/main.c
+++ b/examples/distributor/main.c
@@ -108,7 +108,7 @@ static inline int
 port_init(uint16_t port, struct rte_mempool *mbuf_pool)
 {
 	struct rte_eth_conf port_conf = port_conf_default;
-	const uint16_t rxRings = 1, txRings = rte_lcore_count() - 1;
+	const uint16_t rxRings = 1, txRings = 1;
 	int retval;
 	uint16_t q;
 	uint16_t nb_rxd = RX_RING_SIZE;
-- 
2.25.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-03-08 14:55 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-07 22:39 [PATCH] examples/distributor: one Tx queue is enough Honnappa Nagarahalli
2022-03-08  3:26 ` Honnappa Nagarahalli
2022-03-08 10:00 ` Bruce Richardson
2022-03-08 11:40   ` Thomas Monjalon
2022-03-08 14:55   ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).