From: Stephen Hemminger <stephen@networkplumber.org>
To: "Koikkara Reeny, Shibin" <shibin.koikkara.reeny@intel.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
"Hunt, David" <david.hunt@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [PATCH] examples/vm_power: replace list foreach with while loop
Date: Thu, 10 Mar 2022 09:21:24 -0800 [thread overview]
Message-ID: <20220310092124.4908ec07@hermes.local> (raw)
In-Reply-To: <DM6PR11MB39955B45A581449B28FBC28DA20B9@DM6PR11MB3995.namprd11.prod.outlook.com>
On Thu, 10 Mar 2022 09:32:08 +0000
"Koikkara Reeny, Shibin" <shibin.koikkara.reeny@intel.com> wrote:
> > -----Original Message-----
> > From: Thomas Monjalon <thomas@monjalon.net>
> > 01/03/2022 15:53, Shibin Koikkara Reeny:
> > > Linux header files don't support LIST_FOREACH_SAFE so replacing
> > > LIST_FOREACH with while loop.
> >
> > What is the original issue you are trying to solve?
> Asan tool reported LIST_FOREACH should be replaced with LIST_FOREACH_SAFE but
> Linux don't have LIST_FOREACH_SAFE API. So replacing it with while loop.
>
> Regards,
> Shibin
Why not just clone LIST_FOREACH_SAFE from BSD?
That is what RTE_TAILQ does.
It might be generally useful.
next prev parent reply other threads:[~2022-03-10 17:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 14:53 Shibin Koikkara Reeny
2022-03-08 13:26 ` Thomas Monjalon
2022-03-10 9:32 ` Koikkara Reeny, Shibin
2022-03-10 9:39 ` Thomas Monjalon
2022-03-10 17:21 ` Stephen Hemminger [this message]
2022-03-21 9:33 ` [PATCH v2] examples/vm_power: add support for list_foreach_safe Shibin Koikkara Reeny
2022-03-21 16:16 ` Stephen Hemminger
2022-03-22 14:43 ` [PATCH v3] " Shibin Koikkara Reeny
2022-03-25 14:02 ` David Hunt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220310092124.4908ec07@hermes.local \
--to=stephen@networkplumber.org \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=shibin.koikkara.reeny@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).