From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17C69A0093; Fri, 18 Mar 2022 00:13:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9589940DF7; Fri, 18 Mar 2022 00:13:30 +0100 (CET) Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by mails.dpdk.org (Postfix) with ESMTP id C9E9740143 for ; Fri, 18 Mar 2022 00:13:29 +0100 (CET) Received: by mail-pj1-f54.google.com with SMTP id o6-20020a17090a9f8600b001c6562049d9so6866606pjp.3 for ; Thu, 17 Mar 2022 16:13:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=g9C9UzfquRCKGpyeRd4l+8PWI4vP4kkBWUHKrefLTEQ=; b=FRFugiSTgqU6fOrv7Gm6Q0DSSHP7hvCh2mVXIhCUBRcJJkqDw40EgW9/eRP5X8tNCt tD7Rylh+74OaAYPu5SKJ2qs5s32KZXkTPMdBxs4l5T1OoLwRbQaAsSzW4zFIRP0pU+7l 2q28RZ23lFZyV81uhuh/WFHopz+c8/Xk4hSLM0D7CmkFpVIFpSZvaF6RzgxhhE9bFnhY UDGxH9r9fDAn1JGB7GScLLlur5NpdhSU9Gd6etUxaAYsVUnx40uB7Gcf93nG/2rZRX/b GDF6Q2y5U2qvK/8L3pMaoIYqYWDegS+RbCU0+FQXJzRBXA7WvxoBulU3jqIo0/Wu8Zun hsRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=g9C9UzfquRCKGpyeRd4l+8PWI4vP4kkBWUHKrefLTEQ=; b=ZpXxqQprK8wZc2f2TsA+KhjwU9EGQhIyw/+McF2GvrnxPwm9mlla9n40em3yy8Rf5w OXTLIftq5T4EpuHOzH3STS1U3rS0vkIhnGg4ZBVzsgyXc6xohrKlXx7H1nFejSHvbj4i X3xW7AplmS7X9ZTCdkHCyKkTrI3J6IvBCUfig67tLtrVT1TF567HtDXRlkisvvoTgna3 xe/UD/+gUUXXaFqi992I+b9QAD7lE23szYaazGG8QweU3AWdAuAZdAo5FN2RgTvOTcKR LQUaRbZYUsEKBAc5mGt6+TwzO+dwkRf3BrUgRtJHBy+zGJ7A8nKykVqwNUjg6qrrzi2g ek1Q== X-Gm-Message-State: AOAM531Y+tJwiTUXK+TA6rSVlZAOluzL0ct2ACD105uBhbDoupWUWmZN z4hRy3k0I3vznN7JM9hcnsR+eJ/1LMcYYA== X-Google-Smtp-Source: ABdhPJyk6LKIkpVFaNUuDu3Pw30EPG7RD+kSU5VjyNJs209qoARwerGQk1uaXlDVo4Pv3HA7lhq0Sg== X-Received: by 2002:a17:902:7045:b0:153:a8b1:d666 with SMTP id h5-20020a170902704500b00153a8b1d666mr7493069plt.75.1647558808735; Thu, 17 Mar 2022 16:13:28 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id z16-20020a056a00241000b004f3a647ae89sm7936724pfh.174.2022.03.17.16.13.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Mar 2022 16:13:28 -0700 (PDT) Date: Thu, 17 Mar 2022 16:13:25 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: dev@dpdk.org, Morten =?UTF-8?B?QnLDuHJ1cA==?= Subject: Re: [PATCH v2 1/2] eal_debug: do not use malloc in rte_dump_stack Message-ID: <20220317161325.3c4cc14a@hermes.local> In-Reply-To: <9139565.2WqB4rESCP@thomas> References: <20220129011039.264377-1-stephen@networkplumber.org> <20220212184433.66791-1-stephen@networkplumber.org> <20220212184433.66791-2-stephen@networkplumber.org> <9139565.2WqB4rESCP@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, 13 Feb 2022 12:41:59 +0100 Thomas Monjalon wrote: > 12/02/2022 19:44, Stephen Hemminger: > > The glibc backtrace_symbols() calls malloc which makes it > > dangerous to use rte_dump_stack() in a signal handler that > > is handling errors that maybe due to memory corruption. > > > > Instead, use dladdr() to lookup up symbols incrementally. > > > > The format of the messages is based on what X org server > > has been doing for many years. It changes from bottom up > > to top down order. > > > > Signed-off-by: Stephen Hemminger > > Morten acked the RFC. > Is there any significant change? > > > The change was making it not RFC. Lets make a common code for this FreeBSD should have same code.