From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8DD69A04FF; Mon, 21 Mar 2022 17:15:44 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 252FB427E9; Mon, 21 Mar 2022 17:15:44 +0100 (CET) Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by mails.dpdk.org (Postfix) with ESMTP id A2D754161A for ; Mon, 21 Mar 2022 17:15:43 +0100 (CET) Received: by mail-pj1-f44.google.com with SMTP id l4-20020a17090a49c400b001c6840df4a3so11101309pjm.0 for ; Mon, 21 Mar 2022 09:15:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IfKaLHOVg4pp2yoS6AheaTJ0FqTmqNRJDnL54EslQKg=; b=o+8iIZG+gVcCViyrmQ+/wCJqmibkW3YU2j3d0K+AS/FdrwIclHadRgpFUdtTZFWHEy grNQJF0XfSAdEycCsjx/OfPJ0umdcKttSr8PwrIXH2uflhYpSVGsWRcTfbff38T1EuQo Wc7+5OGC8hDDei1unlnBUjEZRnwEF14PnSoPizt7MsiTE5y5mlBKoQXfNkH3xCcfuNq4 iXInSLQcuLXAPfMg27Z5BDKlB0tOqbUOUgV7F69hmWa1wXZ9jGFLz2n7j3wB9P8CZoGS RhDSqixlrZZwdds3noYPmVMRk1HyYbiZWalI3eGhy1URWD/e8qTy186DYhtwyo+vJ06V uFQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IfKaLHOVg4pp2yoS6AheaTJ0FqTmqNRJDnL54EslQKg=; b=Ia+OnGSoUq2wQ0WdvAvYfd7kSXnPbsQSHinFOki4h6XHrozB8ibslWtN234lFZK/Rs 68nOoYKxINi9zduDMMiLWIeTiAwoCGkzeozMr4YwKmYDDw2wyY5cjRINqfyRnlSk6G3B RxXnaOC6bfUDELlDTLoXO74vWZo4LHlHdOu1C1mbTgYqvk/fC+4T2YLamY0iqUPCT1I3 QQrTfEVq9xEzzZ30wvB+W3vO2/D6Z+Yk1e0190KniV3zrN7W3ZZhqDIyeuK4ct4BWYJw VAtTqRbeIGF+gQgroGDdbs4TdXFVMP7gOM4wvmZ5PlvTNKusk+EvEsr8yTeJo7VfnKl/ Xy9Q== X-Gm-Message-State: AOAM533Fjv/GQo616/NFTbhY3X69J+Ou/+n78OoOQazy3+rFQQZQbU30 hJ9gh2MYolpVibl7w3cVCRqbkA== X-Google-Smtp-Source: ABdhPJxWElFZVHWCq7DwJ/+wedp2mzXE+5CRV6JV+r2lsqDbaBCzrpBUpGzW/O0sUDJIJmFIjHxYxg== X-Received: by 2002:a17:902:6944:b0:153:9866:7fea with SMTP id k4-20020a170902694400b0015398667feamr13696430plt.6.1647879342593; Mon, 21 Mar 2022 09:15:42 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id t18-20020a17090ad51200b001c71bec7b22sm3573177pju.23.2022.03.21.09.15.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 09:15:42 -0700 (PDT) Date: Mon, 21 Mar 2022 09:15:39 -0700 From: Stephen Hemminger To: Tyler Retzlaff Cc: dev@dpdk.org, anatoly.burakov@intel.com, stable@dpdk.org Subject: Re: [PATCH] test/bpf: skip test if libpcap is unavailable Message-ID: <20220321091539.720338b9@hermes.local> In-Reply-To: <1647868407-4467-1-git-send-email-roretzla@linux.microsoft.com> References: <1647868407-4467-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 21 Mar 2022 06:13:27 -0700 Tyler Retzlaff wrote: > test_bpf_convert is being conditionally registered depending on the > presence of RTE_HAS_LIBPCAP except the UT unconditionally lists it as a > test to run. > > when the UT runs test_bpf_convert test-dpdk can't find the registration > and assumes the DPDK_TEST environment variable hasn't been defined > resulting in test-dpdk dropping to interactive mode and subsequently > waiting for the remainder of the UT fast-test timeout period before > reporting the test as having timed out. > > * unconditionally register test_bpf_convert > * if ! RTE_HAS_LIBPCAP provide a stub test_bpf_convert that reports the > test is skipped similar to that done with the test_bpf test. > > Fixes: 2eccf6afbea9 ("bpf: add function to convert classic BPF to DPDK BPF") > Cc: stephen@networkplumber.org > Cc: anatoly.burakov@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Tyler Retzlaff LGTM Acked-by: Stephen Hemminger