From: David Marchand <david.marchand@redhat.com> To: dev@dpdk.org Cc: stable@dpdk.org, Ori Kam <orika@nvidia.com>, Xiaoyun Li <xiaoyun.li@intel.com>, Aman Singh <aman.deep.singh@intel.com>, Yuying Zhang <yuying.zhang@intel.com>, Ferruh Yigit <ferruh.yigit@intel.com>, Wei Zhao <wei.zhao1@intel.com> Subject: [PATCH] app/testpmd: remove useless pointer checks Date: Thu, 24 Mar 2022 17:15:03 +0100 Message-ID: <20220324161503.13047-1-david.marchand@redhat.com> (raw) Parameters to this static helper can't be NULL. str has already been dereferenced in caller. dst and size point to variable in stack. Fixes: 169a9fed1f4c ("app/testpmd: fix hex string parser support for flow API") Cc: stable@dpdk.org Signed-off-by: David Marchand <david.marchand@redhat.com> --- app/test-pmd/cmdline_flow.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index fc4a6d9cca..e3269e278d 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -9338,11 +9338,7 @@ parse_hex_string(const char *src, uint8_t *dst, uint32_t *size) const uint8_t *head = dst; uint32_t left; - /* Check input parameters */ - if ((src == NULL) || - (dst == NULL) || - (size == NULL) || - (*size == 0)) + if (*size == 0) return -1; left = *size; -- 2.23.0
next reply other threads:[~2022-03-24 16:16 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-24 16:15 David Marchand [this message] 2022-03-29 9:26 ` Thomas Monjalon 2022-05-12 7:19 ` David Marchand 2022-05-20 15:04 ` Ferruh Yigit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220324161503.13047-1-david.marchand@redhat.com \ --to=david.marchand@redhat.com \ --cc=aman.deep.singh@intel.com \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=orika@nvidia.com \ --cc=stable@dpdk.org \ --cc=wei.zhao1@intel.com \ --cc=xiaoyun.li@intel.com \ --cc=yuying.zhang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git