DPDK patches and discussions
 help / color / mirror / Atom feed
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: "Varghese, Vipin" <Vipin.Varghese@amd.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
	"david.marchand@redhat.com" <david.marchand@redhat.com>,
	"Tummala, Sivaprasad" <Sivaprasad.Tummala@amd.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH] meson: update doc logic for Windows
Date: Mon, 28 Mar 2022 12:34:38 +0300	[thread overview]
Message-ID: <20220328123438.0f8bb44e@sovereign> (raw)
In-Reply-To: <MN2PR12MB3085A3D0DFEDBE2DBFD9AC78821D9@MN2PR12MB3085.namprd12.prod.outlook.com>

2022-03-28 03:02 (UTC+0000), Varghese, Vipin:
> [AMD Official Use Only]
> 
> Hi Thomas,
> 
> <snipp>
> 
> Thank you for looking at this problem.
> 
> 26/03/2022 03:59, Vipin Varghese:
> > Support for shell scripts doxy-html-custom, generate_doxygen and 
> > generate_examples are absent. The current patch address the same by 
> > disabling document build notifying the user.  
> 
> It should not prevent generating guides with sphinx.
> 
> We did get error from `doc/meson` stating ` echo command not available on windows` for both cmd and powershell for the line
> ```
> run_target('doc', command: [echo, message, doc_target_names],
>     depends: doc_targets)
> ```

This line never searches for "echo" command,
e8c90926bdde ("doc: fix build on Windows with Meson 0.58")
introduced "echo" variable precisely to avoid this.
Can you give the full log?

> > Steps to reproduce the error:
> >  - Install dependencies doxygen & sphinix build on Windwos server 2019.
> >  - Build DPDK with option enable_docs=true for API or User Guide.
> >
> > This produces error
> > ```
> > FAILED: doc/api/examples.dox
> > sh -e dpdk/doc/api/generate_examples.sh dpdk/examples 
> > doc/api/examples.dox ```  
> 
> I suppose we could replace shell scripts with Python equivalent.
> 
> I am trying to minimize the changes as first step: fix the build error by disabling on windows`.
> Next step we can convert to python to make it cross platform independent.

If something is explicitly requested but not supported,
there should be a failure.
By the way, -Denable_docs=true works when cross-compiling for Windows,
so disabling docs for this target is not right.
I think we should sort out what's causing an issue with "echo" for you
(it shouldn't happen), then fix the scripts to fully enable docs.

  reply	other threads:[~2022-03-28  9:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-26  2:59 Vipin Varghese
2022-03-26  9:41 ` Thomas Monjalon
2022-03-28  3:02   ` Varghese, Vipin
2022-03-28  9:34     ` Dmitry Kozlyuk [this message]
2022-03-28 12:29       ` Varghese, Vipin
2022-03-28 14:37         ` Varghese, Vipin
2022-03-28 22:51         ` Dmitry Kozlyuk
2022-03-29  5:35           ` Varghese, Vipin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220328123438.0f8bb44e@sovereign \
    --to=dmitry.kozliuk@gmail.com \
    --cc=Sivaprasad.Tummala@amd.com \
    --cc=Vipin.Varghese@amd.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).