From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id C9760A034C;
Mon, 28 Mar 2022 11:34:42 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 75EE0427EE;
Mon, 28 Mar 2022 11:34:42 +0200 (CEST)
Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com
[209.85.208.170])
by mails.dpdk.org (Postfix) with ESMTP id C18C5427EA
for <dev@dpdk.org>; Mon, 28 Mar 2022 11:34:40 +0200 (CEST)
Received: by mail-lj1-f170.google.com with SMTP id 17so18344190lji.1
for <dev@dpdk.org>; Mon, 28 Mar 2022 02:34:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
h=date:from:to:cc:subject:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=mqW3ZntiAqa0PgGofiRuvY8IZIj7/BrQ02HMiJRVR5o=;
b=V9j8APRSRFDJeNcOth/XC0/Y1u7NYA2hzr0/+H/rD92vrvygCeYCa4v1hMrUJp4DIK
gidAGj4uxU4oZ8bH5zzPZIKucDNDr4L556OHWFBVXn49eBQ9yzhCoMtg3Gpr59rFxYpK
zxf6F7AaztHXWnNM5CgH/F180XfdZsFWr0095ibcrF0774tce9TnObgqvbCI+NaDH0e5
1NyC0N9uxa+VTOutM4kxwxMsYKcCH2q/BFvSX7Q1uHBkrjWFLRyz0zbwgTK9ROYSi2iz
0EnXqCvX1/oK0ook6n+t1OAs14I0W7xwSki1rDoXMKTHgCgj6c8ssSg2NBPqAc5Eg2Bs
TS0g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=mqW3ZntiAqa0PgGofiRuvY8IZIj7/BrQ02HMiJRVR5o=;
b=78pYS00E+grR25YC9QDKfKkyRIpsWUkF7jGcfFkcqz6FV/zoRl4NJT5icznWv0rabc
gBhW3oY1E0283JKQS/0w/MBBksbbq378YqL/16/G36emT83uwUj3MT4e7XfFAwnOFGpc
YfhxegGJk62Twn7ZyGuw76KUTl9+8wK+LMJUaaepaBmoZIfEh+ANGgWscXBr+hOZdro+
zUsImn3Ai7DTHWv2fahnbdJYKjRcsWRFQqsFxjaM1FW4rmyAxNL3CDKe7hd443e8q6aw
Cd8u57AXhNRTk5WfZ6JX69HaXrl+Xs48OspwV6gvHu7mbIfvoaYqZ5TyuiuHyiJQ5Rxn
PxhA==
X-Gm-Message-State: AOAM5326RziG823RUr2mRA0bKfjgqIHaK6lAdCFwO23ZXfEcc4h8BNIy
CkdK3urG9m9XW/tcJ++8iYA=
X-Google-Smtp-Source: ABdhPJzCgL1tF+eag3GYesXQ+JJrZ5pjU4QOCmqmvCGzN9uUE1cFwbbccgMoQEQYL2L2hPpewLRn5Q==
X-Received: by 2002:a05:651c:603:b0:249:7e8f:787d with SMTP id
k3-20020a05651c060300b002497e8f787dmr19946715lje.465.1648460080138;
Mon, 28 Mar 2022 02:34:40 -0700 (PDT)
Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru.
[37.110.65.23]) by smtp.gmail.com with ESMTPSA id
70-20020a2e0549000000b00247e4fb5574sm1666821ljf.51.2022.03.28.02.34.39
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 28 Mar 2022 02:34:39 -0700 (PDT)
Date: Mon, 28 Mar 2022 12:34:38 +0300
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: "Varghese, Vipin" <Vipin.Varghese@amd.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, "david.marchand@redhat.com"
<david.marchand@redhat.com>, "Tummala, Sivaprasad"
<Sivaprasad.Tummala@amd.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH] meson: update doc logic for Windows
Message-ID: <20220328123438.0f8bb44e@sovereign>
In-Reply-To: <MN2PR12MB3085A3D0DFEDBE2DBFD9AC78821D9@MN2PR12MB3085.namprd12.prod.outlook.com>
References: <20220326025936.487626-1-vipin.varghese@amd.com>
<2037084.bB369e8A3T@thomas>
<MN2PR12MB3085A3D0DFEDBE2DBFD9AC78821D9@MN2PR12MB3085.namprd12.prod.outlook.com>
X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
2022-03-28 03:02 (UTC+0000), Varghese, Vipin:
> [AMD Official Use Only]
>
> Hi Thomas,
>
> <snipp>
>
> Thank you for looking at this problem.
>
> 26/03/2022 03:59, Vipin Varghese:
> > Support for shell scripts doxy-html-custom, generate_doxygen and
> > generate_examples are absent. The current patch address the same by
> > disabling document build notifying the user.
>
> It should not prevent generating guides with sphinx.
>
> We did get error from `doc/meson` stating ` echo command not available on windows` for both cmd and powershell for the line
> ```
> run_target('doc', command: [echo, message, doc_target_names],
> depends: doc_targets)
> ```
This line never searches for "echo" command,
e8c90926bdde ("doc: fix build on Windows with Meson 0.58")
introduced "echo" variable precisely to avoid this.
Can you give the full log?
> > Steps to reproduce the error:
> > - Install dependencies doxygen & sphinix build on Windwos server 2019.
> > - Build DPDK with option enable_docs=true for API or User Guide.
> >
> > This produces error
> > ```
> > FAILED: doc/api/examples.dox
> > sh -e dpdk/doc/api/generate_examples.sh dpdk/examples
> > doc/api/examples.dox ```
>
> I suppose we could replace shell scripts with Python equivalent.
>
> I am trying to minimize the changes as first step: fix the build error by disabling on windows`.
> Next step we can convert to python to make it cross platform independent.
If something is explicitly requested but not supported,
there should be a failure.
By the way, -Denable_docs=true works when cross-compiling for Windows,
so disabling docs for this target is not right.
I think we should sort out what's causing an issue with "echo" for you
(it shouldn't happen), then fix the scripts to fully enable docs.