From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11DF6A0501; Sat, 2 Apr 2022 02:54:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AF41040E03; Sat, 2 Apr 2022 02:54:15 +0200 (CEST) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id 57E3C4067E for ; Sat, 2 Apr 2022 02:54:13 +0200 (CEST) Received: by mail-pl1-f174.google.com with SMTP id y6so3836984plg.2 for ; Fri, 01 Apr 2022 17:54:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:date:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xJdREi/iqObpCwqZ0eTjHBg1lG5PLSOf2PbPMtr9AKk=; b=p7cduvj70g67QyMcPFY/d9hjMH1CcjGH5DTIZmJO68LFcQFiih1LxJeigFn3aGaqGy VXuJliCFsMkap0eXR8uTi/N1b/38RoITL37f47nPRTphR4QodHqKAwMXL74m4anchNiz c5ySAF9dOF/z8ifBONPVzcWHHML+pBgDd36clAIfrfFEbz+3HZXP+S5FrZL8qbIJzMyB n+/VN5+yHdm/jXyMj00Vg4JujOLzkQDk0aCtVV9H5DICs4BYYGyNBi/WMFWRxRStOclc AearU/iWzZ/oWBC98eXpO6cJEfoA42plHdVKtXxk3DDdNgqgMIBmGScmwGjD8Bg/1DUu 4ahA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:date:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xJdREi/iqObpCwqZ0eTjHBg1lG5PLSOf2PbPMtr9AKk=; b=GMiXtvI/M0TIZLBdQsasgFI5qGBTi/ceN0vgZyxXB/aeTW6Hlcodn8NsblfutJdTTR aZmWKmVWpjHiC9feARao7IGwN5YeP9LvMpEVkcmq6d4K9GbC8LBYrxvKpWF2EnaoM1va YXRpoJ02x7vNHIRr9m2YHVweECdOiLn3PAe+pw/RC5TbJ6mTKhGL7TQXCQ63jkPhXnaZ XJC8bTzJLv4fzgC9YsI1JZBGvlTFr3ftlU/zOmngSZfd38Ba+p7X3RVOi17tcxDybh3m VuUXUAUWjLwyjXHjzZ2r9b1KAb3NPojoePmWO06/Kp4BfDNWP9yzUvzL9SYyfIVxfK2a NLoA== X-Gm-Message-State: AOAM530Nd2SMH3WgR9a/HTgzuOF4M3gnuTuLuVxKT8jFGia9ARr6Z22O 4A1gmE2vTs0MrfJDg3+YnX3OcA== X-Google-Smtp-Source: ABdhPJyNt7jVf6YvkEBBk8evBTubGkvUxnUBdafVhdA6L+nogpq6291ya486yK6nOMXKg1xCo+Sbrg== X-Received: by 2002:a17:90b:fc1:b0:1c9:f2c1:5be6 with SMTP id gd1-20020a17090b0fc100b001c9f2c15be6mr14730416pjb.183.1648860852559; Fri, 01 Apr 2022 17:54:12 -0700 (PDT) Received: from shemminger-XPS-13-9360 (hirgnt26.hicv.net. [205.172.16.196]) by smtp.gmail.com with ESMTPSA id 124-20020a621682000000b004f6a2e59a4dsm4130495pfw.121.2022.04.01.17.54.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Apr 2022 17:54:12 -0700 (PDT) From: Stephen Hemminger X-Google-Original-From: Stephen Hemminger Date: Fri, 1 Apr 2022 14:54:05 -1000 To: Mattias =?UTF-8?B?UsO2bm5ibG9t?= Cc: Morten =?UTF-8?B?QnLDuHJ1cA==?= , Ola Liljedahl , "dev@dpdk.org" , Thomas Monjalon , David Marchand , Onar Olsen , "Honnappa.Nagarahalli@arm.com" , "nd@arm.com" , "konstantin.ananyev@intel.com" Subject: Re: [PATCH v2] eal: add seqlock Message-ID: <20220401145405.78a8930b@shemminger-XPS-13-9360> In-Reply-To: References: <98CBD80474FA8B44BF855DF32C47DC35D86F84@smartserver.smartshare.dk> <20220330142602.108061-1-mattias.ronnblom@ericsson.com> <3888e595-de18-3cf0-707b-309b153c2b02@ericsson.com> <37d60d0f-9911-7692-cdb6-62cd5da540ac@arm.com> <98CBD80474FA8B44BF855DF32C47DC35D86F8D@smartserver.smartshare.dk> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 31 Mar 2022 13:51:32 +0000 Mattias R=C3=B6nnblom wrote: > >=20 > > Regarding naming, you should also consider renaming > > rte_seqlock_write_begin/end() to rte_seqlock_write_lock/unlock(), > > following the naming convention of the other locks. This could > > prepare for future extensions, such as rte_seqlock_write_trylock(). > > Just a thought; I don't feel strongly about this. Semantics and naming should be the same as Linux kernel or you risk having to reeducate too many people.