From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C57F0A0508; Thu, 7 Apr 2022 05:18:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 82F6C40689; Thu, 7 Apr 2022 05:18:34 +0200 (CEST) Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by mails.dpdk.org (Postfix) with ESMTP id C640F4014F for ; Thu, 7 Apr 2022 05:18:32 +0200 (CEST) Received: by mail-pf1-f174.google.com with SMTP id h19so4292198pfv.1 for ; Wed, 06 Apr 2022 20:18:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=b/DJncU4fmREnAA+2xJBrGCc/wyhw2S33mSQ19CQkGo=; b=4ssVmxgXJ3ItzD3lTyN3Uyx96Id4xUp5OzvbbAIT0gV7KjKARpOrFCrdkyMWlzNY4R FXpy0jbuIi17Z4qMV3Ra8XxnOIoArSPVXkWki2TPQcgGbqCcgyRU6FAsWBzJ0EdP/qYf 43SMvP+sPgTShxYwA1itgbDG3rrgKT1il/vFnTmcfy9xE/sGE2bwY5mdQunK62Xn5POV VHj2vUypnndGcs0hU+4VUVGq4cAGZW2k99WFVScBdp0wcdEd0whI98x4IVokoPRUkaja 033yRZVdrXrw+19OCsPnIAfGQgRGe2HC8/JskXNEhGmnbrngTEOxzBVqAS/jRXAShMyT t7KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=b/DJncU4fmREnAA+2xJBrGCc/wyhw2S33mSQ19CQkGo=; b=D6klJ8wWPEbuCGcDltg0EvhejB1xp5yGHvP09poIlIjdCjmqj9ZO2I8yWDdw52R+IN umWVWH58duePhFzl8uKvgKIQdemaxBt4fo3WpZECvI0bKfT+1YuTL2XflwSI0jdjKiDx bAStKzU8ubSaTy7KJikUnN9IF8+dWvJlCJ2yUHj3EHmH7bJFTb5WdhkSscuvZhiScDGL I4rx8DfZR96sDRx1R9Iba8/MZlF1BZt6lUZO57ooampAJ8lBlOrbJ9CSx8HGlz7iAlGl gU6KC7h5OIxnGdxzCOBwULUPRisdc3yZxE5ln4Ft6xMb1XNxS9Gnk3wWNGuUO5fSjRMk Qf0A== X-Gm-Message-State: AOAM5311fTeHWDuxmkuBNpsK8vaElKEmwWdHHX8KklMMsDHnMPy4AN1k 7p16yssIIXGTYu7qxMCedDWKWQ== X-Google-Smtp-Source: ABdhPJxF1uQesssDZsbXNrqj05f4JeTAFgWrG5wuSVjoQ1R0XSz7WE8ww2622VXqg6+tg5yllKxaoQ== X-Received: by 2002:a63:514a:0:b0:39c:c255:11dd with SMTP id r10-20020a63514a000000b0039cc25511ddmr1996350pgl.368.1649301511954; Wed, 06 Apr 2022 20:18:31 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id 16-20020a17090a005000b001c7511dc31esm6906733pjb.41.2022.04.06.20.18.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 20:18:31 -0700 (PDT) Date: Wed, 6 Apr 2022 20:18:28 -0700 From: Stephen Hemminger To: "Min Hu (Connor)" Cc: , , Subject: Re: [PATCH] kni: fix device address set Message-ID: <20220406201828.6eac9e56@hermes.local> In-Reply-To: <40f8ce34-982c-d96f-b1a7-d8381c36dcf1@huawei.com> References: <20220406082213.45750-1-humin29@huawei.com> <20220406081700.4aa2d9a7@hermes.local> <40f8ce34-982c-d96f-b1a7-d8381c36dcf1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 7 Apr 2022 08:44:23 +0800 "Min Hu (Connor)" wrote: > Hi, Stephen, > I think this is a good option, but the macro definition is like: > +#if LINUX_VERSION_CODE < KERNEL_VERSION(3, 14, 0) > +#define ether_addr_copy(dst, src) memcpy(dst, src, ETH_ALEN) > +#endif Minimal supported DPDK version is 4.4 now. So this is not a problem. Note: 4.4 kernel reached end of support window in Febrary 2022. It is supported by the SLTS project but it would be unwise to use later DPDK on a kernel that is stuck being supported until 2036. Apparently my patch to update it to current LTS 4.9 is sitting stuck in patchwork.