From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BAEF3A050F; Fri, 8 Apr 2022 01:06:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5DBAD4067E; Fri, 8 Apr 2022 01:06:29 +0200 (CEST) Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by mails.dpdk.org (Postfix) with ESMTP id 493684003F for ; Fri, 8 Apr 2022 01:06:28 +0200 (CEST) Received: by mail-pg1-f170.google.com with SMTP id t13so6242759pgn.8 for ; Thu, 07 Apr 2022 16:06:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FVFkqm1M6kEd96mbG84e52gbydfZn9mMvx6XgsjbJSI=; b=P4ePnB34UPuIf5dVVaK+1FJK4Gi2a3Z9Jq+uo0UwjUawCBppaX+YEAqQICTxQfQSv4 QdPaVXeQUjrvjkW7ZCnGkLBsn/kU0UdRXNgNAUIlb8o4Hq1uc6p09L017EQRpwV6K7N4 47D6MpiV7s9elGoBl5bA69bCilA6z3bvjxvy/hb98ygP7DEjNxAPwAOHRVLBmi7XZ9i3 Jv3+lw6EEKSvtfzub/kT+o2aI3pkFmqDbco5ogdssF+ZG21GoSYEtbLIDRq2SsO6f4g1 fKSqqEBDiN5TUa4AyMdf1kBNVUnXhbEEUS0bEJI0UG/lylBwxXP+GFdj1vCQyUvSx0pm xg3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FVFkqm1M6kEd96mbG84e52gbydfZn9mMvx6XgsjbJSI=; b=LCEly1C9eLnuYYRwZnxhnwi4Bibvqd6l+aZIMfwSKXUClWPonj3FaFatIpZQYWc8iq FvW12yldSeea/G2fmQJXXteeYw9c6bOGrbXpoYUxErVcyWQISXJFiKnE74UxoDlm+gg8 HgsHrLPzSn7Du7I+9/A7aCR9WZzZ21SxQHRcel1qEDfZJU7K2VMzZdColWl1AM4IR9us Q3In+0TyBNcQtqocvOq9Rmmg8F4eKzBkI0vbG/GQdwh3yneD0gIGN6wiyExW7+OmZy3m +rKc7TZvZz6ceCxIdHyYW0SEkc1b3d5HkQ7dw8TeAS/Enx3kQ2J7ogQbQpFEAs10j3JU T2Fw== X-Gm-Message-State: AOAM532ozrFe5gsBYY6xDew/2y+j8onashTOHTjYoLf5po42NrfrKmVA nmD8s4/bBbmlvEnCxzq/Vi/2sQ== X-Google-Smtp-Source: ABdhPJxHKkdPoHUM1Vetk4CmfDe5UMwWAiIngTXzZTn3B+CVbv0cZmyU2KsdBuT/K1VsbWFNQCuiqg== X-Received: by 2002:a63:644:0:b0:39c:dd73:6769 with SMTP id 65-20020a630644000000b0039cdd736769mr2815509pgg.281.1649372787419; Thu, 07 Apr 2022 16:06:27 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id m21-20020a17090a7f9500b001c97c6bcaf4sm10129880pjl.39.2022.04.07.16.06.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Apr 2022 16:06:26 -0700 (PDT) Date: Thu, 7 Apr 2022 16:06:23 -0700 From: Stephen Hemminger To: David Marchand Cc: dev , Morten =?UTF-8?B?QnLDuHJ1cA==?= , Bruce Richardson , Thomas Monjalon Subject: Re: [PATCH v2 0/2] rte_dump_stack: improvements Message-ID: <20220407160623.77e9d5a6@hermes.local> In-Reply-To: References: <20220129011039.264377-1-stephen@networkplumber.org> <20220212184433.66791-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 7 Apr 2022 14:45:07 +0200 David Marchand wrote: > On Sat, Feb 12, 2022 at 7:44 PM Stephen Hemminger > wrote: > > > > This is update to earlier RFC. Add some more comments and changes > > to have common code for Linux and FreeBSD > > > > Stephen Hemminger (2): > > eal_debug: do not use malloc in rte_dump_stack > > eal: common rte_dump_stack for both Linux and FreeBSD > > > > lib/eal/freebsd/eal_debug.c | 43 ------------------------ > > lib/eal/freebsd/meson.build | 1 - > > lib/eal/linux/eal_debug.c | 43 ------------------------ > > lib/eal/linux/meson.build | 1 - > > lib/eal/unix/eal_debug.c | 65 +++++++++++++++++++++++++++++++++++++ > > lib/eal/unix/meson.build | 5 +-- > > 6 files changed, 68 insertions(+), 90 deletions(-) > > delete mode 100644 lib/eal/freebsd/eal_debug.c > > delete mode 100644 lib/eal/linux/eal_debug.c > > create mode 100644 lib/eal/unix/eal_debug.c > > Strange to change only the Linux implementation as a first patch, then > merge implementations in a second time effectively changing FreeBSD > implementation in what is presented in commitlog as a factorisation > cleanup. > Please invert the patches. > > Besides, the series does not compile on current main. > It's probably a result of the header inclusion cleanup we had in > v22.03, but I prefer you check. > > > Thanks. As I looked at it more, there was more there. Turns out that printf and therefore rte_log() is not signal safe. There is a version of backtrace_symbols_fd that just uses writev() on glibc for Linux so that is a better alternative, but format changes. But the BSD version of backtrace_symbols_fd uses printf and is therefore not signal safe. Not sure if that matters.