From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B991A050B; Fri, 8 Apr 2022 15:46:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7493840E64; Fri, 8 Apr 2022 15:46:17 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 6E6B94003F for ; Fri, 8 Apr 2022 15:46:15 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 98ABE203A03C; Fri, 8 Apr 2022 06:46:14 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 98ABE203A03C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1649425574; bh=76tcyuHNFjWg0fa6/GA3p/CvLsyegCIyT4euV5XZg/E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fZmc1w4hrE0exy8o6msa4aPmtHpPKhRhp13sb/kBM0md5zU9HLgrAIstMtUIlsuHE H71tS98/GlP4GIc45q5qHzWfgp7go7RE/BxXviZC9c9HhAKIYis+PkuKmgwz0o3NXh OvQby4JS8kg52GBCabdulws1kTx54N42Dplfauvg= Date: Fri, 8 Apr 2022 06:46:14 -0700 From: Tyler Retzlaff To: David Marchand Cc: dev , Thomas Monjalon , Dmitry Kozlyuk , "Burakov, Anatoly" , Narcisa Ana Maria Vasile Subject: Re: [PATCH 0/3] add eal functions for thread affinity Message-ID: <20220408134614.GB550@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1648819793-18948-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Apr 08, 2022 at 10:57:55AM +0200, David Marchand wrote: > Hello Tyler, > > On Fri, Apr 1, 2022 at 3:30 PM Tyler Retzlaff > wrote: > > > > this series provides basic dependencies for additional eal thread api > > additions. series includes basic error handling, initial get/set thread > > affinity functions and minimal unit test. > > > > Tyler Retzlaff (3): > > eal/windows: translate Windows errors to errno-style errors > > eal: implement functions for get/set thread affinity > > test/threads: add unit test for thread API > > > > app/test/meson.build | 2 + > > app/test/test_threads.c | 86 +++++++++++++++++++ > > lib/eal/include/rte_thread.h | 45 ++++++++++ > > lib/eal/unix/rte_thread.c | 16 ++++ > > lib/eal/version.map | 4 + > > lib/eal/windows/eal_lcore.c | 173 +++++++++++++++++++++++++++---------- > > lib/eal/windows/eal_windows.h | 10 +++ > > lib/eal/windows/include/rte_os.h | 2 + > > lib/eal/windows/rte_thread.c | 179 ++++++++++++++++++++++++++++++++++++++- > > 9 files changed, 472 insertions(+), 45 deletions(-) > > create mode 100644 app/test/test_threads.c > > We have two concurrent series, can you clarify what are the intentions > on this work? yes, i should have clarified this up front sorry. > Is this series superseding Narcisa series? this series supersedes the series from Narcisa. it was resolved through discussion that the current series should be abandoned as it is too large and not making progress. we've elected to submit a series of smaller patchsets that incorporate the feedback received to date and build up the api surface for threading. the patches are still the work of Narcisa but she is overscheduled so i will assist in upstreaming and addressing feedback. additionally, rather than port the tree to the new __experimental api as they are added we will prefer to add unit tests that provide validation of the api and example usage. our hope is the smaller scoped series will attract more attention and have better acknowledgement velocity. i will have Narcisa mark the monolithic series as superseded on patchwork. ty