From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67724A050B; Wed, 13 Apr 2022 18:12:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 202D440694; Wed, 13 Apr 2022 18:12:27 +0200 (CEST) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mails.dpdk.org (Postfix) with ESMTP id 28D1C4068E for ; Wed, 13 Apr 2022 18:12:25 +0200 (CEST) Received: by mail-pl1-f173.google.com with SMTP id s14so2354983plk.8 for ; Wed, 13 Apr 2022 09:12:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=obhnecrHruD0eQE7jqgDIfjm9rZB4WmCS6qqGIqgwus=; b=GxzCiNVY0a2MafIK3XFfGpWFEExpqlfuJp+/svtteJ6vVRGmIOn4Xoq7FCKLjYToMS 35FkmZRcDT9T9SUzoilo+hPZgKyBWKmOJtKeo0p+3vwYlqUkDZA7f0qV0YC13BSsz0QO sjQG+9eusV1dTOWRbPd8rnZqwbh7uMfSIlzcwQwM4JzKmFEqLH7D7+GVCGPdi8eeVrU9 WWxx72ejx1tzz6XU9SMfSLZJywQOYme8dEFtLsaM5okPhcn6fUk4N9C2zEaozd1NP+RH QTcwGJoW3e0CzQw2z76bpLb0aux6OG3FEBoc5Dcphq30WsWOMzVu35PoGow1hNdmw653 UrXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=obhnecrHruD0eQE7jqgDIfjm9rZB4WmCS6qqGIqgwus=; b=nmSF0hPSxGCOsm6KOtY3JWf0zoMFnphKvIcXWoBHVV1GJ9rwtYrqRio1s/vAH8emGy c2Pracawws23DZUMo8/3p4PsM1+TMH4AS3fU6fFJkK0IE6ormnoQ3AVjrobCqzcOxhTk BZeIZGcWDj+5RYmmMmzrzGyEhXAudB9MhyZQpMhZP34JqXd7IBgLxFbaAeTdyG9C89n/ wUDJJOgimWS8SjpL77YrEw4SsqVFynSwMBzYsfKqkAjdGYYq86/fT1XTOrnMIqVPsP7t GSom4/XQoLOdLKgR6b9sUK4Yavi3E8sLqayKIMHbLGqUX0pF1G5WVz/VpOn5PTp3qJKg kOuw== X-Gm-Message-State: AOAM531Q2iKaSr2qt1wtlM1vg33FUrpr+qGm4WsEhJllNFFkxLTUsIbs +CWTHnb+qDX6ETo2r5VpHDEx9w== X-Google-Smtp-Source: ABdhPJzokX4n2E7ST4HfSFSC3a1k3si756Xq8euDsY5PD5lvKmY08oLUQ+16tVsnIkWckuJPlb8K1w== X-Received: by 2002:a17:902:db04:b0:158:4eab:9208 with SMTP id m4-20020a170902db0400b001584eab9208mr19023878plx.128.1649866344127; Wed, 13 Apr 2022 09:12:24 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id i2-20020a17090ac40200b001bd0e552d27sm3249771pjt.11.2022.04.13.09.12.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Apr 2022 09:12:23 -0700 (PDT) Date: Wed, 13 Apr 2022 09:12:20 -0700 From: Stephen Hemminger To: "Min Hu (Connor)" Cc: "Zhang, Ke1X" , "chas3@att.com" , "dev@dpdk.org" Subject: Re: [PATCH] net/bonding: fix rss key configuration when the key length is 52 Message-ID: <20220413091220.5bcce2c8@hermes.local> In-Reply-To: <6a16b3b3-9edd-5866-690c-804e9bcb5718@huawei.com> References: <20220407093642.44900-1-ke1x.zhang@intel.com> <66552a01-6f88-b0b2-a69f-24d0484ea36d@huawei.com> <20220412081930.293e4384@hermes.local> <6a16b3b3-9edd-5866-690c-804e9bcb5718@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 13 Apr 2022 17:03:07 +0800 "Min Hu (Connor)" wrote: > Hi, Stephen, >=20 > =E5=9C=A8 2022/4/12 23:19, Stephen Hemminger =E5=86=99=E9=81=93: > > On Mon, 11 Apr 2022 03:06:46 +0000 > > "Zhang, Ke1X" wrote: > > =20 > >> This is a coding waring as below: > >> =20 > >> _coding style issues_ > >> =20 > >> WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? > >> #64: > >> when creating a bonding device, if the slave device's rss key length > >> > >> WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? > >> #65: > >> is 52, then bonding device will be same as slave, in function > >> > >> total: 0 errors, 2 warnings, 0 checks, 19 lines checked > >> > >> the 'slave' is correct, for exsample, testpmd cmd: > >> add bonding slave 0 2 =20 > >=20 > > Just a heads up, for 22.11 I plan to replace/deprecate use of master/sl= ave > > terminology in bonding driver. The terms master/slave are legacy and m= ost > > commercial products have switched to the terms from the 802 standard. = =20 > What are the terms ? Could you show them for us? The current IEEE std is https://standards.ieee.org/ieee/802.1AX/6768/ which is unfortunately paywalled. The terms in standard are "Aggregator Client" for the ports used in the dev= ice and "Aggregator Partner/Multiplexor" but they are not quite the same. Probably going to use client and multiplexor as terms; but open for discuss= ion.