DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Subject: Re: [PATCH] rib: fix traversal with /32 route
Date: Thu, 14 Apr 2022 19:29:27 -0700	[thread overview]
Message-ID: <20220414192927.516675a3@hermes.local> (raw)
In-Reply-To: <20220414200104.245071-1-stephen@networkplumber.org>

On Thu, 14 Apr 2022 13:01:04 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:

> If a /32 route is entered in the RIB the code to traverse
> will not see that a a end of the tree. This is due to trying
> to do a negative shift which is an undefined in C.
> 
> Fix by checking for max depth as is already done in rib6.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  lib/rib/rte_rib.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/lib/rib/rte_rib.c b/lib/rib/rte_rib.c
> index cd9e823068d2..0603980cabd2 100644
> --- a/lib/rib/rte_rib.c
> +++ b/lib/rib/rte_rib.c
> @@ -71,6 +71,8 @@ is_covered(uint32_t ip1, uint32_t ip2, uint8_t depth)
>  static inline struct rte_rib_node *
>  get_nxt_node(struct rte_rib_node *node, uint32_t ip)
>  {
> +	if (node->depth == RIB_MAXDEPTH)
> +		return NULL;
>  	return (ip & (1 << (31 - node->depth))) ? node->right : node->left;
>  }


Fixes: 5a5793a5ffa2 ("rib: add RIB library")


  reply	other threads:[~2022-04-15  2:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-14 20:01 Stephen Hemminger
2022-04-15  2:29 ` Stephen Hemminger [this message]
2022-04-26 14:28 ` Medvedkin, Vladimir
2022-04-26 14:30   ` Medvedkin, Vladimir
2022-06-01  7:04     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220414192927.516675a3@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=vladimir.medvedkin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).