From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 25A7EA0510; Fri, 15 Apr 2022 17:00:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E8A04067E; Fri, 15 Apr 2022 17:00:04 +0200 (CEST) Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by mails.dpdk.org (Postfix) with ESMTP id DF9B04067C for ; Fri, 15 Apr 2022 17:00:02 +0200 (CEST) Received: by mail-pf1-f175.google.com with SMTP id 22so1051717pfu.1 for ; Fri, 15 Apr 2022 08:00:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vVO9mDgw0aS/6O6rqZraLW7FYBaxguwaJ3Cu5zTI2VQ=; b=yLURK29yvgHQlfAVbACfyqu13XuZ7lf0f1CANie8z/1anXQamytNVeSquRIzHuIl4c awlAQKSev157JrJHfB69nxtGfWxNT4NL/YkL8aT6IIez7bdyuiQXrvclYlGTY9Ag4gQt kkESC0gkJZjiJD3AAsPwkvFPRhwOex46NDqwnwjeH4L7qTZKnEN5iHD6SNMLIsfXV/Rm 8Z4Me2ZKg04Zb5W9CmINOC256/8f7/EwFD5Jb82SvDlF/uEVcNJs6tp4GcdXjSKusAZL m3D332EMGxAE5BgyF+erCHW4lS38njg1bTjmof5XwlbkPPbsMgjk5kKIFAhid/8JT6gX zS4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vVO9mDgw0aS/6O6rqZraLW7FYBaxguwaJ3Cu5zTI2VQ=; b=7jNVNxUDsEt+E+mhoac3cQWt05sm9kx1Uq0P+0x5cDBOlmvo3ItMV+J0cKKIzo/yWI fhCaMx3IJuxU+q3oZ7qkQVplxseVN3psYfGDMyJSK513H3rFJGPzvliKOT3J7cTNAqIK l1n8iLoiISkMGqLCTTQEYl4YkWPvAzmWTUlBVMSFOHMKKgXfqfhtDmkCv3RfHRLU9VnL NjR4fpugVojJC5Sy1NuOnK+PwSy5VkvC3wLFv5cpbqZPssFG6FhZVhy7FRtgn/CyQbK8 k08fsVHwuzLqw816Gvl78eFZvIGH9MqLr010T9D8XvaBz3B+0LsXJlx5pPv+fbiVMBe4 lScA== X-Gm-Message-State: AOAM533arnp/RGPZ69hWmZh58Px0ChARM+SGxDdwQ05z4DDB0bpnGCTt 0awTKaf54rrjXMv7mEM2sz2Bww== X-Google-Smtp-Source: ABdhPJzhxeSHQOH0EPprMzwRxR4z2DX3gu0fSf87bezFvxhiV3XAfFYU+pbi2Zxt1z/yzdFGYlNJEg== X-Received: by 2002:a05:6a00:a8b:b0:4cd:6030:4df3 with SMTP id b11-20020a056a000a8b00b004cd60304df3mr9284624pfl.40.1650034801993; Fri, 15 Apr 2022 08:00:01 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q13-20020a056a00088d00b004e1bea9c582sm3215202pfj.43.2022.04.15.08.00.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Apr 2022 08:00:01 -0700 (PDT) Date: Fri, 15 Apr 2022 07:59:59 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: Gagandeep Singh , Harold Huang , "dev@dpdk.org" Subject: Re: [PATCH] kni: update kernel API to receive packets Message-ID: <20220415075959.27778efd@hermes.local> In-Reply-To: References: <20220414122319.3519271-1-g.singh@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 15 Apr 2022 13:30:33 +0100 Ferruh Yigit wrote: > >> But this change would cause KNI kernel module does not work in the old kernel > >> without this patch. I suggested using netif_rx_ni to keep compatibility. > > > > netif_rx() API exists from very older versions of kernel before v2.6. There will be > > no compilation issues. Only difference was, netif_rx_ni() can be used in noninterrupt contexts > > to improve performance. > > May not be compilation issue, but with old kernels won't the behavior be > different when 'netif_rx_ni()' switched to 'netif_rx() Probably best handled by #ifdef on kernel version but will be a mess for backports to distro kernels. Looks like: Older -> New netif_rx_ni netif_rx neitf_rx __netif_rx