From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E592A0510; Sat, 16 Apr 2022 03:38:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BC9D840042; Sat, 16 Apr 2022 03:38:35 +0200 (CEST) Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by mails.dpdk.org (Postfix) with ESMTP id 0EC2D40040 for ; Sat, 16 Apr 2022 03:38:35 +0200 (CEST) Received: by mail-pg1-f174.google.com with SMTP id k14so9267375pga.0 for ; Fri, 15 Apr 2022 18:38:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mjYnNGc+hcc+3GAfv6H7ygls4h7AE2EX5E4h2q3TFbI=; b=sQPHkyEc1p7HxupThrVlaZbToZbc/RNe07qQip1Q7ZHY8FWpCrn9qYH6+8KgN7/X8W y9Lva4jOsucQsjQYx1T4na377NFnBayZYaUXZqskwr24nC7MU1zNjpkb/KWDVOAHY4Nr prpZ6ZKGUaeSBFAvZTclqyvVkFtncKBad5neIWbVTBoltA96Zq+hrrViHnxWlZXBYGZh XNme2/YXTlCAWElW2F8ocsQdkd/jxIGBJ1v/rRn/+T124t+qb3HEi+G7yLq/d3dVZaXJ C9QpsMWPeId1zU2dkRVM1q7AQ1EBqOL4bC8gF0LQIPFp/gYkhp0P37oHEp2jwFDfp7PV /l3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mjYnNGc+hcc+3GAfv6H7ygls4h7AE2EX5E4h2q3TFbI=; b=XM+M8T3rFb89feizJ1k8ub0DcwQ/rxE0y+4EcVtqqi/chdLFdfXItnZh8jUjx8Xxdy fRTIbPkA7sch4h8gDqbBDFJPrZWy7kc7p5yUFPvmdjmPohwe3pCY0Poax44A1eNc1/+i lWN+TSzwdow3jhmQLTcrCcBK4Gmddu/jTyprjO8GePju9z3tLpF0Eq1eyC3XFfY1jF0G ZG2GugR9ZHYweygLlT1CCdXd1XTGgkyWYImNdhAPibqS/ZTozFzgj8Pg76HGcOXoiSeK HIxqrjHDpK2MQOcWLNlwM+xZu5C9YSU7Wk0dGTR8Qobf+duzntd4UsI7XOuXLPuiAbZE qibA== X-Gm-Message-State: AOAM533mQQNbMYLxtTN6a/AjhiFogwcLGa4hmUDzWCipzNXLeZOikZ4i hBrY2IhHy62Yn1iYSJyzKu/EZg== X-Google-Smtp-Source: ABdhPJwKqIUO1b6NUSjxV04r0qyJiASnXC8AjxE/l/i7v23EJgD5VDBf7QVYsZM0/O/3pOsuOYrHFw== X-Received: by 2002:a05:6a00:b51:b0:4fa:ece9:15e4 with SMTP id p17-20020a056a000b5100b004faece915e4mr1550064pfo.27.1650073114096; Fri, 15 Apr 2022 18:38:34 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id s24-20020a17090a441800b001ca9b5724a6sm5702245pjg.36.2022.04.15.18.38.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Apr 2022 18:38:33 -0700 (PDT) Date: Fri, 15 Apr 2022 18:38:31 -0700 From: Stephen Hemminger To: Chengwen Feng Cc: , , , , , , , Subject: Re: [PATCH 1/3] ethdev: fix telemetry xstats return null with some PMDs Message-ID: <20220415183831.2473346b@hermes.local> In-Reply-To: <20220416010747.40714-2-fengchengwen@huawei.com> References: <20220416010747.40714-1-fengchengwen@huawei.com> <20220416010747.40714-2-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, 16 Apr 2022 09:07:45 +0800 Chengwen Feng wrote: > Currently the telemetry xstats uses rte_eth_xstats_get() to retrieve > the number of elements. But the value to be returned when the parameter > 'xstats' is NULL is not specified, some PMDs (eg. hns3/ipn3ke/mvpp2/ > axgbe) return zero while others return the required number of elements. Lets fix the PMD's this impacts other code as well.