From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE55DA00BE; Sun, 24 Apr 2022 18:17:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5C9B440042; Sun, 24 Apr 2022 18:17:33 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 3727F4003F for ; Sun, 24 Apr 2022 18:17:31 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 23OG3hP4020382 for ; Sun, 24 Apr 2022 09:17:30 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=98AFw8wsKeAnCJposCeY2/nofPP9AKpRbjIWz/rygT0=; b=BmJjlN9vteYn5/ro9TDv1JZAg799Oy/xKIVf2BIyliq5qhq6MY5sYr00oXbRC01Dp6wL mVQ6LdBBxkxsM4HWkiwidu1SxbfIjeGpaBUo1HYMQyuT18MPqD9aKE+NE8a6o8EM+DYy lWicTmExZNaIiiW3At1f81ucjpcRwlvzdFkAheiATILSCxe38w4jmG+vt61z9iZPZM/9 zAMW/QcALOV6hNJt2wiUJADx60+GgUtvCoLgyc6VfbdMIdffNQru+FdiWtFTrm45HueP GG6SoQ8OJxGYQS1Oc71+d8ToHBmirRhhm+CAGGFwRQhHpD7f0wMZPKIVw/Z1lxrIV8ed nA== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3fmetqk1nm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Sun, 24 Apr 2022 09:17:30 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 24 Apr 2022 09:17:29 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sun, 24 Apr 2022 09:17:28 -0700 Received: from localhost.localdomain (unknown [10.28.34.38]) by maili.marvell.com (Postfix) with ESMTP id B9EED3F7094; Sun, 24 Apr 2022 09:17:26 -0700 (PDT) From: Gowrishankar Muthukrishnan To: CC: Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , "Sunil Kumar Kori" , Satha Rao , Gowrishankar Muthukrishnan Subject: [PATCH] common/cnxk: fix null pointer dereference Date: Sun, 24 Apr 2022 21:47:23 +0530 Message-ID: <20220424161723.1680524-1-gmuthukrishn@marvell.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-ORIG-GUID: g66a4VAb7Ncf56yDFvS0c0WvwN1xEf2E X-Proofpoint-GUID: g66a4VAb7Ncf56yDFvS0c0WvwN1xEf2E X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-04-23_01,2022-04-22_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Fix null pointer dereference reported in coverity scan. Coverity issue: 372065 Fixes: 665b6a7400b ("common/cnxk: add NPC helper API") Signed-off-by: Gowrishankar Muthukrishnan --- drivers/common/cnxk/roc_npc_utils.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/common/cnxk/roc_npc_utils.c b/drivers/common/cnxk/roc_npc_utils.c index f9768ea3cf..dadd8826cb 100644 --- a/drivers/common/cnxk/roc_npc_utils.c +++ b/drivers/common/cnxk/roc_npc_utils.c @@ -145,6 +145,9 @@ npc_parse_item_basic(const struct roc_npc_item_info *item, info->mask = item->mask; } + if (info->mask == NULL) + return NPC_ERR_INVALID_MASK; + /* mask specified must be subset of hw supported mask * mask | hw_mask == hw_mask */ -- 2.25.1