From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96AF3A00BE; Sun, 24 Apr 2022 18:25:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 89EF040042; Sun, 24 Apr 2022 18:25:04 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id CFDDE4003F for ; Sun, 24 Apr 2022 18:25:02 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 23OFrrLY008238 for ; Sun, 24 Apr 2022 09:25:02 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=PMvjd2lgw4MEeaiRBNnX4JLvcf+X/jIcGuoEAoTeneE=; b=CT4lj9jbk6lCPT+NAyVhjqjgaM8IvK4KMWUQrM2wMOBT4wYoRL9+9b3BaOilmByLffv4 EZZp/EyLYAqNN9a2UBqigokJz7D6gg1Znm1fLOALZ0P3ab/IN0tgPrUEvtJp/44eXuwX mJsv3Gm8TpJFIzc9d3h0qQMXphX+mWHx2ARdLTQTn0xPC5rsVySwPQ7Pf/GQOoNSZrOT pvMteMi+jEP3pEJHVcHyl3z6Eogcs9a54IruzkdGNDU5IW+tLKd1yi6NojdPMCTG2mKA LkmvYYJgFP0FHvDbcz/U7TJM81FISlJlvb7IfJ9XqWl03bcXepcwlK87jONLH+uWjb5A Hw== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3fmgymau1p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Sun, 24 Apr 2022 09:25:02 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 24 Apr 2022 09:25:00 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sun, 24 Apr 2022 09:24:59 -0700 Received: from localhost.localdomain (unknown [10.28.34.38]) by maili.marvell.com (Postfix) with ESMTP id 37D7E3F7094; Sun, 24 Apr 2022 09:24:57 -0700 (PDT) From: Gowrishankar Muthukrishnan To: CC: Jerin Jacob , Pavan Nikhilesh , Shijith Thotton , Gowrishankar Muthukrishnan Subject: [PATCH] event/cnxk: fix out of bounds access Date: Sun, 24 Apr 2022 21:54:55 +0530 Message-ID: <20220424162455.1681020-1-gmuthukrishn@marvell.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-GUID: 1JHl4kII23ztK-sMpABHONsj-Z2VBU2m X-Proofpoint-ORIG-GUID: 1JHl4kII23ztK-sMpABHONsj-Z2VBU2m X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-04-23_01,2022-04-22_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Fix out of bounds array access reporrted in coverity scan. Coverity issue: 375817 Fixes: 2351506401e ("event/cnxk: add SSO selftest and dump") Signed-off-by: Gowrishankar Muthukrishnan --- drivers/event/cnxk/cnxk_eventdev_selftest.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/event/cnxk/cnxk_eventdev_selftest.c b/drivers/event/cnxk/cnxk_eventdev_selftest.c index 2fe6467f88..3aa6f081a7 100644 --- a/drivers/event/cnxk/cnxk_eventdev_selftest.c +++ b/drivers/event/cnxk/cnxk_eventdev_selftest.c @@ -626,6 +626,12 @@ launch_workers_and_wait(int (*main_thread)(void *), /* start core */ -1, /* skip main */ 1, /* wrap */ 0); + if (w_lcore == RTE_MAX_LCORE) { + plt_err("Failed to get next available lcore"); + free(param); + return -1; + } + rte_eal_remote_launch(main_thread, ¶m[0], w_lcore); for (port = 1; port < nb_workers; port++) { @@ -635,6 +641,12 @@ launch_workers_and_wait(int (*main_thread)(void *), param[port].dequeue_tmo_ticks = dequeue_tmo_ticks; rte_atomic_thread_fence(__ATOMIC_RELEASE); w_lcore = rte_get_next_lcore(w_lcore, 1, 0); + if (w_lcore == RTE_MAX_LCORE) { + plt_err("Failed to get next available lcore"); + free(param); + return -1; + } + rte_eal_remote_launch(worker_thread, ¶m[port], w_lcore); } -- 2.25.1