From: Chengwen Feng <fengchengwen@huawei.com>
To: <thomas@monjalon.net>, <ferruh.yigit@xilinx.com>,
<andrew.rybchenko@oktetlabs.ru>, <ndabilpuram@marvell.com>,
<kirankumark@marvell.com>, <skori@marvell.com>,
<skoteshwar@marvell.com>
Cc: <dev@dpdk.org>
Subject: [PATCH v2 8/9] ethdev: fix possible null pointer access
Date: Thu, 28 Apr 2022 21:15:59 +0800 [thread overview]
Message-ID: <20220428131600.41032-9-fengchengwen@huawei.com> (raw)
In-Reply-To: <20220428131600.41032-1-fengchengwen@huawei.com>
The rte_tel_data_alloc() may return NULL, so the caller should add
judgement for it.
Fixes: 083b0b310b19 ("ethdev: add common stats for telemetry")
Cc: stable@dpdk.org
Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
---
lib/ethdev/rte_ethdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
index 01d4370aa7..a61ec78473 100644
--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -5492,6 +5492,8 @@ eth_dev_add_port_queue_stats(struct rte_tel_data *d, uint64_t *q_stats,
{
int q;
struct rte_tel_data *q_data = rte_tel_data_alloc();
+ if (q_data == NULL)
+ return;
rte_tel_data_start_array(q_data, RTE_TEL_U64_VAL);
for (q = 0; q < RTE_ETHDEV_QUEUE_STAT_CNTRS; q++)
rte_tel_data_add_array_u64(q_data, q_stats[q]);
--
2.33.0
next prev parent reply other threads:[~2022-04-28 13:22 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-16 1:07 [PATCH 0/3] bugfix for ethdev telemetry Chengwen Feng
2022-04-16 1:07 ` [PATCH 1/3] ethdev: fix telemetry xstats return null with some PMDs Chengwen Feng
2022-04-16 1:38 ` Stephen Hemminger
2022-04-21 6:49 ` Andrew Rybchenko
2022-04-24 3:44 ` fengchengwen
2022-04-25 10:16 ` Morten Brørup
2022-04-28 13:38 ` fengchengwen
2022-04-28 13:53 ` Morten Brørup
2022-04-16 1:07 ` [PATCH 2/3] ethdev: fix memory leak when telemetry xstats Chengwen Feng
2022-04-21 6:51 ` Andrew Rybchenko
2022-04-21 8:09 ` David Marchand
2022-04-21 9:03 ` Bruce Richardson
2022-04-22 8:14 ` David Marchand
2022-04-16 1:07 ` [PATCH 3/3] net/cnxk: fix telemetry possible null pointer access Chengwen Feng
2022-04-28 13:15 ` [PATCH v2 0/9] bugfix for ethdev telemetry Chengwen Feng
2022-04-28 13:15 ` [PATCH v2 1/9] ethdev: define retval when xstats is null of get xstats Chengwen Feng
2022-05-04 10:32 ` Andrew Rybchenko
2022-04-28 13:15 ` [PATCH v2 2/9] net/hns3: adjust " Chengwen Feng
2022-05-06 7:56 ` Min Hu (Connor)
2022-04-28 13:15 ` [PATCH v2 3/9] net/ipn3ke: " Chengwen Feng
2022-04-28 13:15 ` [PATCH v2 4/9] net/mvpp2: " Chengwen Feng
2022-04-28 13:15 ` [PATCH v2 5/9] net/axgbe: " Chengwen Feng
2022-04-28 13:15 ` [PATCH v2 6/9] ethdev: fix memory leak when telemetry xstats Chengwen Feng
2022-04-28 13:15 ` [PATCH v2 7/9] ethdev: support auto-filled flag when telemetry stats Chengwen Feng
2022-04-28 13:15 ` Chengwen Feng [this message]
2022-04-28 13:16 ` [PATCH v2 9/9] net/cnxk: fix telemetry possible null pointer access Chengwen Feng
2022-05-05 8:02 ` [PATCH v3 00/10] bugfix for ethdev telemetry Chengwen Feng
2022-05-05 8:02 ` [PATCH v3 01/10] ethdev: define retval when xstats is null of get xstats Chengwen Feng
2022-05-05 8:02 ` [PATCH v3 02/10] ethdev: optimize xstats-get API's implementation Chengwen Feng
2022-05-12 10:31 ` Andrew Rybchenko
2022-05-05 8:02 ` [PATCH v3 03/10] net/hns3: adjust retval when xstats is null of get xstats Chengwen Feng
2022-05-12 9:51 ` Andrew Rybchenko
2022-05-05 8:02 ` [PATCH v3 04/10] net/ipn3ke: " Chengwen Feng
2022-05-05 8:02 ` [PATCH v3 05/10] net/mvpp2: " Chengwen Feng
2022-05-05 8:02 ` [PATCH v3 06/10] net/axgbe: " Chengwen Feng
2022-05-12 10:00 ` Andrew Rybchenko
2022-05-05 8:02 ` [PATCH v3 07/10] ethdev: fix memory leak when telemetry xstats Chengwen Feng
2022-05-05 8:02 ` [PATCH v3 08/10] ethdev: support auto-filled flag when telemetry stats Chengwen Feng
2022-05-12 10:26 ` Andrew Rybchenko
2022-05-05 8:02 ` [PATCH v3 09/10] ethdev: fix possible null pointer access Chengwen Feng
2022-05-12 10:29 ` Andrew Rybchenko
2022-05-05 8:02 ` [PATCH v3 10/10] net/cnxk: fix telemetry " Chengwen Feng
2022-05-12 10:30 ` Andrew Rybchenko
2022-05-13 2:53 ` [PATCH v4 0/9] bugfix for ethdev telemetry Chengwen Feng
2022-05-13 2:53 ` [PATCH v4 1/9] ethdev: specify return value of xstats-get API Chengwen Feng
2022-05-13 2:53 ` [PATCH v4 2/9] ethdev: optimize xstats-get API's implementation Chengwen Feng
2022-05-13 2:53 ` [PATCH v4 3/9] net/hns3: adjust return value of xstats-get ops Chengwen Feng
2022-05-13 2:53 ` [PATCH v4 4/9] net/ipn3ke: " Chengwen Feng
2022-05-13 2:53 ` [PATCH v4 5/9] net/mvpp2: " Chengwen Feng
2022-05-13 2:53 ` [PATCH v4 6/9] net/axgbe: " Chengwen Feng
2022-05-13 2:53 ` [PATCH v4 7/9] ethdev: fix memory leak when telemetry xstats Chengwen Feng
2022-05-13 2:53 ` [PATCH v4 8/9] ethdev: fix possible null pointer access Chengwen Feng
2022-05-13 2:53 ` [PATCH v4 9/9] net/cnxk: fix telemetry " Chengwen Feng
2022-05-16 8:43 ` [PATCH v4 0/9] bugfix for ethdev telemetry Morten Brørup
2022-05-20 14:50 ` Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220428131600.41032-9-fengchengwen@huawei.com \
--to=fengchengwen@huawei.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).