From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 12E7DA0032; Sun, 1 May 2022 16:49:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B3D8B4069D; Sun, 1 May 2022 16:49:32 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id EB3B84003F for ; Sun, 1 May 2022 16:49:30 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.16.1.2) with ESMTP id 241DsqUs026949; Sun, 1 May 2022 07:47:07 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=/CV5gFiTDF9Ux30gVxlgdd271Hv6OqMKna1x/cyb+gk=; b=BpfLiTAz7KAwVqJjMyoteQQS/huUlOXXCDFZEb3DdBPz0Ag1kJn8cjJG/GYKUyKmf3/0 e+o6HVZMz32Iw1NPjUAmAIsn58BHHAs/6G8LSCVt8WtSgxS3XkxXzBWg+GqUkOlZrBJD 5TlsYV4GvegfooCUC+uCqoio/Sbau9+I8Lhs9VW2tXmol8Ym0GKMJGxsM9ANp/Eq7QnQ b98Yye4i1wDKtfXzxzHUEQUtY7ca1OiAojLJfMKkAtELLRStdrswBsVz1h5QO4iSydh6 c7J24CKLccEoHxBDMLhzA/WLR6GsokE/cNZnLwpmFf2BGRPxrF7tpE9xj/2SXYZkvXmA AQ== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3fs2fmtwd4-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Sun, 01 May 2022 07:47:07 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 1 May 2022 07:47:05 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Sun, 1 May 2022 07:47:05 -0700 Received: from jerin-lab.marvell.com (jerin-lab.marvell.com [10.28.34.14]) by maili.marvell.com (Postfix) with ESMTP id D9CDC3F7059; Sun, 1 May 2022 07:46:46 -0700 (PDT) From: To: , Cristian Dumitrescu , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Ray Kinsella CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Jerin Jacob Subject: [dpdk-dev] [PATCH v5] ethdev: mtr: support protocol based input color selection Date: Sun, 1 May 2022 20:16:37 +0530 Message-ID: <20220501144637.3757757-1-jerinj@marvell.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220421180241.514767-1-jerinj@marvell.com> References: <20220421180241.514767-1-jerinj@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-GUID: VbX-TqPgonrXf_rFh0HU6DGnRHsUfmpK X-Proofpoint-ORIG-GUID: VbX-TqPgonrXf_rFh0HU6DGnRHsUfmpK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-01_05,2022-04-28_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Jerin Jacob Currently, meter object supports only DSCP based on input color table, The patch enhance that to support VLAN based input color table, color table based on inner field for the tunnel use case, and support for fallback color per meter if packet based on a different field. All of the above features are exposed through capability and added additional capability to specify the implementation supports more than one input color table per ethdev port. Suggested-by: Cristian Dumitrescu Signed-off-by: Jerin Jacob --- v5..v4: - Improved the Doxgen comments as per http://patches.dpdk.org/project/dpdk/patch/20220421180241.514767-1-jerinj@marvell.com/ - Removed input_color_proto_mask - Renamed rte_mtr_color_in_protocol_priority_set() to rte_mtr_color_in_protocol_set() - Introduced rte_mtr_color_in_protocol_get(), rte_mtr_color_in_protocol_priority_get() for getting the configured input color protocol. v4..v3: - Aligned with community meeting call which is documented in https://patches.dpdk.org/project/dpdk/patch/20220301085824.1041009-1-skori@marvell.com/ as last message. With following exception, - Used RTE_MTR_COLOR_IN_*_DSCP instead of RTE_MTR_COLOR_IN_*_IP as there is already dscp_table and rte_mtr_meter_dscp_table_update() API. Changing above symbols break existing application for no good. - Updated 22.07 release notes - Remove testpmd changes from series to finalize the API spec first and then we can send testpmd changes. v3..v2: - Fix input color flags as a bitmask - Add definitions for newly added API v2..v1: - Fix seperate typo v1..RFC: Address the review comments by Cristian at https://patches.dpdk.org/project/dpdk/patch/20210820082401.3778736-1-jerinj@marvell.com/ .../traffic_metering_and_policing.rst | 35 +++ doc/guides/rel_notes/release_22_07.rst | 10 + lib/ethdev/rte_mtr.c | 50 ++++ lib/ethdev/rte_mtr.h | 216 +++++++++++++++++- lib/ethdev/rte_mtr_driver.h | 38 +++ lib/ethdev/version.map | 6 + 6 files changed, 345 insertions(+), 10 deletions(-) diff --git a/doc/guides/prog_guide/traffic_metering_and_policing.rst b/doc/guides/prog_guide/traffic_metering_and_policing.rst index ceb5a96488..d1958a023d 100644 --- a/doc/guides/prog_guide/traffic_metering_and_policing.rst +++ b/doc/guides/prog_guide/traffic_metering_and_policing.rst @@ -21,6 +21,7 @@ The main features are: * Policer actions (per meter output color): recolor, drop * Statistics (per policer output color) * Chaining multiple meter objects +* Protocol based input color selection Configuration steps ------------------- @@ -105,3 +106,37 @@ traffic meter and policing library. * Adding one (or multiple) actions of the type ``RTE_FLOW_ACTION_TYPE_METER`` to the list of meter actions (``struct rte_mtr_meter_policy_params::actions``) specified per color as show in :numref:`figure_rte_mtr_chaining`. + +Protocol based input color selection +------------------------------------ + +The API supports selecting the input color based on the packet content. +Following is the API usage model for the same. + +#. Probe the protocol based input color selection device capabilities using + the following parameters with ``rte_mtr_capabilities_get()`` API. + + * ``struct rte_mtr_capabilities::input_color_proto_mask;`` + * ``struct rte_mtr_capabilities::separate_input_color_table_per_port`` + +#. When creating the meter object using ``rte_mtr_create()``, configure + relevant input color selection parameters such as + + * Fill the tables ``struct rte_mtr_params::dscp_table``, + ``struct rte_mtr_params::vlan_table`` based on input color selected. + + * Update the ``struct rte_mtr_params::default_input_color`` to determine + the default input color in case the input packet does not match + the input color method. + +#. Use the following APIs to configure the meter object + + * Select the input protocol color with ``rte_mtr_color_in_protocol_set()`` API. + + * If needed, update the input color table at runtime using + ``rte_mtr_meter_vlan_table_update()`` and ``rte_mtr_meter_dscp_table_update()`` + APIs. + + * Application can query the configured input color protocol and its associated + priority using ``rte_mtr_color_in_protocol_get()`` and + ``rte_mtr_color_in_protocol_priority_get()`` APIs. diff --git a/doc/guides/rel_notes/release_22_07.rst b/doc/guides/rel_notes/release_22_07.rst index 88d6e96cc1..74ecc3f53d 100644 --- a/doc/guides/rel_notes/release_22_07.rst +++ b/doc/guides/rel_notes/release_22_07.rst @@ -55,6 +55,13 @@ New Features Also, make sure to start the actual text at the margin. ======================================================= +* **Added protocol based input color selection for meter.** + + Added new APIs ``rte_mtr_color_in_protocol_set()``, ``rte_mtr_color_in_protocol_get()``, + ``rte_mtr_color_in_protocol_priority_get()``, ``rte_mtr_meter_vlan_table_update()`` + and updated ``struct rte_mtr_params`` and ``struct rte_mtr_capabilities`` to + support protocol based input color selection for meter. + * **Updated Intel iavf driver.** * Added Tx QoS queue rate limitation support. @@ -112,6 +119,9 @@ ABI Changes * No ABI change that would break compatibility with 21.11. +* Experimental structures ``struct rte_mtr_params`` + and ``struct rte_mtr_capabilities`` updated to support + protocol based input color for meter. Known Issues ------------ diff --git a/lib/ethdev/rte_mtr.c b/lib/ethdev/rte_mtr.c index e49fcf271c..441ea1dca9 100644 --- a/lib/ethdev/rte_mtr.c +++ b/lib/ethdev/rte_mtr.c @@ -207,6 +207,56 @@ rte_mtr_meter_dscp_table_update(uint16_t port_id, mtr_id, dscp_table, error); } +/** MTR object meter VLAN table update */ +int +rte_mtr_meter_vlan_table_update(uint16_t port_id, + uint32_t mtr_id, + enum rte_color *vlan_table, + struct rte_mtr_error *error) +{ + struct rte_eth_dev *dev = &rte_eth_devices[port_id]; + return RTE_MTR_FUNC(port_id, meter_vlan_table_update)(dev, + mtr_id, vlan_table, error); +} + +/** Set the input color protocol on MTR object */ +int +rte_mtr_color_in_protocol_set(uint16_t port_id, + uint32_t mtr_id, + enum rte_mtr_color_in_protocol proto, + uint32_t priority, + struct rte_mtr_error *error) +{ + struct rte_eth_dev *dev = &rte_eth_devices[port_id]; + return RTE_MTR_FUNC(port_id, in_proto_set)(dev, + mtr_id, proto, priority, error); +} + +/** Get input color protocols of MTR object */ +int +rte_mtr_color_in_protocol_get(uint16_t port_id, + uint32_t mtr_id, + uint64_t *proto_mask, + struct rte_mtr_error *error) +{ + struct rte_eth_dev *dev = &rte_eth_devices[port_id]; + return RTE_MTR_FUNC(port_id, in_proto_get)(dev, + mtr_id, proto_mask, error); +} + +/** Get input color protocol priority of MTR object */ +int +rte_mtr_color_in_protocol_priority_get(uint16_t port_id, + uint32_t mtr_id, + enum rte_mtr_color_in_protocol proto, + uint32_t *priority, + struct rte_mtr_error *error) +{ + struct rte_eth_dev *dev = &rte_eth_devices[port_id]; + return RTE_MTR_FUNC(port_id, in_proto_prio_get)(dev, + mtr_id, proto, priority, error); +} + /** MTR object enabled stats update */ int rte_mtr_stats_update(uint16_t port_id, diff --git a/lib/ethdev/rte_mtr.h b/lib/ethdev/rte_mtr.h index 40df0888c8..008bc84f0d 100644 --- a/lib/ethdev/rte_mtr.h +++ b/lib/ethdev/rte_mtr.h @@ -213,6 +213,51 @@ struct rte_mtr_meter_policy_params { const struct rte_flow_action *actions[RTE_COLORS]; }; +/** + * Input color protocol method + * + * More than one of the method can be enabled for a given meter. + * Even if enabled, a method might not be applicable to each input packet, + * in case the associated protocol header is not present in the packet. + * The highest priority method that is both enabled for the meter and also + * applicable for the current input packet wins; + * if none is both enabled and applicable, the default input color is used. + * @see function rte_mtr_color_in_protocol_set() + * + */ +enum rte_mtr_color_in_protocol { + /** + * Enable the detection of the packet input color based on the outermost + * VLAN header fields DEI (1 bit) and PCP (3 bits). + * These fields are used as index into the VLAN table. + * + * @see struct rte_mtr_params::vlan_table + */ + RTE_MTR_COLOR_IN_PROTO_OUTER_VLAN = RTE_BIT64(0), + /** + * Enable the detection of the packet input color based on the innermost + * VLAN header fields DEI (1 bit) and PCP (3 bits). + * These fields are used as index into the VLAN table. + * + * @see struct rte_mtr_params::vlan_table + */ + RTE_MTR_COLOR_IN_PROTO_INNER_VLAN = RTE_BIT64(1), + /** + * Enable the detection of the packet input color based on the outermost + * IP DSCP field. These fields are used as index into the DSCP table. + * + * @see struct rte_mtr_params::dscp_table + */ + RTE_MTR_COLOR_IN_PROTO_OUTER_IP = RTE_BIT64(2), + /** + * Enable the detection of the packet input color based on the innermost + * IP DSCP field. These fields are used as index into the DSCP table. + * + * @see struct rte_mtr_params::dscp_table + */ + RTE_MTR_COLOR_IN_PROTO_INNER_IP = RTE_BIT64(3), +}; + /** * Parameters for each traffic metering & policing object * @@ -233,20 +278,58 @@ struct rte_mtr_params { */ int use_prev_mtr_color; - /** Meter input color. When non-NULL: it points to a pre-allocated and + /** Meter input color based on IP DSCP protocol field. + * + * Valid when *input_color_proto_mask* set to any of the following + * RTE_MTR_COLOR_IN_PROTO_OUTER_IP, + * RTE_MTR_COLOR_IN_PROTO_INNER_IP + * + * When non-NULL: it points to a pre-allocated and * pre-populated table with exactly 64 elements providing the input * color for each value of the IPv4/IPv6 Differentiated Services Code - * Point (DSCP) input packet field. When NULL: it is equivalent to - * setting this parameter to an all-green populated table (i.e. table - * with all the 64 elements set to green color). The color blind mode - * is configured by setting *use_prev_mtr_color* to 0 and *dscp_table* - * to either NULL or to an all-green populated table. When - * *use_prev_mtr_color* is non-zero value or when *dscp_table* contains - * at least one yellow or red color element, then the color aware mode - * is configured. + * Point (DSCP) input packet field. + * + * When NULL: it is equivalent to setting this parameter to an all-green + * populated table (i.e. table with all the 64 elements set to green + * color). The color blind mode is configured by setting + * *use_prev_mtr_color* to 0 and *dscp_table* to either NULL or to an + * all-green populated table. + * + * When *use_prev_mtr_color* is non-zero value or when *dscp_table* + * contains at least one yellow or red color element, then the color + * aware mode is configured. + * + * @see enum rte_mtr_color_in_protocol::RTE_MTR_COLOR_IN_PROTO_OUTER_IP + * @see enum rte_mtr_color_in_protocol::RTE_MTR_COLOR_IN_PROTO_INNER_IP + * @see struct rte_mtr_params::input_color_proto_mask */ enum rte_color *dscp_table; - + /** Meter input color based on VLAN DEI(1bit), PCP(3 bits) protocol + * fields. + * + * Valid when *input_color_proto_mask* set to any of the following + * RTE_MTR_COLOR_IN_PROTO_OUTER_VLAN, + * RTE_MTR_COLOR_IN_PROTO_INNER_VLAN + * + * When non-NULL: it points to a pre-allocated and pre-populated + * table with exactly 16 elements providing the input color for + * each value of the DEI(1bit), PCP(3 bits) input packet field. + * + * When NULL: it is equivalent to setting this parameter to an + * all-green populated table (i.e. table with + * all the 16 elements set to green color). The color blind mode + * is configured by setting *use_prev_mtr_color* to 0 and + * *vlan_table* to either NULL or to an all-green populated table. + * + * When *use_prev_mtr_color* is non-zero value + * or when *vlan_table* contains at least one yellow or + * red color element, then the color aware mode is configured. + * + * @see enum rte_mtr_color_in_protocol::RTE_MTR_COLOR_IN_PROTO_OUTER_VLAN + * @see enum rte_mtr_color_in_protocol::RTE_MTR_COLOR_IN_PROTO_INNER_VLAN + * @see struct rte_mtr_params::input_color_proto_mask + */ + enum rte_color *vlan_table; /** Non-zero to enable the meter, zero to disable the meter at the time * of MTR object creation. Ignored when the meter profile indicated by * *meter_profile_id* is set to NONE. @@ -261,6 +344,12 @@ struct rte_mtr_params { /** Meter policy ID. @see rte_mtr_meter_policy_add() */ uint32_t meter_policy_id; + + /** Input color to be set for the input packet when none of the + * enabled input color methods is applicable to the input packet. + * Ignored when this when *input_color_proto_mask* set to zero. + */ + enum rte_color default_input_color; }; /** @@ -417,6 +506,16 @@ struct rte_mtr_capabilities { * @see enum rte_mtr_stats_type */ uint64_t stats_mask; + + /** Set of supported input color protocol. + * @see enum rte_mtr_color_in_protocol + */ + uint64_t input_color_proto_mask; + + /** When non-zero, it indicates that driver supports separate + * input color table for given ethdev port. + */ + int separate_input_color_table_per_port; }; /** @@ -832,6 +931,103 @@ rte_mtr_meter_dscp_table_update(uint16_t port_id, enum rte_color *dscp_table, struct rte_mtr_error *error); +/** + * MTR object VLAN table update + * + * @param[in] port_id + * The port identifier of the Ethernet device. + * @param[in] mtr_id + * MTR object ID. Needs to be valid. + * @param[in] vlan_table + * When non-NULL: it points to a pre-allocated and pre-populated table with + * exactly 16 elements providing the input color for each value of the + * each value of the DEI(1bit), PCP(3 bits) input packet field. + * When NULL: it is equivalent to setting this parameter to an "all-green" + * populated table (i.e. table with all the 16 elements set to green color). + * @param[out] error + * Error details. Filled in only on error, when not NULL. + * @return + * 0 on success, non-zero error code otherwise. + */ +__rte_experimental +int +rte_mtr_meter_vlan_table_update(uint16_t port_id, uint32_t mtr_id, + enum rte_color *vlan_table, + struct rte_mtr_error *error); + +/** + * Set the input color protocol for a given MTR object + * + * More than one of the method can be enabled for a given meter. + * Even if enabled, a method might not be applicable to each input packet, + * in case the associated protocol header is not present in the packet. + * The highest priority method that is both enabled for the meter and also + * applicable for the current input packet wins; + * if none is both enabled and applicable, the default input color is used. + * + * @param[in] port_id + * The port identifier of the Ethernet device. + * @param[in] mtr_id + * MTR object ID. Needs to be valid. + * @param[in] proto + * Input color protocol. + * @param[in] priority + * Input color protocol priority. Value zero indicates + * the highest priority. + * @param[out] error + * Error details. Filled in only on error, when not NULL. + * @return + * 0 on success, non-zero error code otherwise. + */ +__rte_experimental +int +rte_mtr_color_in_protocol_set(uint16_t port_id, uint32_t mtr_id, + enum rte_mtr_color_in_protocol proto, uint32_t priority, + struct rte_mtr_error *error); + +/** + * Get the input color protocol for a given MTR object + * + * @param[in] port_id + * The port identifier of the Ethernet device. + * @param[in] mtr_id + * MTR object ID. Needs to be valid. + * @param[out] proto_mask + * Selected input color protocols as bit mask. + * @param[out] error + * Error details. Filled in only on error, when not NULL. + * @return + * 0 on success, non-zero error code otherwise. + * + */ +__rte_experimental +int +rte_mtr_color_in_protocol_get(uint16_t port_id, uint32_t mtr_id, + uint64_t *proto_mask, + struct rte_mtr_error *error); + +/** + * Get the priority associated with input color protocol for a given MTR object + * + * @param[in] port_id + * The port identifier of the Ethernet device. + * @param[in] mtr_id + * MTR object ID. Needs to be valid. + * @param[in] proto + * Input color protocol. + * @param[out] priority + * Input color protocol priority associated with proto. + * @param[out] error + * Error details. Filled in only on error, when not NULL. + * @return + * 0 on success, non-zero error code otherwise. + */ +__rte_experimental +int +rte_mtr_color_in_protocol_priority_get(uint16_t port_id, uint32_t mtr_id, + enum rte_mtr_color_in_protocol proto, uint32_t *priority, + struct rte_mtr_error *error); + /** * MTR object enabled statistics counters update * diff --git a/lib/ethdev/rte_mtr_driver.h b/lib/ethdev/rte_mtr_driver.h index ee8c6ef7ad..f7dca9a54c 100644 --- a/lib/ethdev/rte_mtr_driver.h +++ b/lib/ethdev/rte_mtr_driver.h @@ -97,6 +97,32 @@ typedef int (*rte_mtr_meter_dscp_table_update_t)(struct rte_eth_dev *dev, enum rte_color *dscp_table, struct rte_mtr_error *error); +/** @internal mtr object meter vlan table update. */ +typedef int (*rte_mtr_meter_vlan_table_update_t)(struct rte_eth_dev *dev, + uint32_t mtr_id, + enum rte_color *vlan_table, + struct rte_mtr_error *error); + +/** @internal Set the input color protocol on MTR object. */ +typedef int (*rte_mtr_meter_color_in_proto_set_t)(struct rte_eth_dev *dev, + uint32_t mtr_id, + enum rte_mtr_color_in_protocol proto, + uint32_t priority, + struct rte_mtr_error *error); + +/** @internal Get the input color protocols of MTR object. */ +typedef int (*rte_mtr_meter_color_in_proto_get_t)(struct rte_eth_dev *dev, + uint32_t mtr_id, + uint64_t *proto_mask, + struct rte_mtr_error *error); + +/** @internal Get the input color protocol priority of MTR object. */ +typedef int (*rte_mtr_meter_color_in_proto_prio_get_t)(struct rte_eth_dev *dev, + uint32_t mtr_id, + enum rte_mtr_color_in_protocol proto, + uint32_t *priority, + struct rte_mtr_error *error); + /** @internal MTR object enabled stats update. */ typedef int (*rte_mtr_stats_update_t)(struct rte_eth_dev *dev, uint32_t mtr_id, @@ -139,6 +165,18 @@ struct rte_mtr_ops { /** MTR object meter DSCP table update */ rte_mtr_meter_dscp_table_update_t meter_dscp_table_update; + /** MTR object meter VLAN table update */ + rte_mtr_meter_vlan_table_update_t meter_vlan_table_update; + + /** Set the input color protocol on MTR object. */ + rte_mtr_meter_color_in_proto_set_t in_proto_set; + + /** Get the input color protocol of MTR object. */ + rte_mtr_meter_color_in_proto_get_t in_proto_get; + + /** Get the input color protocol priority of MTR object. */ + rte_mtr_meter_color_in_proto_prio_get_t in_proto_prio_get; + /** MTR object enabled stats update */ rte_mtr_stats_update_t stats_update; diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map index 20391ab29e..daca7851f2 100644 --- a/lib/ethdev/version.map +++ b/lib/ethdev/version.map @@ -279,6 +279,12 @@ EXPERIMENTAL { rte_flow_async_action_handle_create; rte_flow_async_action_handle_destroy; rte_flow_async_action_handle_update; + + # added in 22.07 + rte_mtr_color_in_protocol_get; + rte_mtr_color_in_protocol_priority_get; + rte_mtr_color_in_protocol_set; + rte_mtr_meter_vlan_table_update; }; INTERNAL { -- 2.36.0