From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9DAB0A0093; Tue, 3 May 2022 06:23:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 16FC842833; Tue, 3 May 2022 06:23:15 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2086.outbound.protection.outlook.com [40.107.244.86]) by mails.dpdk.org (Postfix) with ESMTP id BE6A14282A for ; Tue, 3 May 2022 06:23:13 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ghzuHhXIO7UbKs7eCUmcEsBnFfvtpMCGrnLOPjsdQfnl72yOcrYbT5K7G6O+ZmYQyz0Pqbn0AHPyy3lH7ZS8SPyQHpoUCKuazzoX/iXabB5vHi8TdzNEh7ryNdZ9jfFv2XQY34CIEBJIrAaSeVcwym93a430k7h8Yps8Zz6Ly9/i04XxPCGf0jkiPC69IoQKKXtEItexdizr6blaC+/nkI9/hLX+BtXa2/LgUgTefaQOiwNvZVMmsS0R2FT0cJ0ffwzWuUyYkpZuJW4rApxG+S/2JeUOlygWQpieFarz+vTskklA9Imyzxeh+C1Mr4jG2FpJ89uNALBcPYk7QSBRjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VLKdXX7LVo/ME6ffKsMZcNJhgBvNt+qk8I73YQZHNsY=; b=TSpnstwDPcqxHgtSjZ7G5BotzaZEhBGscCRazt0yOblNuzXzv9adlEcSLjaQ3mhKSq8Fv7Q2Cop7iuuzEbkNSRcuR4NTdh/Alb6tViMW4WOB+g6TI0GfjcDyHFKUYkDrgqBo0TFCh2Jusy6j9Gwgp4FvuU34kfQwW4oMMYm3LgIwsKpUb7/4K5Or/SomlDDA+YRvFJF71YbDwMVURSHz/TfVPo2qsr7t4+4nCCzO+5xwtOqWde+DIcDwJ+tF+ztcWi6JGs+TbpT02xpVidpvTuAk+BAlQdzMKDEEdoy9cjqyVQn7DqQK+SG6oGLoLmHDBQRTMgP6NY0SWKCPhOn14w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VLKdXX7LVo/ME6ffKsMZcNJhgBvNt+qk8I73YQZHNsY=; b=i9e2Wz0nQEbxenzpL63XpO7p6tridO+VXu3ENFNXUdnH8UpsgYcKmq1VhA4maJPDndS+QNnE56Ug5RMP0XhefgaQ5rxduHZsVyje1PADbgY9prBU0iudn/5swZ2LSmFpCtwLyIRPEj5qAGclzu0a4eUqxLiC3xDhyh7uQiIG5pc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vmware.com; Received: from BYAPR05MB5624.namprd05.prod.outlook.com (2603:10b6:a03:1d::13) by BL0PR05MB5523.namprd05.prod.outlook.com (2603:10b6:208:68::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Tue, 3 May 2022 04:23:11 +0000 Received: from BYAPR05MB5624.namprd05.prod.outlook.com ([fe80::5161:a7c5:8c7d:f3b2]) by BYAPR05MB5624.namprd05.prod.outlook.com ([fe80::5161:a7c5:8c7d:f3b2%7]) with mapi id 15.20.5206.024; Tue, 3 May 2022 04:23:11 +0000 From: Pankaj Gupta To: jbehrens@vmware.com, yongwang@vmware.com Cc: dev@dpdk.org, pagupta@vmware.com Subject: [PATCH 2/8] vmxnet3: implement reta query and reta update Date: Tue, 3 May 2022 00:22:51 -0400 Message-Id: <20220503042257.15626-3-pagupta@vmware.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220503042257.15626-1-pagupta@vmware.com> References: <20220503042257.15626-1-pagupta@vmware.com> Content-Type: text/plain X-ClientProxiedBy: SJ0PR03CA0059.namprd03.prod.outlook.com (2603:10b6:a03:33e::34) To BYAPR05MB5624.namprd05.prod.outlook.com (2603:10b6:a03:1d::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9f07d0e7-f511-4ac3-0a82-08da2cbca1f5 X-MS-TrafficTypeDiagnostic: BL0PR05MB5523:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ml+UFJ/jKRTp0jbVkmdymJOKZYDwIfIF076n0KVWZ1VRS/AfRh8VSko2h5oIYCDmGGF0jOX+efxtx7HMtGyG1IYYBDsjcjwtNJFgI66fOe8VrrKZ5Jp5LOYbagtMmYA0yFlV81OFPB6zax86Y+TxgXHqdxAq+/OZSxhia/zKlgsBTOsv+8a1Gh+G2f4krxpnjDdfRZ8142bAt5Y06d6EDcQcuDb4HVUw40bYrHNZKPh7YgbCcZrf4wz/YqqzqoZpOicHJgvkEA7m4Z7IcjQHLS5GuBrgvG4Tsp8u5ouN6MF+/UeUO/zcxUxRXLLTd8JtZuvr3l+MYSHjSY2LxKKgsv/xtcNVarVwzWRe8AwPD9FLL0xGYzp2TgGUwLC/quITZSZiEVSs75P+9Wbk6i2lvuREfmJ0dfTZBNwDt6hX/T8ZYrpWhBTpQ6S6F477PIHsZnWbrmd+g3LBG7Ls3DhCilJWoIfDLdqB/d4VBQYmWxqedVapHG7KEPfFyAQr9htzEtwKYxTqAq3IpWAfEKr+HEgI0QXkH+DQEhscAfEAsA+PCPQYDUBx2yeJq/nkXL/qGwmN+Az8eRrqKZ0NPW1eBGPOskhHfgDsj5cUadP3A2qNKNu/sCY0AnwpqznQ9SDA1xu6UL/tvPgwfAYpLNtPB3jOxmKHhgCRqnBtzzSqEJvI76uVro3cAw3xSlpo1siK+r3fayCACNMIkk62JviywQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR05MB5624.namprd05.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(6636002)(38350700002)(26005)(107886003)(83380400001)(36756003)(1076003)(8676002)(6506007)(86362001)(2616005)(66476007)(66946007)(66556008)(38100700002)(4326008)(6486002)(508600001)(186003)(316002)(2906002)(8936002)(6666004)(6512007)(52116002)(15650500001)(5660300002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JJ1tL03Jsq34pyBg6X1SsSa3CnzEF9KfVJZ/VGuKXrmEEkkBRQhtt7mTNSVE?= =?us-ascii?Q?qD+MUxm25CGsFZXan7N7q1/4ViuT4UlUIW06eNizNQCT7BN/xxnYSH/20mUO?= =?us-ascii?Q?sdRBnPv9lYuR/ZUH7xz9sxp3tUbKtH5g8P8jHmKmv3HATgrK/Rs3aPXc/70+?= =?us-ascii?Q?sbsRAfzHr++NcXsY9B1QtXWGDeTdZcXTSAt/nPavZViIh1nxg2dq2DaECHtp?= =?us-ascii?Q?MwdE9FD/j2PaVRq9lLcjOCgTISm30Uw0Ol7wPlNPpD/znpDnqD8NADEzRbY4?= =?us-ascii?Q?R414iOgBUI2M07mSWzMwyFlw9vV4wNqwUGT9ocHVpk2uCwAGXGiFN9v70sSu?= =?us-ascii?Q?SIXB/TVpykl/EX+enlErh5k09sQDwGW5sPPDjlSJFVsd9QBjZujzb5KTBTF9?= =?us-ascii?Q?GkaUoQaJcY5PV1qfQ5dJngxeJDoMpCxDpHNPQ/NVHDvvq7LO6GdKxacOBb9g?= =?us-ascii?Q?Ht6nisPz1ir1gIFnNSCopZpRzdgh9x46uxakne2FoCHCLZ5q8iJQ/x2f6w8X?= =?us-ascii?Q?w6kgcCjaFr5nGMvzY5ZdLhVN0+McaAe+YGIP7PBMc4WsTaN+J3/3FXsauUvc?= =?us-ascii?Q?GvJ6KxlVgIZ3tyF+hE9YLITc2TK557RYJX6KKkLuENu/NAkdzkzdevQY6rcC?= =?us-ascii?Q?SrivGvalbKFI6Nlg1K0o6EBF3vy2JQOdITMlKISNBGjIKXRrdha4FHQ3GGE2?= =?us-ascii?Q?nL+nn3CHAnmlurIkP+ZfB5ET5+XjhtAtbkwEBReu3TI47kesWWq59DxDSETs?= =?us-ascii?Q?CmhzaqLZZEIzJNGxmLn10GWadVsTVU/EedI3tFZf8UV/wx+TABu5R8OfbDG4?= =?us-ascii?Q?tBxkHda9SsYr6qzAm9xJyNHNZ1KJBaGKeztOz2L1kA1uvDdqMW4Y4dH+908Y?= =?us-ascii?Q?DY24BOOn25YQAI3F+X3/hccmcaGYSQKXEF6yM3iiZAfX2nZdD/QUz+Lr+xPh?= =?us-ascii?Q?EGnhbufvjCM44inQfNkT3Y+I4d+0tUODKRotFv1Uij4a1DM8HcHhXzgRLx+G?= =?us-ascii?Q?TwEb+BWJhp5dYIhEM9L2mqammmBUuOWyehNuTNZwqftQDUe5+4RQ6Fjd8wcw?= =?us-ascii?Q?NIJZ4xMG+IXkYBcMTK+NneL+Na3Fl/LS2J8skKmQ0vXKlMA3rc+OmgMPwpRI?= =?us-ascii?Q?b6bq55d+MZC1oWfx2AAoKwClXavToF+V15YA5zHqw3Mvu76QShe762H04FWz?= =?us-ascii?Q?+KDbc2MgyjAvxIKi0kDhozbB130CcYMsgTKIj8LWwSsixyLfqM+xwQ8henrc?= =?us-ascii?Q?6hQtZEf5jJMxqzwwHvYds9frh2AC/9jfBu57oVKRjbmkXkCalISv+sw3Jvy1?= =?us-ascii?Q?jj2LCIHf17O8mVbzRQT36BOXuJOEQeXzi6Vi3VGgW99WvaajlZTPQxRzYOge?= =?us-ascii?Q?pEU3oX+Bibn0dhDHwgMHlhNbsmHabTlZLyqTJfpGKLIG8vkbi5PYgrGxopVt?= =?us-ascii?Q?F2A33Mq29uIuSKUIX/XBAoB/3wf6AAO7f01ZvFErXyz7hrMddIDXhH2aCHJd?= =?us-ascii?Q?SBldD0k8scpi49fxzhZCJYFGMgPU6Dg6o8Mpdol+xSYw+5jQukXQALnPR90B?= =?us-ascii?Q?MyELPTVgYNOEZYyyEsZOJEUARwU5+kQt4SXzrMbwGmIJXx7MTgKnMOnb+meY?= =?us-ascii?Q?zvvbnGmedlOSROSknsrPHl+jc+vIwUH07r52KNzXTEWr7H13deevjfByU5sc?= =?us-ascii?Q?0scJPXlUh5kDWa+k1rJTTdqf5z+aIzf0/cZiGxQPYfbFmE/R8UbjkO+sHkQx?= =?us-ascii?Q?tmOHXqyqqw=3D=3D?= X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f07d0e7-f511-4ac3-0a82-08da2cbca1f5 X-MS-Exchange-CrossTenant-AuthSource: BYAPR05MB5624.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 04:23:11.0885 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4OkfNI0o8ENycbKpr5Av1tHyLQRkDd8i4GMFL/XnTYR516lD197ZXe1Q1kZFmRYrO/yA4DUjgwokzML87AIBNA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR05MB5523 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Added reta query and reta update support for VMXNET3 Tested, using testpmd, for different hardware version on ESXi 7.0 Update 2. Signed-off-by: Pankaj Gupta --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 67 ++++++++++++++++++++++++++++ 1 file changed, 67 insertions(+) diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c index a7e1e5fef5..eb65499cf2 100644 --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c @@ -95,6 +95,14 @@ static int vmxnet3_mac_addr_set(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr); static void vmxnet3_process_events(struct rte_eth_dev *dev); static void vmxnet3_interrupt_handler(void *param); +static int +vmxnet3_rss_reta_update(struct rte_eth_dev *dev, + struct rte_eth_rss_reta_entry64 *reta_conf, + uint16_t reta_size); +static int +vmxnet3_rss_reta_query(struct rte_eth_dev *dev, + struct rte_eth_rss_reta_entry64 *reta_conf, + uint16_t reta_size); static int vmxnet3_dev_rx_queue_intr_enable(struct rte_eth_dev *dev, uint16_t queue_id); static int vmxnet3_dev_rx_queue_intr_disable(struct rte_eth_dev *dev, @@ -137,6 +145,8 @@ static const struct eth_dev_ops vmxnet3_eth_dev_ops = { .tx_queue_release = vmxnet3_dev_tx_queue_release, .rx_queue_intr_enable = vmxnet3_dev_rx_queue_intr_enable, .rx_queue_intr_disable = vmxnet3_dev_rx_queue_intr_disable, + .reta_update = vmxnet3_rss_reta_update, + .reta_query = vmxnet3_rss_reta_query, }; struct vmxnet3_xstats_name_off { @@ -1696,3 +1706,60 @@ RTE_PMD_REGISTER_PCI_TABLE(net_vmxnet3, pci_id_vmxnet3_map); RTE_PMD_REGISTER_KMOD_DEP(net_vmxnet3, "* igb_uio | uio_pci_generic | vfio-pci"); RTE_LOG_REGISTER_SUFFIX(vmxnet3_logtype_init, init, NOTICE); RTE_LOG_REGISTER_SUFFIX(vmxnet3_logtype_driver, driver, NOTICE); + +static int +vmxnet3_rss_reta_update(struct rte_eth_dev *dev, + struct rte_eth_rss_reta_entry64 *reta_conf, + uint16_t reta_size) +{ + int i, idx, shift; + struct vmxnet3_hw *hw = dev->data->dev_private; + struct VMXNET3_RSSConf *dev_rss_conf = hw->rss_conf; + + if (reta_size != dev_rss_conf->indTableSize) { + PMD_DRV_LOG(ERR, + "The size of hash lookup table configured (%d) doesn't match " + "the supported number (%d)", + reta_size, dev_rss_conf->indTableSize); + return -EINVAL; + } + + for (i = 0; i < reta_size; i++) { + idx = i / RTE_ETH_RETA_GROUP_SIZE; + shift = i % RTE_ETH_RETA_GROUP_SIZE; + if (reta_conf[idx].mask & (1ULL << shift)) + dev_rss_conf->indTable[i] = (uint8_t)reta_conf[idx].reta[shift]; + } + + VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD, + VMXNET3_CMD_UPDATE_RSSIDT); + + return 0; +} + +static int +vmxnet3_rss_reta_query(struct rte_eth_dev *dev, + struct rte_eth_rss_reta_entry64 *reta_conf, + uint16_t reta_size) +{ + int i, idx, shift; + struct vmxnet3_hw *hw = dev->data->dev_private; + struct VMXNET3_RSSConf *dev_rss_conf = hw->rss_conf; + + if (reta_size != dev_rss_conf->indTableSize) { + PMD_DRV_LOG(ERR, + "Size of requested hash lookup table (%d) doesn't " + "match the configured size (%d)", + reta_size, dev_rss_conf->indTableSize); + return -EINVAL; + } + + for (i = 0; i < reta_size; i++) { + idx = i / RTE_ETH_RETA_GROUP_SIZE; + shift = i % RTE_ETH_RETA_GROUP_SIZE; + if (reta_conf[idx].mask & (1ULL << shift)) + reta_conf[idx].reta[shift] = dev_rss_conf->indTable[i]; + } + + return 0; +} -- 2.17.1