From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7EB60A0032; Wed, 11 May 2022 11:38:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1DD0F40DDD; Wed, 11 May 2022 11:38:39 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 5CED240042; Wed, 11 May 2022 11:38:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652261917; x=1683797917; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=9DQNOx7RUq83AAwyMrW6yih/WK1w3Msuc5Ba8tTFiTc=; b=RmhDtQCgQlW7o/F1e6gXZpyMwQJH3nPeKniJpwx/lsksQg9RjhLyjQVE JwcUztdD/vxzHnjt/s834JRVChSjbdsaUaWDfANhAOKMaodSb607hBiob dokiauO7/zxInMeUUatoRtp2dpS3U3Ax60swqdkKE3YoXxOZli4OF7bMf Jctkj9ZNtERv8cK4asHwzk+ruVWN1BIupbJ22Yn071EtrSZXubJPo8p1j nqxppu6piZNNAaidG+0f3t3M/wRieDtgEOAAMRrfIrFa72JWVx/ae42yI uJR4xuZJaVCm7KxcnKHkVqJ30JBKxIyuiu8jL+JsT4sZKR4o52LPf4Hue g==; X-IronPort-AV: E=McAfee;i="6400,9594,10343"; a="251698803" X-IronPort-AV: E=Sophos;i="5.91,216,1647327600"; d="scan'208";a="251698803" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2022 02:38:35 -0700 X-IronPort-AV: E=Sophos;i="5.91,216,1647327600"; d="scan'208";a="566094991" Received: from unknown (HELO localhost.localdomain) ([10.239.251.251]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2022 02:38:32 -0700 From: Wenwu Ma To: xiaoyun.li@intel.com, aman.deep.singh@intel.com, yuying.zhang@intel.com, dev@dpdk.org Cc: jiayu.hu@intel.com, yinan.wang@intel.com, xingguang.he@intel.com, Wenwu Ma , stable@dpdk.org Subject: [PATCH v2] app/testpmd: perform SW IP checksum for GRO/GSO packets Date: Wed, 11 May 2022 09:35:36 +0000 Message-Id: <20220511093536.28734-1-wenwux.ma@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220511013705.24602-1-wenwux.ma@intel.com> References: <20220511013705.24602-1-wenwux.ma@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The GRO/GSO library doesn't re-calculate checksums for merged/fragmented packets. If users want the packets to have correct IP checksums, they should select HW IP checksum calculation for the port which the packets are transmitted to. But if the port doesn't support HW IP checksum, users may perform a SW IP checksum. This patch add the code about it. Fixes: b7091f1dcfbc ("app/testpmd: enable the heavyweight mode TCP/IPv4 GRO") Fixes: 52f38a2055ed ("app/testpmd: enable TCP/IPv4 VxLAN and GRE GSO") Cc: stable@dpdk.org Signed-off-by: Wenwu Ma --- app/test-pmd/csumonly.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index 8b6665d6f3..e69f31d92c 100644 --- a/app/test-pmd/csumonly.c +++ b/app/test-pmd/csumonly.c @@ -778,6 +778,26 @@ pkt_copy_split(const struct rte_mbuf *pkt) return md[0]; } +/* + * Re-calculate IP checksum for merged/fragmented packets. + */ +static void +pkts_ip_csum_recalc(struct rte_mbuf **pkts_burst, const uint16_t nb_pkts, uint64_t tx_offloads) +{ + int i; + struct rte_ipv4_hdr *ipv4_hdr; + for (i = 0; i < nb_pkts; i++) { + if ((pkts_burst[i]->ol_flags & RTE_MBUF_F_TX_IPV4) && + (tx_offloads & RTE_ETH_TX_OFFLOAD_IPV4_CKSUM) == 0) { + ipv4_hdr = rte_pktmbuf_mtod_offset(pkts_burst[i], + struct rte_ipv4_hdr *, + pkts_burst[i]->l2_len); + ipv4_hdr->hdr_checksum = 0; + ipv4_hdr->hdr_checksum = rte_ipv4_cksum(ipv4_hdr); + } + } +} + /* * Receive a burst of packets, and for each packet: * - parse packet, and try to recognize a supported packet type (1) @@ -1098,6 +1118,8 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) fs->gro_times = 0; } } + + pkts_ip_csum_recalc(pkts_burst, nb_rx, tx_offloads); } #endif @@ -1131,6 +1153,8 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) tx_pkts_burst = gso_segments; nb_rx = nb_segments; + + pkts_ip_csum_recalc(tx_pkts_burst, nb_rx, tx_offloads); } else #endif tx_pkts_burst = pkts_burst; -- 2.25.1