* [PATCH] kni_net.c: use netif_rx() instead of netif_rx_ni()
@ 2022-05-11 11:23 mingli.yu
2022-05-31 16:47 ` Andrew Rybchenko
0 siblings, 1 reply; 2+ messages in thread
From: mingli.yu @ 2022-05-11 11:23 UTC (permalink / raw)
To: dev
From: Mingli Yu <mingli.yu@windriver.com>
The netif_rx_ni is removed in below commit after kernel upgraded
to 5.18, so change accordingly to fix the gap.
2655926aea9b net: Remove netif_rx_any_context() and netif_rx_ni().
Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
---
kernel/linux/kni/kni_net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c
index 7fcfa106cb..58e8fe5af6 100644
--- a/kernel/linux/kni/kni_net.c
+++ b/kernel/linux/kni/kni_net.c
@@ -368,7 +368,7 @@ kni_net_rx_normal(struct kni_dev *kni)
skb->ip_summed = CHECKSUM_UNNECESSARY;
/* Call netif interface */
- netif_rx_ni(skb);
+ netif_rx(skb);
/* Update statistics */
kni->stats.rx_bytes += len;
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] kni_net.c: use netif_rx() instead of netif_rx_ni()
2022-05-11 11:23 [PATCH] kni_net.c: use netif_rx() instead of netif_rx_ni() mingli.yu
@ 2022-05-31 16:47 ` Andrew Rybchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Rybchenko @ 2022-05-31 16:47 UTC (permalink / raw)
To: mingli.yu, dev; +Cc: Jiri Slaby, Min Hu (Connor), Ferruh Yigit
On 5/11/22 14:23, mingli.yu@windriver.com wrote:
> From: Mingli Yu <mingli.yu@windriver.com>
>
> The netif_rx_ni is removed in below commit after kernel upgraded
> to 5.18, so change accordingly to fix the gap.
> 2655926aea9b net: Remove netif_rx_any_context() and netif_rx_ni().
>
> Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
> ---
> kernel/linux/kni/kni_net.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c
> index 7fcfa106cb..58e8fe5af6 100644
> --- a/kernel/linux/kni/kni_net.c
> +++ b/kernel/linux/kni/kni_net.c
> @@ -368,7 +368,7 @@ kni_net_rx_normal(struct kni_dev *kni)
> skb->ip_summed = CHECKSUM_UNNECESSARY;
>
> /* Call netif interface */
> - netif_rx_ni(skb);
> + netif_rx(skb);
>
> /* Update statistics */
> kni->stats.rx_bytes += len;
There are two more patches [1] and [2] in the patchwork on the topic and
it looks like the latest is the best one. Do you have any comments on
[2]?
[1]
https://patches.dpdk.org/project/dpdk/patch/20220521070642.35413-1-humin29@huawei.com/
[2]https://patches.dpdk.org/project/dpdk/patch/20220525102641.20982-1-jslaby@suse.cz/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-31 16:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-11 11:23 [PATCH] kni_net.c: use netif_rx() instead of netif_rx_ni() mingli.yu
2022-05-31 16:47 ` Andrew Rybchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).