From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 273E3A00C3; Thu, 12 May 2022 19:27:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C5D2E40E64; Thu, 12 May 2022 19:27:01 +0200 (CEST) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id 0963C40DDD for ; Thu, 12 May 2022 19:27:00 +0200 (CEST) Received: by mail-pl1-f181.google.com with SMTP id n8so5574834plh.1 for ; Thu, 12 May 2022 10:26:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9d32o15Yl/uxU1s+w2lTlLAXzMMip41yjsR9wDW5o1s=; b=r1mjdRrEvJuaxiWmVv/KmZQV0MpJCcXUz+pSzMQ3s8p1NXYZvqDzrVInEUENZGP1aK a+YR7Au2/mOGYAHgfGgdslpu4FT1Tv1+bxjDBdAisk1mwFc/pFdmGth+6oTX4AXmisIf Js3JuMvDgHB3EBcCE4AoS9jNIcGNBR5Zb+QDT4TLtS8+gdVWGBWlcM48Fv3LX/5MiSaJ YHJfbElgRhAIxtmgqB+l3Fg0/ZvLvX6LYJw6vYRT2qRwHTTp1pLVAgJOkhSdClm8hTLD miBTo0TjM6bhCNxdv09/eqyJgS5S/v2IcwyX1LLx7CmmBPbUyFsRvjrwtTJLpfdNv1eu J/GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9d32o15Yl/uxU1s+w2lTlLAXzMMip41yjsR9wDW5o1s=; b=dOHTkcWh96VCpuOO9YtWB6eoWx6ZSJRhtKjxXvxIHO8GaxRXOmeKq14l7t7g83WakS us8dE+B/NDiQpY4DSIWjmm7Guz1HEzHSjTxT0VtU6Yqbd9uYhnppuyiqxlVdUAxVCRKj dR71CC6bCPvcap0jOzkap483dlHAZGQo+lq3jpgI8IhoK+C6Gp2R9tCOEx5a2wpjY/AA 96JYNNdP+MIV3OafvKTwnWwYY3QtQH6WfMPQIqtx7PheSknzLx4BBX8wygR6mLJLBBMq xvTWFkeGeDn+3dlJKJarz87YpEIwCyb95/9g5apuSnxU2RzNF0MPmy95HIw72fQWnhQ7 tqUw== X-Gm-Message-State: AOAM532pibC8k8HwuaOj2IKOBua4naTP0JDJuz/3ayvaU7/sWitPF07V K+c/LNK4ksS2/R6WYQROKefrPA== X-Google-Smtp-Source: ABdhPJz2e2B74pgtsXTsR/p7Y5MsP5661XOA0WBFDQPCPQHwBUyYOgVCIqXfi7iNpSZDUbkw1FBqsg== X-Received: by 2002:a17:903:1cd:b0:15e:8c4a:c543 with SMTP id e13-20020a17090301cd00b0015e8c4ac543mr928261plh.126.1652376419202; Thu, 12 May 2022 10:26:59 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id l62-20020a639141000000b003c14af50625sm2111823pge.61.2022.05.12.10.26.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 May 2022 10:26:58 -0700 (PDT) Date: Thu, 12 May 2022 10:26:55 -0700 From: Stephen Hemminger To: Ke Zhang Cc: xiaoyun.li@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com, dev@dpdk.org Subject: Re: [PATCH v5] fix mbuf release function point corrupt in multi-process Message-ID: <20220512102655.35af90a9@hermes.local> In-Reply-To: <20220512055719.181652-1-ke1x.zhang@intel.com> References: <20220510025428.110325-1-ke1x.zhang@intel.com> <20220512055719.181652-1-ke1x.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 12 May 2022 05:57:19 +0000 Ke Zhang wrote: > > -static const struct iavf_rxq_ops def_rxq_ops = { > - .release_mbufs = release_rxq_mbufs, > +static > +struct iavf_rxq_ops iavf_rxq_release_mbufs_ops[] = { > + [IAVF_REL_MBUFS_DEFAULT].release_mbufs = release_rxq_mbufs, > + [IAVF_REL_MBUFS_SSE_VEC].release_mbufs = iavf_rx_queue_release_mbufs_sse, > }; > > -static const struct iavf_txq_ops def_txq_ops = { > - .release_mbufs = release_txq_mbufs, > +static > +struct iavf_txq_ops iavf_txq_release_mbufs_ops[] = { > + [IAVF_REL_MBUFS_DEFAULT].release_mbufs = release_txq_mbufs, > + [IAVF_REL_MBUFS_SSE_VEC].release_mbufs = iavf_tx_queue_release_mbufs_sse, > + [IAVF_REL_MBUFS_AVX512_VEC].release_mbufs = iavf_tx_queue_release_mbufs_avx512, > }; Did you have to take const off of these?