From: taoyunxiang <taoyunxiang@cmss.chinamobile.com>
To: dev@dpdk.org
Cc: taoyunxiang <taoyunxiang@cmss.chinamobile.com>
Subject: [PATCH] bus: fix code unused
Date: Thu, 12 May 2022 20:19:58 +0800 [thread overview]
Message-ID: <20220512121958.2491-1-taoyunxiang@cmss.chinamobile.com> (raw)
In-Reply-To: <8>
The return value of pci_plug in pci_common.c
will always be int vaule, can not be NULL.
We could use not 0 to check it.
Author: Tao YunXiang <taoyunxiang@cmss.chinamobile.com>
Signed-off-by: Tao YunXiang <taoyunxiang@cmss.chinamobile.com>
---
lib/eal/common/eal_common_dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/eal/common/eal_common_dev.c b/lib/eal/common/eal_common_dev.c
index 148a23830a..99677bae58 100644
--- a/lib/eal/common/eal_common_dev.c
+++ b/lib/eal/common/eal_common_dev.c
@@ -143,7 +143,7 @@ local_dev_probe(const char *devargs, struct rte_device **new_dev)
if (ret)
goto err_devarg;
- if (da->bus->plug == NULL) {
+ if (da->bus->plug != 0) {
RTE_LOG(ERR, EAL, "Function plug not supported by bus (%s)\n",
da->bus->name);
ret = -ENOTSUP;
--
2.12.2
next parent reply other threads:[~2022-05-16 7:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <8>
2022-05-12 12:19 ` taoyunxiang [this message]
2022-05-16 7:55 ` David Marchand
2022-05-17 1:54 ` taoyunxiang
2022-05-18 12:07 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220512121958.2491-1-taoyunxiang@cmss.chinamobile.com \
--to=taoyunxiang@cmss.chinamobile.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).