From: "Min Hu (Connor)" <humin29@huawei.com> To: <dev@dpdk.org> Cc: <ferruh.yigit@intel.com>, <andrew.rybchenko@oktetlabs.ru>, <ktraynor@redhat.com>, <thomas@monjalon.net> Subject: [PATCH V3 2/2] ethdev: document default and non-default MAC address Date: Sat, 14 May 2022 10:00:49 +0800 Message-ID: <20220514020049.57294-3-humin29@huawei.com> (raw) In-Reply-To: <20220514020049.57294-1-humin29@huawei.com> From: Huisong Li <lihuisong@huawei.com> The rte_eth_dev_data::mac_addrs is a MAC address array. The index zero of this array is as the default address index, and other indexes can't be the same as the address corresponding to index 0. If we break it, may cause following problems: 1) waste of MAC address spaces. 2) a fake MAC address in the MAC list, isn't in hardware MAC entries. 3) a MAC address is assigned to diffent pool. Signed-off-by: Huisong Li <lihuisong@huawei.com> Signed-off-by: Min Hu <humin29@huawei.com> --- lib/ethdev/ethdev_driver.h | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/ethdev/ethdev_driver.h b/lib/ethdev/ethdev_driver.h index 69d9dc21d8..d49e9138c6 100644 --- a/lib/ethdev/ethdev_driver.h +++ b/lib/ethdev/ethdev_driver.h @@ -115,7 +115,12 @@ struct rte_eth_dev_data { uint64_t rx_mbuf_alloc_failed; /**< Rx ring mbuf allocation failures */ - /** Device Ethernet link address. @see rte_eth_dev_release_port() */ + /** + * Device Ethernet link address. The index zero of the array is as the + * index of the default address, and other indexes can't be the same + * as the address corresponding to index 0. + * @see rte_eth_dev_release_port() + */ struct rte_ether_addr *mac_addrs; /** Bitmap associating MAC addresses to pools */ uint64_t mac_pool_sel[RTE_ETH_NUM_RECEIVE_MAC_ADDR]; -- 2.33.0
next prev parent reply other threads:[~2022-05-14 2:01 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-22 3:36 [dpdk-dev] [PATCH] ethdev: fix one MAC address occupies two index in mac addrs Min Hu (Connor) 2021-09-22 6:39 ` Andrew Rybchenko 2021-09-22 7:43 ` Huisong Li 2021-09-22 8:02 ` Andrew Rybchenko 2021-09-22 9:48 ` Huisong Li 2021-10-05 19:21 ` Thomas Monjalon 2021-10-08 7:02 ` Min Hu (Connor) 2021-10-08 10:04 ` Thomas Monjalon 2021-10-09 9:53 ` Min Hu (Connor) 2021-10-11 9:02 ` Thomas Monjalon 2021-10-11 9:28 ` [dpdk-dev] [PATCH v2] " Min Hu (Connor) 2021-10-11 10:35 ` Thomas Monjalon 2021-10-12 2:58 ` lihuisong (C) 2021-10-12 7:14 ` Thomas Monjalon 2021-10-15 2:00 ` lihuisong (C) 2021-10-19 17:45 ` Ferruh Yigit 2021-10-20 6:49 ` lihuisong (C) 2021-10-20 7:41 ` Ferruh Yigit 2021-10-20 10:15 ` Kevin Traynor 2021-10-20 16:32 ` Ferruh Yigit 2021-10-21 2:05 ` lihuisong (C) 2021-10-21 8:30 ` Ferruh Yigit 2021-10-22 2:04 ` lihuisong (C) 2021-10-26 10:21 ` Ferruh Yigit 2021-11-08 6:55 ` lihuisong (C) 2022-04-25 6:42 ` Min Hu (Connor) 2022-05-14 2:00 ` [PATCH V3 0/2] ethdev: fix MAC addrs list Min Hu (Connor) 2022-05-14 2:00 ` [PATCH V3 1/2] ethdev: fix one address occupies two indexes in MAC addrs Min Hu (Connor) 2022-05-14 2:00 ` Min Hu (Connor) [this message] 2022-05-31 15:22 ` [PATCH V3 0/2] ethdev: fix MAC addrs list Andrew Rybchenko 2022-06-01 6:43 ` Min Hu (Connor) 2022-06-01 6:39 ` [PATCH v4 " Min Hu (Connor) 2022-06-01 6:39 ` [PATCH v4 1/2] ethdev: fix one address occupies two indexes in MAC addrs Min Hu (Connor) 2022-06-01 17:49 ` Andrew Rybchenko 2022-06-02 3:16 ` lihuisong (C) 2022-06-02 13:54 ` Andrew Rybchenko 2022-06-11 9:04 ` lihuisong (C) 2022-06-01 6:39 ` [PATCH v4 2/2] ethdev: document default and non-default MAC address Min Hu (Connor) 2022-06-01 17:49 ` Andrew Rybchenko 2022-06-01 17:49 ` [PATCH v4 0/2] ethdev: fix MAC addrs list Andrew Rybchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220514020049.57294-3-humin29@huawei.com \ --to=humin29@huawei.com \ --cc=andrew.rybchenko@oktetlabs.ru \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=ktraynor@redhat.com \ --cc=thomas@monjalon.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git