From: Stephen Hemminger <stephen@networkplumber.org>
To: Steve Yang <stevex.yang@intel.com>
Cc: dev@dpdk.org, yuying.zhang@intel.com, qi.z.zhang@intel.com
Subject: Re: [PATCH v3] app/testpmd: support ddp dump command for ice
Date: Wed, 18 May 2022 08:24:32 -0700 [thread overview]
Message-ID: <20220518082432.4072557b@hermes.local> (raw)
In-Reply-To: <20220518065806.1005694-1-stevex.yang@intel.com>
On Wed, 18 May 2022 06:58:06 +0000
Steve Yang <stevex.yang@intel.com> wrote:
> +#define ICE_BUFF_SIZE 0x000c9000
Having magic size hard coded in testpmd is bad idea.
If there is driver specific size it should be exposed by API
> + size = ICE_BUFF_SIZE;
> + buff = (uint8_t *)malloc(ICE_BUFF_SIZE);
Cast of void * is not necessary in C (only C++)
next prev parent reply other threads:[~2022-05-18 15:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 8:02 [PATCH v1 0/2] ICE ddp download tool Steve Yang
2022-05-11 8:02 ` [PATCH v1 1/2] net/ice: support dump ice ddp package Steve Yang
2022-05-18 4:22 ` Zhang, Qi Z
2022-05-24 2:49 ` Zhang, Qi Z
2022-05-18 15:21 ` Stephen Hemminger
2022-05-11 8:02 ` [PATCH v1 2/2] app/testpmd: support dump_pkg command for ice Steve Yang
2022-05-18 4:32 ` Zhang, Qi Z
2022-05-12 2:06 ` [PATCH v2 0/2] ICE ddp download tool Steve Yang
2022-05-12 2:06 ` [PATCH v2 1/2] net/ice: support dump ice ddp package Steve Yang
2022-05-12 2:06 ` [PATCH v2 2/2] app/testpmd: support dump_pkg command for ice Steve Yang
2022-05-18 6:58 ` [PATCH v3] app/testpmd: support ddp dump " Steve Yang
2022-05-18 15:24 ` Stephen Hemminger [this message]
2022-05-19 8:14 ` Andrew Rybchenko
2022-05-19 12:12 ` David Marchand
2022-05-20 3:07 ` Zhang, Qi Z
2022-05-21 1:19 ` Zhang, Qi Z
2022-05-23 7:14 ` David Marchand
2022-06-09 7:39 ` [PATCH v4] net/ice: support dump DDP runtime configure Steve Yang
2022-06-09 8:40 ` Zhang, Qi Z
2022-06-10 1:16 ` Zhang, Qi Z
2022-06-10 1:14 ` [PATCH v5] " Steve Yang
2022-06-10 2:25 ` Zhang, Qi Z
2022-06-23 13:10 ` Thomas Monjalon
2022-06-23 13:13 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220518082432.4072557b@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=stevex.yang@intel.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).